New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 835379 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

services_unittests failing on multiple builders

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Apr 20 2018

Issue description

Comment 1 by piman@chromium.org, Apr 20 2018

Cc: mcasas@chromium.org
Components: Blink>Media
Owner: junwei...@intel.com
This is the FaceDetectionImplMacTest.ScanOneFace test, example failure:

[ RUN      ] FaceDetectionImplMacTest.ScanOneFace/2
../../services/shape_detection/face_detection_impl_mac_unittest.mm:91: Failure
Expected equality of these values:
  num_landmarks
    Which is: 0
  face->landmarks.size()
    Which is: 3
Stack trace:
0   services_unittests                  0x00000001011241ab testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91
1   services_unittests                  0x0000000101123b69 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89
2   services_unittests                  0x0000000100bfd6b4 shape_detection::FaceDetectionImplMacTest::DetectCallback(unsigned long, unsigned long, std::__1::vector<mojo::StructPtr<shape_detection::mojom::FaceDetectionResult>, std::__1::allocator<mojo::StructPtr<shape_detection::mojom::FaceDetectionResult> > >) + 628
3   services_unittests                  0x0000000100c00f4a void base::internal::FunctorTraits<void (shape_detection::FaceDetectionImplMacTest::*)(unsigned long, unsigned long, std::__1::vector<mojo::StructPtr<shape_detection::mojom::FaceDetectionResult>, std::__1::allocator<mojo::StructPtr<shape_detection::mojom::FaceDetectionResult> > >), void>::Invoke<shape_detection::FaceDetectionImplMacTest_ScanOneFace_Test*, unsigned long, unsigned long, std::__1::vector<mojo::StructPtr<shape_detection::mojom::FaceDetectionResult>, std::__1::allocator<mojo::StructPtr<shape_detection::mojom::FaceDetectionResult> > > >(void (shape_detection::FaceDetectionImplMacTest::*)(unsigned long, unsigned long, std::__1::vector<mojo::StructPtr<shape_detection::mojom::FaceDetectionResult>, std::__1::allocator<mojo::StructPtr<shape_detection::mojom::FaceDetectionResult> > >), shape_detection::FaceDetectionImplMacTest_ScanOneFace_Test*&&, unsigned long&&, unsigned long&&, std::__1::vector<mojo::StructPtr<shape_detection::mojom::FaceDetectionResult>, std::__1::allocator<mojo::StructPtr<shape_detection::mojom::FaceDetectionResult> > >&&) + 90
4   services_unittests                  0x0000000100c00edf base::internal::Invoker<base::internal::BindState<void (shape_detection::FaceDetectionImplMacTest::*)(unsigned long, unsigned long, std::__1::vector<mojo::StructPtr<shape_detection::mojom::FaceDetectionResult>, std::__1::allocator<mojo::StructPtr<shape_detection::mojom::FaceDetectionResult> > >), base::internal::UnretainedWrapper<shape_detection::FaceDetectionImplMacTest_ScanOneFace_Test>, unsigned long, unsigned long>, void (std::__1::vector<mojo::StructPtr<shape_detection::mojom::FaceDetectionResult>, std::__1::allocator<mojo::StructPtr<shape_detection::mojom::FaceDetectionResult> > >)>::RunOnce(base::internal::BindStateBase*, std::__1::vector<mojo::StructPtr<shape_detection::mojom::FaceDetectionResult>, std::__1::allocator<mojo::StructPtr<shape_detection::mojom::FaceDetectionResult> > >&&) + 47
5   services_unittests                  0x0000000102a639f2 base::OnceCallback<void (std::__1::vector<mojo::StructPtr<shape_detection::mojom::FaceDetectionResult>, std::__1::allocator<mojo::StructPtr<shape_detection::mojom::FaceDetectionResult> > >)>::Run(std::__1::vector<mojo::StructPtr<shape_detection::mojom::FaceDetectionResult>, std::__1::allocator<mojo::StructPtr<shape_detection::mojom::FaceDetectionResult> > >) + 114
6   services_unittests                  0x0000000102a64b6f shape_detection::FaceDetectionImplMacVision::OnFacesDetected(VNRequest*, NSError*) + 2367
7   services_unittests                  0x0000000102a65d2a base::RepeatingCallback<void (VNRequest*, NSError*)>::Run(VNRequest*, NSError*) && + 122
8   services_unittests                  0x0000000102a65c88 base::internal::Invoker<base::internal::BindState<base::RepeatingCallback<void (VNRequest*, NSError*)>, VNRequest*, NSError*>, void ()>::RunOnce(base::internal::BindStateBase*) + 104
9   services_unittests                  0x0000000102acde23 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 323
10  services_unittests                  0x0000000102b01d19 base::internal::IncomingTaskQueue::RunTask(base::PendingTask*) + 121
11  services_unittests                  0x0000000102b05a27 base::MessageLoop::RunTask(base::PendingTask*) + 599
12  services_unittests                  0x0000000102b05dea base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) + 186
13  services_unittests                  0x0000000102b0605c base::MessageLoop::DoWork() + 572
14  services_unittests                  0x0000000102b08d08 base::MessagePumpDefault::Run(base::MessagePump::Delegate*) + 216
15  services_unittests                  0x0000000102b05404 base::MessageLoop::Run(bool) + 132
16  services_unittests                  0x0000000102b3daa9 base::RunLoop::Run() + 249
17  services_unittests                  0x0000000100bfccbd shape_detection::FaceDetectionImplMacTest_ScanOneFace_Test::TestBody() + 3389

[  FAILED  ] FaceDetectionImplMacTest.ScanOneFace/2, where GetParam() = 48-byte object <00-00 00-00 78-00 00-00 78-00 00-00 00-00 00-00 F1-C5 90-06 01-00 00-00 01-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 E0-39 D8-BA F7-7F 00-00> (333 ms)


This is almost certainly due to https://chromium-review.googlesource.com/c/chromium/src/+/982579

Please revert?

Comment 2 by piman@chromium.org, Apr 20 2018

Labels: -Pri-2 Pri-1
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7789a10073046b74e4b42290128f03e0f6452646

commit 7789a10073046b74e4b42290128f03e0f6452646
Author: Miguel Casas <mcasas@chromium.org>
Date: Fri Apr 20 22:04:26 2018

Revert "ShapeDetection: Parse landmarks of the detected face on Mac Vision"

This reverts commit 5e1aa79bdbec0c9e4dfdb1bb45a4aa2a1aee73c5.

Reason for revert: broke some tests, see  https://crbug.com/835379 

Bug:835379

Original change's description:
> ShapeDetection: Parse landmarks of the detected face on Mac Vision
> 
> Update the mojom interface definition of landmark to match the Spec, and adjust
> the usage in services/blink/LayoutTests.
> Export eyes and mouth landmarks that detect with Mac Vision Framework, the points
> are normalized to the bounding box of the detected face, with the origin at the
> bounding box of the detected face's lower-left corner.
> 
> Link Mac 10.13 build bots [1] and Face Detection demo[2] here.
> 
> [1] https://ci.chromium.org/buildbot/chromium.fyi/Chromium%20Mac%2010.13/
> [2] https://codepen.io/miguelao/pen/PmJWro
> 
> BUG= 799319 
> 
> Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng
> Change-Id: Id034721a517e4ab2a6b9aa0e3eec9d10997b5b80
> Reviewed-on: https://chromium-review.googlesource.com/982579
> Reviewed-by: Miguel Casas <mcasas@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Junwei Fu <junwei.fu@intel.com>
> Cr-Commit-Position: refs/heads/master@{#552217}

TBR=dcheng@chromium.org,reillyg@chromium.org,mcasas@chromium.org,junwei.fu@intel.com,mark@chromium.org

Change-Id: Ia6de675508ad324e12b4b9e98ae510b12d06b672
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  799319 
Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/1022891
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552488}
[modify] https://crrev.com/7789a10073046b74e4b42290128f03e0f6452646/base/mac/sdk_forward_declarations.h
[modify] https://crrev.com/7789a10073046b74e4b42290128f03e0f6452646/services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImplGmsCore.java
[modify] https://crrev.com/7789a10073046b74e4b42290128f03e0f6452646/services/shape_detection/face_detection_impl_mac.mm
[modify] https://crrev.com/7789a10073046b74e4b42290128f03e0f6452646/services/shape_detection/face_detection_impl_mac_vision.mm
[modify] https://crrev.com/7789a10073046b74e4b42290128f03e0f6452646/services/shape_detection/public/mojom/facedetection.mojom
[modify] https://crrev.com/7789a10073046b74e4b42290128f03e0f6452646/third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
[modify] https://crrev.com/7789a10073046b74e4b42290128f03e0f6452646/third_party/WebKit/LayoutTests/shapedetection/resources/mock-facedetection.js
[modify] https://crrev.com/7789a10073046b74e4b42290128f03e0f6452646/third_party/blink/renderer/modules/shapedetection/face_detector.cc

Comment 4 by mcasas@chromium.org, Apr 20 2018

Status: Fixed (was: Assigned)
hopefully fixed - let's check on the GPU FYI

Sign in to add a comment