New issue
Advanced search Search tips

Issue 835378 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Build-Toolchain



Sign in to add a comment

mosys binary has executable stack markings

Project Member Reported by manojgupta@chromium.org, Apr 20 2018

Issue description

http://cautotest.corp.google.com/afe/#tab_id=view_job&object_id=193607308

Generally this happens if assembly files are not tagged correctly.

https://wiki.gentoo.org/wiki/Hardened/GNU_stack_quickstart

Adding this this to end of assembly file should generally fix the problem for assembly files.

#if defined(__linux__) && defined(__ELF__)
.section .note.GNU-stack,"",%progbits
#endif

If mosys does need executable stack, please let us know so that we can filter it.
 
Components: OS>Systems
friendly ping.
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/mosys/+/0a2e82b912985764450ced09dd5bdd2ca2a546f4

commit 0a2e82b912985764450ced09dd5bdd2ca2a546f4
Author: C Shapiro <shapiroc@chromium.org>
Date: Fri Apr 27 04:10:07 2018

mosys: Remove executable stack markings

BUG= chromium:835378 
TEST=emerge-reef and local test

Change-Id: I41b5931ec36a3f5d15ca71ec220cd76e372fcdca
Reviewed-on: https://chromium-review.googlesource.com/1029008
Commit-Ready: C Shapiro <shapiroc@google.com>
Tested-by: C Shapiro <shapiroc@google.com>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/0a2e82b912985764450ced09dd5bdd2ca2a546f4/lib/cros_config/config.dtb.S

Status: Fixed (was: Assigned)

Sign in to add a comment