[Mac] Checkbox focus ring has unwanted white area between ring and checkbox border |
||||||||
Issue descriptionChrome Version: 66.0.3359.117 OS: macOS 10.12 What steps will reproduce the problem? (1) Go to chrome://extensions (2) Click the Remove button on one of your extensions (3) Tab around in the dialog that appears until the checkbox has keyboard focus What is the expected result? The checkbox's focus ring should be a solid blue outline around the checkbox border What happens instead? There is a thin strip of white between the focus ring and the checkbox's border.
,
Apr 27 2018
,
Apr 27 2018
Assigning based off of triage rules.
,
Apr 30 2018
,
Apr 30 2018
,
May 7 2018
#6: Yep, I agree with that reading. I have a CL in progress that reworks how focus rings are drawn so that Views can supply an arbitraryish SkPath for their focus ring to be drawn around; I'll fix this in the process of fixing that I think.
,
May 8 2018
Before & after on Mac - the after doesn't look perfect yet but it looks a lot closer. These are for <https://chromium-review.googlesource.com/#/c/chromium/src/+/1050185>.
,
May 8 2018
Mac before & after for RadioButton (the other affected control - identical look) and MdTextButton (a sample unaffected control - identical look).
,
May 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/824d232c3d3630d9486a33f3cbc9be6077654c40 commit 824d232c3d3630d9486a33f3cbc9be6077654c40 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Mon May 21 16:04:51 2018 views: introduce focus ring paths This change adds support for Mac-style "focus ring paths" to Views, which means that a given View can (via FocusRing::Delegate) supply an arbitrary path for its focus ring to be drawn around when it has a focus ring. This removes the need for Checkbox and RadioButton to have their own focus ring implementations. It will also be necessary as the MD refresh work adds more circular/oval controls in top chrome. This work leads into a longer-term effort to make FocusRing not be a View; see https://crbug.com/840796 for details about that. Bug: 836946 , 835376 Change-Id: I433dc370e5fbc2ff30b53b070d84255199b6ec29 Reviewed-on: https://chromium-review.googlesource.com/1050185 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#560278} [modify] https://crrev.com/824d232c3d3630d9486a33f3cbc9be6077654c40/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc [modify] https://crrev.com/824d232c3d3630d9486a33f3cbc9be6077654c40/chrome/browser/ui/views/frame/app_menu_button.cc [modify] https://crrev.com/824d232c3d3630d9486a33f3cbc9be6077654c40/chrome/browser/ui/views/location_bar/location_bar_view.cc [modify] https://crrev.com/824d232c3d3630d9486a33f3cbc9be6077654c40/chrome/browser/ui/views/location_bar/location_bar_view.h [modify] https://crrev.com/824d232c3d3630d9486a33f3cbc9be6077654c40/chrome/browser/ui/views/page_action/page_action_icon_view.cc [modify] https://crrev.com/824d232c3d3630d9486a33f3cbc9be6077654c40/chrome/browser/ui/views/page_action/page_action_icon_view.h [modify] https://crrev.com/824d232c3d3630d9486a33f3cbc9be6077654c40/chrome/browser/ui/views/toolbar/toolbar_action_view.cc [modify] https://crrev.com/824d232c3d3630d9486a33f3cbc9be6077654c40/chrome/browser/ui/views/toolbar/toolbar_button.cc [modify] https://crrev.com/824d232c3d3630d9486a33f3cbc9be6077654c40/ui/views/controls/button/button.cc [modify] https://crrev.com/824d232c3d3630d9486a33f3cbc9be6077654c40/ui/views/controls/button/button.h [modify] https://crrev.com/824d232c3d3630d9486a33f3cbc9be6077654c40/ui/views/controls/button/checkbox.cc [modify] https://crrev.com/824d232c3d3630d9486a33f3cbc9be6077654c40/ui/views/controls/button/checkbox.h [modify] https://crrev.com/824d232c3d3630d9486a33f3cbc9be6077654c40/ui/views/controls/button/md_text_button.cc [modify] https://crrev.com/824d232c3d3630d9486a33f3cbc9be6077654c40/ui/views/controls/button/md_text_button.h [modify] https://crrev.com/824d232c3d3630d9486a33f3cbc9be6077654c40/ui/views/controls/button/radio_button.cc [modify] https://crrev.com/824d232c3d3630d9486a33f3cbc9be6077654c40/ui/views/controls/button/radio_button.h [modify] https://crrev.com/824d232c3d3630d9486a33f3cbc9be6077654c40/ui/views/controls/combobox/combobox.cc [modify] https://crrev.com/824d232c3d3630d9486a33f3cbc9be6077654c40/ui/views/controls/combobox/combobox.h [modify] https://crrev.com/824d232c3d3630d9486a33f3cbc9be6077654c40/ui/views/controls/focus_ring.cc [modify] https://crrev.com/824d232c3d3630d9486a33f3cbc9be6077654c40/ui/views/controls/focus_ring.h [modify] https://crrev.com/824d232c3d3630d9486a33f3cbc9be6077654c40/ui/views/controls/scroll_view.cc [modify] https://crrev.com/824d232c3d3630d9486a33f3cbc9be6077654c40/ui/views/controls/scroll_view.h [modify] https://crrev.com/824d232c3d3630d9486a33f3cbc9be6077654c40/ui/views/controls/textfield/textfield.cc [modify] https://crrev.com/824d232c3d3630d9486a33f3cbc9be6077654c40/ui/views/controls/textfield/textfield.h [modify] https://crrev.com/824d232c3d3630d9486a33f3cbc9be6077654c40/ui/views/examples/button_sticker_sheet.cc [modify] https://crrev.com/824d232c3d3630d9486a33f3cbc9be6077654c40/ui/views/view.cc [modify] https://crrev.com/824d232c3d3630d9486a33f3cbc9be6077654c40/ui/views/view_observer.h
,
May 22 2018
Able to reproduce the issue on chrome version 66.03359.117(build without fix) Verified the fix on Mac 10.13.3 Chrome version #68.0.3437.2 as per the comment #0. Attaching screencast for reference. Observed that ""there is no white area between ring and checkbox border."" Note: Issue is still seen on #68.0.3437.2 using Linux and Windows hence not adding verified labels. Thanks...!
,
May 23 2018
,
Jul 16
Able to reproduce the issue on chrome version 66.0.3359.117 (build withtout fix) as per the comment #0. Verified the fix on Mac 10.12.6 using Chrome version # 69.0.3493.0. Attaching screen-cast for reference. Observed that "Solid blue outline on the check box's focus ring" The fix is working as expected, adding Verified labels Thanks...! |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by robliao@chromium.org
, Apr 27 2018Labels: -Pri-3 MacViews-Controls Proj-MacViews Pri-2
Status: Available (was: Untriaged)