New issue
Advanced search Search tips

Issue 835372 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 29
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Mac] Modal dialog comes up empty after Chrome is unhidden

Project Member Reported by shrike@chromium.org, Apr 20 2018

Issue description

Chrome Version: 66.0.3359.117
OS: macOS 10.12

What steps will reproduce the problem?
(1) Go to chrome://extensions
(2) Click the Remove button in one of your extensions
(3) Hide Chrome
(4) Wait a bit, then unhide Chrome

What is the expected result?
The modal dialog that appears after step 2 should have its normal content.

What happens instead?
The modal dialog that appears after step 2 is empty, showing only a blurred background. After about a second the content reappears.

I originally discovered this when taking a timed screenshot for another bug. I was clicking on a button in the dialog, and the timed screenshot made Grab the active app, switching me away from Chrome. When I switched back to Chrome, the dialog was empty for about a second. So this is more than Chrome being hidden, I was just able to reproduce easily by hiding and unhiding.

 
EmptyDialog.mov
303 KB View Download
Labels: -Pri-3 Proj-MacView MacViews-Dialogs Pri-2
Owner: ccameron@chromium.org
Status: Assigned (was: Untriaged)
Is this a compositing issue?
I see this happen for a split-second.

When I do this with MacViews enabled, hiding and then unhiding the modal dialogue causes it to become un-modal (it gets a title bar and all), which is really strange. I think something more broken is going on.
Cc: sdy@chromium.org
There is a TODO in BridgedNativeWidget::OnVisibilityChanged which I think is relevant to this:
  // TODO(tapted): Investigate whether we want this for Mac. This is what Aura                   
  // does, and it is what tests expect. However, because layer drawing is                        
  // asynchronous (and things like deminiaturize in AppKit are not), it can                      
  // result in a CALayer appearing on screen before it has been redrawn in the                   
  // GPU process.
Labels: Hotlist-DesktopUIValid Hotlist-DesktopUIChecked
***Mass UI Triage***
As per dev comments


Status: Fixed (was: Assigned)
This has been fixed.

Sign in to add a comment