New issue
Advanced search Search tips

Issue 835368 link

Starred by 3 users
Status: WontFix
Owner:
cjgrant@chromium.org
Closed: May 2018
Cc:
dougman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

2D UI - Keyboard freeze after using backspace

Project Member Reported by dougman@chromium.org, Apr 20 2018 
Chrome Version: 68.0.3400.0 Canary and on 67.0.3396.11 Dev
OS: Android 8.1.0 on Pixel 2

What steps will reproduce the problem?
(1) Open https://www.google.com
(2) Enter VR Browsing
(3) Click in the Google Search box to bring up the 2D UI keyboard.
(4) Type ggg
(5) Click the X button on the Google Search box to clear the text.
(6) Click the Backspace (delete) button on the 2D UI keyboard.
May need to repeat steps 3-6 a couple times to repro.

What is the expected result?
Backspace shouldn't do anything, keyboard should still be responsive.

What happens instead?
Backspace key and entire Keyboard is frozen.  Only clicking outside the keyboard and content pane, causing the keyboard to be dismissed fixes the problem.  Relaunching Keyboard and it works again.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e69907dfaa7f5293eff119fd6e6e5acccfa0411

commit 8e69907dfaa7f5293eff119fd6e6e5acccfa0411
Author: Yash Malik <ymalik@google.com>
Date: Mon Apr 23 15:40:50 2018

VR: Request text state correctly

https://chromium-review.googlesource.com/c/chromium/src/+/1012989 corrected the
case when we failed to request text state when the indices matched that of the
stale pending_text_state by clearing pending_text_state. As a result, we didn't
request the text state when the external forces (e.g. JS) cleared the text input
state, and consequently keyboard's knowledge of the text state and the actual
text state would be out of sync.

Bug:  835368 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I24d28af51e3508cf9fc861585fd6fa2f2256bf01
Reviewed-on: https://chromium-review.googlesource.com/1022612
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552707}
[modify] https://crrev.com/8e69907dfaa7f5293eff119fd6e6e5acccfa0411/chrome/browser/vr/content_input_delegate.cc
[modify] https://crrev.com/8e69907dfaa7f5293eff119fd6e6e5acccfa0411/chrome/browser/vr/content_input_delegate.h
[modify] https://crrev.com/8e69907dfaa7f5293eff119fd6e6e5acccfa0411/chrome/browser/vr/elements/content_element_unittest.cc

Comment 2 by tedc...@chromium.org, Apr 25 2018

Components: UI>Browser>VR
Owner: vollick@chromium.org
Status: Assigned (was: Untriaged)
@vollick - did Yash's CL address this?

Comment 3 by vollick@chromium.org, Apr 27 2018

Owner: cjgrant@chromium.org
Chris, could you PTAL to see if ymalik@ has got this fixed?

Comment 4 by cjgrant@chromium.org, Apr 30 2018 

Will do.

Comment 5 by dougman@chromium.org, Apr 30 2018 

Not to muddy the water here but this specific bug is fixed on build 68.0.3410.0
but is was suggested that this also fixed  bug 831187 .  I can't seem to repro 831187 on 67 builds now but they don't have this fix.

Comment 6 by cjgrant@chromium.org, May 9 2018

Cc: dougman@chromium.org
Status: WontFix (was: Assigned)
Sorry about the delay on this.  I'm not able to repro this on canary - I tried for a while, and things seem solid.  I'm going to close this off.  We can reopen if it's seen again.
►

Sign in to add a comment