New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 835349 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

[Wallpaper app] Preview wallpaper becomes black after rotating device

Project Member Reported by wzang@chromium.org, Apr 20 2018

Issue description

What steps will reproduce the problem?
(1) On tablet mode, select a wallpaper for preview.
(2) Verify it's shown as expected.
(3) Rotate the device, a black background is seen instead.



 
Project Member

Comment 1 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f63cbc3e1ef27826818187cb7dc982bbd7d686f

commit 9f63cbc3e1ef27826818187cb7dc982bbd7d686f
Author: Wenzhao Zang <wzang@chromium.org>
Date: Fri May 11 20:31:10 2018

cros: Fix preview wallpaper reloading issue

In |ReloadWallpaper|, the |current_wallpaper_| should be reset, however
if the current wallpaper is the preview wallpaper, it's not available
from |ShowUserWallpaper| yet because the preview wallpaper hasn't been
set for the user. So we need some other ways to retrieve the image.

Although we can remove the reset of |current_wallpaper_| for the
preview case, in that way we lose the ability to resize the preview
wallpaper based on the new display size (|current_wallpaper_| stores
the image after resizing, but we need the original image to go through
the resizing process again in order to show an accurate preview.)

So creating another callback should be a better solution.

Bug:  835349 
Change-Id: I6a76646eacb99dae26867303647206d316275950
Reviewed-on: https://chromium-review.googlesource.com/1052686
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558006}
[modify] https://crrev.com/9f63cbc3e1ef27826818187cb7dc982bbd7d686f/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/9f63cbc3e1ef27826818187cb7dc982bbd7d686f/ash/wallpaper/wallpaper_controller.h
[modify] https://crrev.com/9f63cbc3e1ef27826818187cb7dc982bbd7d686f/ash/wallpaper/wallpaper_controller_unittest.cc

Comment 2 by wzang@chromium.org, May 11 2018

Status: Fixed (was: Started)

Sign in to add a comment