New issue
Advanced search Search tips

Issue 835342 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug
Team-Accessibility

Blocking:
issue 828667



Sign in to add a comment

Update "File download is available" accessibility announcement.

Project Member Reported by eugene...@chromium.org, Apr 20 2018

Issue description

App Version (from "Chrome Settings > About Chrome"): M67
iOS Version: All
Device: All

Steps to reproduce: 
1.) Enable VoiceOver in Settings app
2.) Load https://www.barebones.com/products/bbedit/download.html
3.) Tap on Download
 
Observed behavior: 
"File download is available" accessibility announcement is played

Expected behavior: 
"File download is available. Options available near bottom of screen." accessibility announcement is played


 
Blocking: 828667
New text was recommended during accessibility review: crbug.com/828667
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6dbae0503928bef23e64344435de69acae74f5b2

commit 6dbae0503928bef23e64344435de69acae74f5b2
Author: Eugene But <eugenebut@google.com>
Date: Fri Apr 20 19:18:38 2018

Improve Download Available accessibility announcement.

Bug:  835342 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I1c5ae21731c6b5b339591f44926ad0a5769578ae
Reviewed-on: https://chromium-review.googlesource.com/1022182
Commit-Queue: Eugene But <eugenebut@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552425}
[modify] https://crrev.com/6dbae0503928bef23e64344435de69acae74f5b2/ios/chrome/app/strings/ios_strings.grd

Labels: Merge-Request-67
Project Member

Comment 5 by sheriffbot@chromium.org, Apr 20 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 38 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-67 Merge-Approved-67
Approved. Please verify after it lands to 67.
Status: Fixed (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 23 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11306f3eb954695e07aa92e44e1acc9f744fce08

commit 11306f3eb954695e07aa92e44e1acc9f744fce08
Author: Eugene But <eugenebut@google.com>
Date: Mon Apr 23 19:51:47 2018

Improve Download Available accessibility announcement.

TBR=eugenebut@google.com

(cherry picked from commit 6dbae0503928bef23e64344435de69acae74f5b2)

Bug:  835342 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I1c5ae21731c6b5b339591f44926ad0a5769578ae
Reviewed-on: https://chromium-review.googlesource.com/1022182
Commit-Queue: Eugene But <eugenebut@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#552425}
Reviewed-on: https://chromium-review.googlesource.com/1024764
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#232}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/11306f3eb954695e07aa92e44e1acc9f744fce08/ios/chrome/app/strings/ios_strings.grd

Status: Assigned (was: Fixed)
Issue reopen 
Version: Chrome Canary  68.0.3405.0
Device: iPhone 6, 5S
iOS: 10.3.3, 11.2.6

Re-opening this issue because the new full message "File download is available. Options available near bottom of screen." it is not played completely. 

Scenario 1  Regular network (Google Gest)
Full message is not played completely. Before the new message finishes to be played, VoiceOver goes back to the % bar to the page/file that is been loaded.  

Scenario 2 network impairment (GIN-2g)
1.  After clicking "Download" VoiceOver in % bar is played
2. Some time passes and the new message starts playing but gets truncated. 

See below
GIN-2g
https://drive.google.com/open?id=1IikO4O8uXF7MUEvwEk5NChWSNO34yoCr

Normal 
https://drive.google.com/open?id=1-rqB4n-8dlsK1usfGBDSzHFieRWiYjcR
Status: Fixed (was: Assigned)
This bug is about changing accessibility announcement text, and the text was changed. Please file new bugs if there are specific cases where the message gets truncated. From comment #9 it looks like navigation progress receives the focus.
Status: Assigned (was: Fixed)
@eugene:

1. As per feature https://crbug/821188, When New download manager UI shows up, it should speak the following text:

- "File download is available"

2. Bug filed for message gets truncated https://crbug/834285 - closed as WAI

3. According to this CL, expected behaviour is:
"File download is available. Options available near bottom of screen."

All these #3 cases looks contradictory. Could you please clarify the expected behaviour.

Thanks!
Status: Fixed (was: Assigned)
I closed http://crbug/834285, because from the video it looked like the user has interacted with the page, which cuts accessibility announcement (and that WAI).

After looking both videos again, it appears that accessibility announcement was cut by the progress bar. So I asked to file a separate bug, but it's fine to just reopen http://crbug/834285 (I reopened).

This specific bug is about updating accessibility announcement text. And the text was updated. If the announcement is cut, it's a separate bug. Sorry for the confusion.

Sign in to add a comment