New issue
Advanced search Search tips

Issue 835339 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Extension Click-to-Script: Migrate FeatureSwitch to base::Feature

Project Member Reported by rdevlin....@chromium.org, Apr 20 2018

Issue description

base::Features are more flexible than FeatureSwitches are now.  We should migrate it over.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cac45cb49db974e900021afadf47484ef0871078

commit cac45cb49db974e900021afadf47484ef0871078
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Wed Apr 25 04:43:03 2018

[Extensions] Migrate FeatureSwitch::scripts_require_action to base::Feature

Migrate the FeatureSwitch::scripts_require_action feature to a
base::Feature.  base::Features are a little more flexible than
FeatureSwitch is now, since they are set up for finch experimentation
and are always sent to the renderer (avoiding a commandline hack in
place for the FeatureSwitch approach).

Also rename scripts_require_action to kRuntimeHostPermissions. This is
a little more descriptive, since the feature affects host permissions
beyond just scripting (e.g., cookies and webRequest).

Bug:  835339 
Change-Id: I8b2a5c46a194655a811766114d8115da967719c0
Reviewed-on: https://chromium-review.googlesource.com/1022082
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553448}
[modify] https://crrev.com/cac45cb49db974e900021afadf47484ef0871078/chrome/browser/about_flags.cc
[modify] https://crrev.com/cac45cb49db974e900021afadf47484ef0871078/chrome/browser/extensions/active_tab_permission_granter.cc
[modify] https://crrev.com/cac45cb49db974e900021afadf47484ef0871078/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc
[modify] https://crrev.com/cac45cb49db974e900021afadf47484ef0871078/chrome/browser/extensions/api/developer_private/extension_info_generator.cc
[modify] https://crrev.com/cac45cb49db974e900021afadf47484ef0871078/chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc
[modify] https://crrev.com/cac45cb49db974e900021afadf47484ef0871078/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/cac45cb49db974e900021afadf47484ef0871078/chrome/browser/extensions/extension_action_runner_browsertest.cc
[modify] https://crrev.com/cac45cb49db974e900021afadf47484ef0871078/chrome/browser/extensions/extension_action_runner_unittest.cc
[modify] https://crrev.com/cac45cb49db974e900021afadf47484ef0871078/chrome/browser/extensions/extension_context_menu_model_unittest.cc
[modify] https://crrev.com/cac45cb49db974e900021afadf47484ef0871078/chrome/browser/extensions/extension_install_prompt_unittest.cc
[modify] https://crrev.com/cac45cb49db974e900021afadf47484ef0871078/chrome/browser/extensions/permissions_updater_unittest.cc
[modify] https://crrev.com/cac45cb49db974e900021afadf47484ef0871078/chrome/browser/extensions/scripting_permissions_modifier.cc
[modify] https://crrev.com/cac45cb49db974e900021afadf47484ef0871078/chrome/browser/extensions/scripting_permissions_modifier.h
[modify] https://crrev.com/cac45cb49db974e900021afadf47484ef0871078/chrome/browser/extensions/scripting_permissions_modifier_unittest.cc
[modify] https://crrev.com/cac45cb49db974e900021afadf47484ef0871078/extensions/common/extension_features.cc
[modify] https://crrev.com/cac45cb49db974e900021afadf47484ef0871078/extensions/common/extension_features.h
[modify] https://crrev.com/cac45cb49db974e900021afadf47484ef0871078/extensions/common/feature_switch.cc
[modify] https://crrev.com/cac45cb49db974e900021afadf47484ef0871078/extensions/common/feature_switch.h
[modify] https://crrev.com/cac45cb49db974e900021afadf47484ef0871078/extensions/common/switches.cc
[modify] https://crrev.com/cac45cb49db974e900021afadf47484ef0871078/extensions/common/switches.h
[modify] https://crrev.com/cac45cb49db974e900021afadf47484ef0871078/tools/metrics/histograms/enums.xml

Status: Fixed (was: Started)

Sign in to add a comment