New issue
Advanced search Search tips

Issue 835333 link

Starred by 2 users
Status: Fixed
Owner:
tbansal@chromium.org
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 826950



Sign in to add a comment

Add web platform tests for network quality client hints attributes

Project Member Reported by tbansal@chromium.org, Apr 20 2018 
Three new client hints "rtt", "downlink", "ect" have been added to the existing set of client hints.

These three client hints should expose the same information as the corresponding JavaScript NetInfo API.

There are existing tests for NetInfo JavaScript API (https://wpt.fyi/netinfo)  as well as client hints (https://wpt.fyi/client-hints). 

This bug tracks the work to these rtt, downlink and ect client hint attributes to the existing client hints test suite.
Project Member

Comment 1 by bugdroid1@chromium.org, May 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0c4f3f076b13aa37f16bb9b825d63ed3be0f224

commit a0c4f3f076b13aa37f16bb9b825d63ed3be0f224
Author: Tarun Bansal <tbansal@chromium.org>
Date: Mon May 07 19:47:51 2018

Add web platform tests for the new client hints

Add tests for "rtt", "downlink" and "ect".

Bug:  835333 
Change-Id: If54c01612f10e96f7b37868e19b01a7ff3266d43
Reviewed-on: https://chromium-review.googlesource.com/1045917
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556532}
[modify] https://crrev.com/a0c4f3f076b13aa37f16bb9b825d63ed3be0f224/third_party/WebKit/LayoutTests/external/wpt/client-hints/accept_ch.http.html
[modify] https://crrev.com/a0c4f3f076b13aa37f16bb9b825d63ed3be0f224/third_party/WebKit/LayoutTests/external/wpt/client-hints/accept_ch.http.html.headers
[modify] https://crrev.com/a0c4f3f076b13aa37f16bb9b825d63ed3be0f224/third_party/WebKit/LayoutTests/external/wpt/client-hints/accept_ch.sub.https.html
[modify] https://crrev.com/a0c4f3f076b13aa37f16bb9b825d63ed3be0f224/third_party/WebKit/LayoutTests/external/wpt/client-hints/accept_ch.sub.https.html.headers
[modify] https://crrev.com/a0c4f3f076b13aa37f16bb9b825d63ed3be0f224/third_party/WebKit/LayoutTests/external/wpt/client-hints/accept_ch_malformed_header.https.html
[modify] https://crrev.com/a0c4f3f076b13aa37f16bb9b825d63ed3be0f224/third_party/WebKit/LayoutTests/external/wpt/client-hints/echo_client_hints_received.py

Comment 2 by tbansal@chromium.org, May 17 2018

Status: Fixed (was: Started)

Comment 3 by tbansal@chromium.org, May 17 2018

Status: Started (was: Fixed)
Project Member

Comment 4 by bugdroid1@chromium.org, May 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c33a4329966daf6f811fec492c15525a38f4da20

commit c33a4329966daf6f811fec492c15525a38f4da20
Author: Tarun Bansal <tbansal@chromium.org>
Date: Fri May 18 03:57:39 2018

Add more tests for Netinfo client hints

The new tests are very similar to existing tests in
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/external/wpt/netinfo/netinfo-basics.html

The new tests verify that the value of client hint headers is
within the acceptable range.

Bug:  835333 
Change-Id: I4d7780c898ac9be93c7c3e88122ebc3557164618
Reviewed-on: https://chromium-review.googlesource.com/1065025
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559794}
[modify] https://crrev.com/c33a4329966daf6f811fec492c15525a38f4da20/third_party/WebKit/LayoutTests/external/wpt/client-hints/accept_ch.sub.https.html
[modify] https://crrev.com/c33a4329966daf6f811fec492c15525a38f4da20/third_party/WebKit/LayoutTests/external/wpt/client-hints/echo_client_hints_received.py

Comment 5 by tbansal@chromium.org, May 18 2018

Status: Fixed (was: Started)
►

Sign in to add a comment