New issue
Advanced search Search tips

Issue 835294 link

Starred by 4 users
Status: Started
Owner:
pkotw...@chromium.org
Cc:
pkotw...@chromium.org
jinsuk...@chromium.org
mdjones@chromium.org
tiborg@chromium.org
huayinz@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 837493


Sign in to add a comment

TabBrowserControlsOffsetHelper#showAndroidControls(animate = true) should do nothing if showing the android controls is not allowed

Project Member Reported by pkotw...@chromium.org, Apr 20 2018 
TabBrowserControlsOffsetHelper#showAndroidControls(animate = true) should do nothing if showing the android controls is not allowed

This would make the behavior of TabBrowserControlsOffsetHelper#showAndroidControls(animate = true)
consistent with the behavior of TabBrowserControlsOffsetHelper#showAndroidControls(animate = false)

Comment 1 by mdjones@chromium.org, Apr 20 2018

Cc: huayinz@chromium.org mdjones@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/796b64693b41559d19df278c68cb6c3c64a76353

commit 796b64693b41559d19df278c68cb6c3c64a76353
Author: Peter Kotwicz <pkotwicz@chromium.org>
Date: Thu Apr 26 04:46:02 2018

[Android Refactor]: Use ChromeActivity in BasicNativePage constructor

The android.app.Activity passed to the BasicNativePage constructor is always a
ChromeActivity. This CL changes the type of the parameter to the
BasicNativePage constructor to ChromeActivity. This enables removing an
always-true "instanceof ChromeActivity" if() statement.

BUG=835294

Change-Id: I7e63c26ae1d1eb53aa7e5be71174310320c6b471
Reviewed-on: https://chromium-review.googlesource.com/1021993
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553918}
[modify] https://crrev.com/796b64693b41559d19df278c68cb6c3c64a76353/chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedNewTabPage.java
[modify] https://crrev.com/796b64693b41559d19df278c68cb6c3c64a76353/chrome/android/java/src/org/chromium/chrome/browser/BasicNativePage.java
[modify] https://crrev.com/796b64693b41559d19df278c68cb6c3c64a76353/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPage.java
[modify] https://crrev.com/796b64693b41559d19df278c68cb6c3c64a76353/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadPage.java
[modify] https://crrev.com/796b64693b41559d19df278c68cb6c3c64a76353/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryPage.java
[modify] https://crrev.com/796b64693b41559d19df278c68cb6c3c64a76353/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java
[modify] https://crrev.com/796b64693b41559d19df278c68cb6c3c64a76353/chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java
[modify] https://crrev.com/796b64693b41559d19df278c68cb6c3c64a76353/chrome/android/junit/src/org/chromium/chrome/browser/ntp/NativePageFactoryTest.java

Comment 3 by pkotw...@chromium.org, Apr 27 2018

Blockedon: 837493

Comment 4 by pkotw...@chromium.org, Apr 27 2018

Cc: pkotw...@chromium.org tiborg@chromium.org jinsuk...@chromium.org
 Issue 837493  has been merged into this issue.
►

Sign in to add a comment