Issue metadata
Sign in to add a comment
|
Chrome app UI is completely broken when rotating the device while new tab animation is in progress. |
||||||||||||||||||||||
Issue descriptionApp Version: 67.0.3396.12 beta iOS Version: 11.2.6, 11.4, 10.3.3 Device: iPhone8, iPhoneX, iPhone7Plus URL: na Steps to reproduce: 1. Launch Google Chrome 2. Tap Menu → NewTab 3. While the new tab animation is in progress, quickly rotate the device Observed results: UI is completely broken. Expected results: UI should be displayed correctly. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): M66 NO (Animation is slightly glitchy but not entirely broken. App UI is adjusted correctly after rotation completed.) Bug reproducible on the current beta channel build (App Version, iOS Version): M67 YES Link to video/image: https://drive.google.com/file/d/1obgAK-BbwMK9pQo-_9mPB6IewW62-caz/view
,
Apr 20 2018
Only 8 CLs in ios/ in that range. Very much likely caused by this one: 687567cfbdd4c129191bae29f56e31fd3f364349 Always use _contentArea as superview for Tab's view. https://chromium-review.googlesource.com/c/chromium/src/+/985150
,
Apr 20 2018
,
Apr 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f0a4eff09a28ed09160660b62f13ca06b944cf1 commit 0f0a4eff09a28ed09160660b62f13ca06b944cf1 Author: Eugene But <eugenebut@google.com> Date: Mon Apr 23 15:58:52 2018 Fix NTP frame restoration after opening animation. BVC's content area is temporary resized during New Tab opening animation. This cl fixes frame restoration code, which now simply subtracts status bar from the frame. The old code retained the original frame and restored it on animation completion (which did not work on orientation change). Bug: 835291 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ifae9879587bf688985addfe8e95408157c54aa58 Reviewed-on: https://chromium-review.googlesource.com/1022735 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#552713} [modify] https://crrev.com/0f0a4eff09a28ed09160660b62f13ca06b944cf1/ios/chrome/browser/ui/browser_view_controller.mm
,
Apr 23 2018
,
Apr 24 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa14cf841f317d540b7a372ee11f6bb5fde23cc8 commit aa14cf841f317d540b7a372ee11f6bb5fde23cc8 Author: Eugene But <eugenebut@google.com> Date: Tue Apr 24 20:20:58 2018 Fix NTP frame restoration after opening animation. BVC's content area is temporary resized during New Tab opening animation. This cl fixes frame restoration code, which now simply subtracts status bar from the frame. The old code retained the original frame and restored it on animation completion (which did not work on orientation change). TBR=eugenebut@google.com (cherry picked from commit 0f0a4eff09a28ed09160660b62f13ca06b944cf1) Bug: 835291 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ifae9879587bf688985addfe8e95408157c54aa58 Reviewed-on: https://chromium-review.googlesource.com/1022735 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#552713} Reviewed-on: https://chromium-review.googlesource.com/1026516 Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#262} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/aa14cf841f317d540b7a372ee11f6bb5fde23cc8/ios/chrome/browser/ui/browser_view_controller.mm
,
Apr 30 2018
Verified in M68.0.3415.0 canary iOS: 11.4, iPhone6S
,
May 2 2018
Verified the issue on 67.0.3396.29 beta tested on iPhone 7+(iOS 11). NTP UI is displayed correctly |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by srikanthg@chromium.org
, Apr 20 2018