New issue
Advanced search Search tips

Issue 835281 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

The AEC3 delay estimator is slow to detect low level echoes in noisy environments

Project Member Reported by peah@chromium.org, Apr 20 2018

Issue description

In environments where there is a lot of noise, the AEC3 delay estimator
sometimes take a lot of time to detect the delay, in particular if the echo level is low.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/b04e5cae08b8a7bc27041c1606547f807aaa2fc1

commit b04e5cae08b8a7bc27041c1606547f807aaa2fc1
Author: Per Åhgren <peah@webrtc.org>
Date: Tue Apr 24 00:53:33 2018

Making the delay estimator more robust to noisy nearends and low echoes

This CL reduces the delay estimator step size to make it react better in
scenarios where the environment is noisy, or the echo level is fairly
low.

Bug:  webrtc:9177 , chromium:835281 
Change-Id: I482d898c91eddc497e1284ee500d26df21a0574a
Reviewed-on: https://webrtc-review.googlesource.com/71486
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22990}
[modify] https://crrev.com/b04e5cae08b8a7bc27041c1606547f807aaa2fc1/modules/audio_processing/aec3/matched_filter.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfa66268eeaa0979efb333e036a3f9d56eacb252

commit dfa66268eeaa0979efb333e036a3f9d56eacb252
Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Apr 24 05:47:20 2018

Roll src/third_party/webrtc/ e987f2b76..b04e5cae0 (1 commit)

https://webrtc.googlesource.com/src.git/+log/e987f2b76567..b04e5cae08b8

$ git log e987f2b76..b04e5cae0 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG= chromium:835281 


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ibeab77c208c3cd82d21d932a61ae55fc97ea7c4d
Reviewed-on: https://chromium-review.googlesource.com/1025397
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553010}
[modify] https://crrev.com/dfa66268eeaa0979efb333e036a3f9d56eacb252/DEPS

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/280a31fc30e9362a2666e65f2ca05cd9d5da6173

commit 280a31fc30e9362a2666e65f2ca05cd9d5da6173
Author: Per Åhgren <peah@webrtc.org>
Date: Thu Apr 26 16:32:07 2018

Revert "Making the delay estimator more robust to noisy nearends and low echoes"

This reverts commit b04e5cae08b8a7bc27041c1606547f807aaa2fc1.

Reason for revert: The reason for the revert is that some scenarios were detected where this caused the delay estimation to occur too slowly.

Original change's description:
> Making the delay estimator more robust to noisy nearends and low echoes
> 
> This CL reduces the delay estimator step size to make it react better in
> scenarios where the environment is noisy, or the echo level is fairly
> low.
> 
> Bug:  webrtc:9177 , chromium:835281 
> Change-Id: I482d898c91eddc497e1284ee500d26df21a0574a
> Reviewed-on: https://webrtc-review.googlesource.com/71486
> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
> Commit-Queue: Per Åhgren <peah@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#22990}

TBR=gustaf@webrtc.org,peah@webrtc.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  webrtc:9177 ,  chromium:835281 
Change-Id: I33e09ebfed8ad8330419e554f482c956608befce
Reviewed-on: https://webrtc-review.googlesource.com/72843
Reviewed-by: Per Åhgren <peah@webrtc.org>
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23042}
[modify] https://crrev.com/280a31fc30e9362a2666e65f2ca05cd9d5da6173/modules/audio_processing/aec3/matched_filter.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bb157b379b5695efd06b22d78746195a7d16630

commit 5bb157b379b5695efd06b22d78746195a7d16630
Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Apr 27 00:59:53 2018

Roll src/third_party/webrtc/ 775d07e27..e782abab1 (13 commits)

https://webrtc.googlesource.com/src.git/+log/775d07e27769..e782abab190e

$ git log 775d07e27..e782abab1 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG= chromium:835281 ,chromium:None,chromium:none,chromium:833801,chromium:None,chromium:836344


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I13862900de88f1441e209ddca59dd0a2984d7810
Reviewed-on: https://chromium-review.googlesource.com/1031110
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#554243}
[modify] https://crrev.com/5bb157b379b5695efd06b22d78746195a7d16630/DEPS

Comment 5 by pkl@chromium.org, Apr 30 2018

Components: Infra>Client>WebRTC
Is this finished?
Components: -Infra>Client>WebRTC Blink>WebRTC>Audio

Comment 8 by peah@chromium.org, Jun 14 2018

Status: WontFix (was: Assigned)

Sign in to add a comment