New issue
Advanced search Search tips

Issue 835270 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

The AEC3 handling of saturated echoes is overly conservative

Project Member Reported by peah@chromium.org, Apr 20 2018

Issue description

AEC3 includes code for handling the case when the echoes are saturated. That code is, however, fairly defensive and quite conservative regarding the echo behavior during saturated echoes. The effect of this is reduced echo canceller transparency.
 

Comment 1 by peah@chromium.org, Apr 20 2018

This issue was fixed by the WebRTC CL https://webrtc-review.googlesource.com/67220 and the work was covered in the WebRTC issue https://bugs.chromium.org/p/webrtc/issues/detail?id=9119.



 

Comment 2 by peah@chromium.org, Apr 20 2018

Labels: Merge-Request-67
I would like to merge this to M67 since it was not included in the rolled version of WebRTC that went into M67.

The code has been active in canary for 10 days and performs well.
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 21 2018

Labels: -Merge-Request-67 Merge-Approved-67 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by gov...@chromium.org, Apr 21 2018

Pls merge your change to M67 branch 3396 by 1:00 PM PT, Monday (04/23) so we can pick it up next M67 Dev/Beta release. Thank you.

Comment 5 by peah@chromium.org, Apr 23 2018

Labels: Merge-Merged
Status: Fixed (was: Assigned)
Thanks! The CL has now been merged to M67.

Comment 6 by gov...@chromium.org, Apr 23 2018

Pls point the CL link here for M67 merge here. Thank you.

Comment 7 by peah@google.com, Apr 23 2018

The WebRTC merge was done on the CL: https://webrtc-review.googlesource.com/c/src/+/71742

A link to this issue was included in the CL description.

Comment 8 by gov...@chromium.org, Apr 23 2018

Labels: -Merge-Merged -Merge-Approved-67 merge-merged-67
Removing "Merge-Approved-67" per comments #5 and #7. Thank you.
[bulk-edit: disregard if N/A] Can the owner please set milestone to this bug if applicable?

Comment 10 by peah@chromium.org, Jun 8 2018

Labels: M-67

Sign in to add a comment