New issue
Advanced search Search tips

Issue 835223 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Cross in Full Screen Mode when the pointer is at the top of the screen

Reported by 91bapti...@gmail.com, Apr 20 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.10 Safari/537.36

Steps to reproduce the problem:
1. Start an online video (ex : youtube)
2. Active the Full Screen Mode
3. Put the Pointer at the Top of the Screen
4. There is now a cross in the middle of the screen who won't disappear unless we go down the pointer

What is the expected behavior?
Before, when we launched a video in full screen, there was a message ("Press Esc to exit the full screen mode") that remained 3 seconds, at the place where there is now the cross.
I could put my mouse at the top of the screen, the message did not appear.

The thing is that in some video players, I can only put my mouse at the top right of the screen, because:
  1. If my mouse is down, the progress bar on the bottom does not go away
  2. If I leave my mouse in the middle of the screen, the pointer remains visible
  3. If I put it on the left side of the screen, it's still visible
  4. If I put it in the center, but on the right side, it often remains slightly visible
  5. However, if I put it on the top right, it disappears completely

And finally, it's a habit that I took and psychologically, I can not focus on the video if my pointer is not on the top right, even on players like youtube where the first four points are not not a problem.

!! You can see the expected behavior in the normal version of Google Chrome or in previous builds of Google Chrome Dev.

What went wrong?
Now, even if there is still the message ("Press Esc...") who remains for 3 seconds when we launch the full screen mode, there is also a CROSS IN THE MIDDLE OF THE SCREEN which won't disappear if my mouse is at the top of the screen.

For the reasons listed in the previous question, it is really annoying and irritating.

Did this work before? Yes Version 67.0.3393.4 (Build officiel) dev (64 bits)

Chrome version: 67.0.3396.10  Channel: dev
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: 

Please, remove this cross which doesn't has any utillity except for ruin my pleasure when watching videos.

Thank you for your reply

Best regards,

Baptiste GERMAIN
 
Cross in the screen.png
900 KB View Download
Hello,

Actually, I just noticed it isn't only with videos the cross appears, it also appears when we we are in the Full Screen Mode of the Browser (press F11 or click on the three points at top right of the browser, then click on the square in the Zoom section).

Please, remove this feature, it is useless and especially annoying.

Thank you for your reply,

Best regards,

Baptiste GERMAIN
Labels: Needs-Bisect Needs-Triage-M67
Components: UI
Labels: Triaged-ET Needs-Feedback
Unable to reproduce the issue on chrome reported version 67.0.3396.10 on windows-7 with steps mentioned below:
1) Launched chrome version, played a youtube video and clicked on Full Screen Mode
2) Put the Pointer at the Top of the Screen, didn't observed any 'cross' in the middle of the screen
Observations: Also tested the issue by using F11, didn't observed any cross on the screen

@Reporter: Please find the attached screencast for your reference and let us know if we missed anything in reproducing the issue, try to test this issue by creating new person with no apps and extensions in it, provide your feedback on it which help in further triaging it in better way.

Thanks!

835223.mp4
5.3 MB View Download
Hello,

I watched your video and I'm not sure why it does not work on your PC. It does it on 2 different PCs, one on Windows 7 (Work PC) and one on Windows 10 (Personal PC).
Is it well Chrome Dev that you used and not normal one ?

I made a quick video to show you my problem.

Thank you for your reply

Best regards,

Baptiste GERMAIN
Cross on Chrome Dev.mp4
4.4 MB View Download
Project Member

Comment 5 by sheriffbot@chromium.org, Apr 23 2018

Cc: viswa.karala@chromium.org
Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Hello,

I posted my answer on bugs.chromium.org (with a video showing the bug)
while forgetting to create a blank profile, so I send you the video
again by mail.

I watched your video and I'm not sure why it does not work on your PC.
It does it on 2 different PCs, one on Windows 7 (Work PC) and one on
Windows 10 (Personal PC).
Is it well Chrome Dev that you used and not normal one ?

I made a quick video to show you my problem.

Thank you for your reply

Best regards,

Baptiste GERMAIN



2018-04-23 10:35 GMT+02:00 viswa.ka… via monorail <
monorail+v2.1886622140@chromium.org>:
I don't see the video I send you by mail, so I send you it again (sorry if I flood your mailbox, I promess it's the last one.
Cross on Chrome Dev.mp4
4.4 MB View Download
Components: -UI UI>Browser>FullScreen
Labels: -Pri-2 -Needs-Bisect Target-68 M-67 Target-67 FoundIn-67 RegressedIn-67 hasbisect FoundIn-68 OS-Linux Pri-1
Owner: yuweih@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on reported chrome version 67.0.3396.10 and chrome canary 68.0.3404.0 using Windows-10 & Ubuntu 14.04 on the chrome builds downloaded from URL: https://www.chromium.org/getting-involved/dev-channel but works fine on signed/unsigned build for the same version.
Note:
-> As mentioned in comment#0 by the reporter "Did this work before? Yes Version 67.0.3393.4 (Build officiel) dev (64 bits)", hence providing manual change log for 67.0.3393.4 and 67.0.3396.10 from Omahaproxy
-> Issue is not applicable to Mac
Bisect Info:
================
Good build: 67.0.3393.4
Bad build: 67.0.3396.10

Change Log: https://chromium.googlesource.com/chromium/src/+log/67.0.3393.0..67.0.3396.0?pretty=fuller&n=10000
Commit: https://chromium.googlesource.com/chromium/src/+/3378babd04f0cb3ee3ff5c40a7753fb6c912fcf5
Reviewed-on: https://chromium-review.googlesource.com/1010966

@Yuwei Huang: Please confirm the issue and help in re-assigning if it is not related to your change.

Thanks!
Hello,

It's great you could reproduce the problem. As for the solution, do I have
to do something specific like :

- Download again Chrome Dev from another source (if yes, which one) ?

- Copy the file
chrome/browser/ui/views/fullscreen_control/fullscreen_control_host.cc
<https://chromium.googlesource.com/chromium/src/+/3378babd04f0cb3ee3ff5c40a7753fb6c912fcf5/chrome/browser/ui/views/fullscreen_control/fullscreen_control_host.cc>
you spoke of, and do something with it (if yes, what) ?

- Just wait the next Build of Chrome Dev (if yes, when will be the release)
?

Thank you for your hard work (and sorry if my questions are stupid)

Best regards,

Baptiste GERMAIN

2018-04-24 8:48 GMT+02:00 viswa.ka… via monorail <
monorail+v2.1886622140@chromium.org>:
Cc: markchang@chromium.org hwi@chromium.org
This is a WAI change.

CCing markchang@ and hwi@ to see if there is anything actionable.
Ok, great ! I'll wait the good news :)

Thank you

Best regards,

Baptiste GERMAIN

2018-04-25 0:07 GMT+02:00 yuw… via monorail <
monorail+v2.2663053166@chromium.org>:
Labels: -M-67 ReleaseBlock-Stable M-68
Since this is a recent regression and also have a clear suspect. Please have a fix during M68 time frame.
Project Member

Comment 13 by bugdroid1@chromium.org, May 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/faa9754ca738373e93a1fd42c830d8e48232d127

commit faa9754ca738373e93a1fd42c830d8e48232d127
Author: Yuwei Huang <yuweih@chromium.org>
Date: Wed May 02 00:15:12 2018

[Fullscreen control] Add timeout for cursor triggered exit UI

Some users complain that the fullscreen exit UI (FAB X) doesn't go away
when they move their cursor to the top of the screen. This is a common
scenario where people play video or present slides and they just want
to keep their cursor on the top.

To fix this use case, this CL adds a 3s timeout to the exit UI. After
the UI times out, the user needs to move the cursor away from the
buffer area then move it back to the top to re-trigger the UI.

Bug:  835223 
Change-Id: I43a652d83ffb539a89f9a0bcb81987c62d439edf
Reviewed-on: https://chromium-review.googlesource.com/1033483
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555241}
[modify] https://crrev.com/faa9754ca738373e93a1fd42c830d8e48232d127/chrome/browser/ui/views/fullscreen_control/fullscreen_control_host.cc
[modify] https://crrev.com/faa9754ca738373e93a1fd42c830d8e48232d127/chrome/browser/ui/views/fullscreen_control/fullscreen_control_host.h
[modify] https://crrev.com/faa9754ca738373e93a1fd42c830d8e48232d127/chrome/browser/ui/views/fullscreen_control/fullscreen_control_popup.cc
[modify] https://crrev.com/faa9754ca738373e93a1fd42c830d8e48232d127/chrome/browser/ui/views/fullscreen_control/fullscreen_control_popup.h
[modify] https://crrev.com/faa9754ca738373e93a1fd42c830d8e48232d127/chrome/browser/ui/views/fullscreen_control/fullscreen_control_popup_unittest.cc
[modify] https://crrev.com/faa9754ca738373e93a1fd42c830d8e48232d127/chrome/browser/ui/views/fullscreen_control/fullscreen_control_view.cc
[modify] https://crrev.com/faa9754ca738373e93a1fd42c830d8e48232d127/chrome/browser/ui/views/fullscreen_control/fullscreen_control_view.h
[modify] https://crrev.com/faa9754ca738373e93a1fd42c830d8e48232d127/chrome/browser/ui/views/fullscreen_control/fullscreen_control_view_interactive_uitest.cc

Status: Fixed (was: Assigned)
The change got into Canary. The FAB will now go away if the button isn't clicked after ~3 seconds.
Sorry for taking time to answer.

The changes has indeed taken effect on my browser. Thank you very much

I just have one question, if I want the cross to never appear (even for 3 seconds), is it possible for me to implement it on my browser or not ?

Of course, I'm not complaiying, the change is already quite satisfing and you worked fast. It is just for my own utilisation and pleasure (since I absolutely won't use the cross and it isn't pleasureable to have even for a short time).

Well, if it isn't possible, so be it, I'll do with what I have.

Anyway, thank you very much for all you did.

Best regards,

Baptiste GERMAIN
Chrome Dev Version.png
34.8 KB View Download
The cross UI is generally targeting tablet or mouse-only devices so I guess it may be unnecessary if the user has a keyboard attached. I don't think we are going to make that change in M67 though..
Very well, the current configuration is still acceptable after all. It's just, what do you mean by M67 ? My version of Chrome Dev is 68.0.3423.2 and not 67.XX.XXXX.XX.

Still, thank you very much

Best regards,
Sorry, I meant M68..
Ok, I'll wait the M69 or the next one, then.

Good luck for your work.

Best regards,

Sign in to add a comment