New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 835204 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Remove redundant asserts, casts and public decorators in the Files app

Project Member Reported by sashab@chromium.org, Apr 20 2018

Issue description

As part of getting the closure compiler to work, we had to add some asserts and change some class visibilities to @public (see https://chromium-review.googlesource.com/c/chromium/src/+/1021000).

Remove these by fixing the closure compiler to have correct type annotations for functions, or keep them where appropriate. Also, fix function visibilities to be as narrowly-scoped as possible, and remove as many casts as possible.
 
Labels: Files-Fixit-2018

Sign in to add a comment