New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 835197 link

Starred by 2 users
Status: Fixed
Owner:
pbos@chromium.org
Closed: Apr 2018
Cc:
scroggo@chromium.org
ajha@chromium.org
pbos@chromium.org
abodenha@chromium.org
sdantul...@chromium.org
pucchakayala@chromium.org
█ reve...@chromium.org
mkarkada@chromium.org
█ brajkumar@chromium.org
dhadd...@chromium.org
songsuk@chromium.org
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Preview with weird glitches are seen in chrome://settings/changePicture page

Project Member Reported by rkalavakuntla@chromium.org, Apr 20 2018 
Chrome Version:68.0.3400.0/10599.0.0 dev channel Daisy,Candy,Reks
OS:Chrome OS

What steps will reproduce the problem?
(1)Sign into user >>Go to Chrome://settings/changePicture page
(2)Select any default picture preview like Fox,Snail,Elephant.. and Observe

Actual: Previews are seen with weird glitches 
Expected: No such weird preview should be seen

This is a Regression issue as same is working fine in 67.0.3396.12/10575.8.0 dev 

Note:
1.Issue is not seen in Linux,Windows OS
2.Able to reproduce the issue in Sign out screen preview also

@stevenjb: Please confirm the issue 

Attached the screencast for reference..
Actual.mp4
1.8 MB View Download
IMG_1.jpg
3.7 MB View Download
IMG_2.jpg
2.4 MB View Download
IMG_3.jpg
3.2 MB View Download

Comment 1 by steve...@chromium.org, Apr 20 2018

Cc: jdufault@chromium.org
Owner: reve...@chromium.org
I've seen this also. I suspect it is related to the animated png code as it is not specific to any of the UI.

reveman@ - thoughts?

Comment 2 by jdufault@chromium.org, Apr 20 2018 

I suspect a webkit issue, this happens in lock as well which goes through data_decoder::DecodeAnimation.

https://cs.chromium.org/chromium/src/ash/login/ui/image_parser.cc?q=image_parser.cc&dr&l=42-45

Comment 3 by reve...@chromium.org, Apr 20 2018

Cc: reve...@chromium.org
Components: Blink>Image
Owner: scroggo@chromium.org
Yes, looks like the APNG support is broken in ToT chrome. I get the same when I open the chrome://theme/ url in a browser window.

scroggo@, any ideas?

Comment 4 by schenney@chromium.org, Apr 23 2018

Components: -Blink>Image -UI>Settings Internals>Images>Codecs

Comment 5 by jdufault@chromium.org, Apr 23 2018

Cc: mkarkada@chromium.org abodenha@chromium.org dhadd...@chromium.org sdantul...@chromium.org
 Issue 835498  has been merged into this issue.

Comment 6 by scroggo@chromium.org, Apr 24 2018

Cc: scroggo@chromium.org
Owner: ----
Status: Available (was: Assigned)
A few of the APNGs look wrong, but others work fine for me:
-Bad:
  - fox
  - unicorn
  - snail
-Good:
  - penguin
  - cat
  - monkey
  - dragon
  - panda
  - falling pizza
  - sandwich
  - coffee
  - ice water
  - ice cream
  - avocado
  - watermelon

So it doesn't appear to be a general APNG issue. I haven't changed much in png lately, except for upgrading the version of libpng from 1.6.22 to 1.6.34 (along with some related changes). Reverting that did not fix the problem.

These same images (fox, unicorn, snail) all look the same (wrong) when I open them in FireFox.

I've attached a film strip view of the unicorn animation (anim.png). (Along with the image I saved from my mock-ChromeOS - unicorn.png.)

The first frame looks fine, but later frames have black rectangles where they intend to be showing updates. I think we're drawing transparent black when we should be drawing blending transparent black - i.e. not changing pixels. My first thought was that we (or the image) somehow mixed up the blend ops (kAPNG_BLEND_OP_SOURCE and kAPNG_BLEND_OP_OVER). If we were using kAPNG_BLEND_OP_SOURCE when we should have been using kAPNG_BLEND_OP_OVER, that would have the same effect. So I tried switching them, which did not help. (In fact, AFAICT, the two look identical - see anim-reverse.png.)

Are you sure these three images worked before? How were they created? It looks to me like the second frame used opaque black when it should have used transparent black. That would also explain the effect I'm seeing. Looking at the IHDR chunk, I see that the image is using color type (2) TrueColor (see https://www.w3.org/TR/PNG/#11IHDR) - meaning no alpha is present. So I suspect the second frame was supposed to have transparency (and the PNG that was originally created did), but since the APNG isn't using transparency, it just ends up black where the intent was to not update the image.
anim.png
1.5 MB View Download
unicorn.png
449 KB View Download
anim-reverse.png
1.5 MB View Download

Comment 7 by reve...@chromium.org, Apr 24 2018 

Yes, they used to work just fine. We should be able to do a bisect and find change caused it to break.

I used apngasm (http://apngasm.sourceforge.net/) on a linux machine to create these. default flags.

Comment 8 by reve...@chromium.org, Apr 25 2018

Cc: pbos@chromium.org

Comment 9 by pbos@chromium.org, Apr 25 2018

Owner: pbos@chromium.org
Status: Assigned (was: Available)
tools/resources/optimize-png-files.sh seemed to run haywire on these in crrev.com/c/1012263. As for why it didn't hit all apngs, maybe it doesn't do anything if it can't compress the keyframe?

I'm in the process of reverting, sorry. If anyone could, please follow up on this script to make sure it doesn't happen again that would be super useful. I'm not sure if an easy "if file is apng: skip" thing is feasible.

Comment 10 by scroggo@chromium.org, Apr 25 2018 

> If anyone could, please follow up on this script to make sure it doesn't happen
> again that would be super useful. I'm not sure if an easy "if file is apng:
> skip" thing is feasible.

Filed issue 836920. It looks like that script just runs pngcrush. At least the version I just installed on my desktop does not display an option that would seem to let you know that it's an APNG (and potentially abort).
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/391985f9a156d33ec3e596a62746aabbf29054d3

commit 391985f9a156d33ec3e596a62746aabbf29054d3
Author: Peter Boström <pbos@chromium.org>
Date: Wed Apr 25 23:44:13 2018

Revert "Run tools/resources/optimize-png-files.sh"

This reverts commit 30e23517aa38af154e23564a4d09410028d47c67.

Reason for revert: This script turned animated PNGs for ChromeOS into flat PNGs. Scary!

Original change's description:
> Run tools/resources/optimize-png-files.sh
>
> Optimizes a significant number of .png files and cuts ~3.6M in total.
>
> Bug: None
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I53a951a6410839c3b21f7155f22e2fedb3fb963f
> Reviewed-on: https://chromium-review.googlesource.com/1012263
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
> Commit-Queue: Peter Boström <pbos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551066}

TBR=sky@chromium.org,bauerb@chromium.org,pbos@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  chromium:835197 
Change-Id: I4852e2ee84ac51ffb765649ff838c03dfba564d3
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1028336
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553826}
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/ash/public/cpp/resources/unscaled_resources/settings_logo_192.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/ash/public/cpp/resources/unscaled_resources/shortcut_viewer_logo_192.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/add_circle_blue.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/audio_playing_square.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/badge_update_dark.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/badge_update_light.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/bg_tabstrip_background_tab.9.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/bg_tabstrip_incognito_background_tab.9.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/bg_tabstrip_incognito_tab.9.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/bg_tabstrip_tab.9.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/bookmark_edit_active.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/btn_new_tab_incognito_normal.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/btn_star_filled.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/btn_tabstrip_new_incognito_tab_normal.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/btn_tabstrip_new_incognito_tab_pressed.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/btn_tabstrip_new_tab_normal.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/chrome_sync_logo.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/contextual_search_promo_ripple.9.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/cvc_icon_amex.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/data_reduction_main_menu_chart.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/data_reduction_main_menu_chart_base.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/diners_card.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/down_arrow.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/exclamation_triangle.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/google_logo.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/google_play.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/ic_cast_dark_off.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/ic_chrome.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/ic_download_pending.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/ic_edit_24dp.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/ic_email_googblue_36dp.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/ic_fast_rewind_white_36dp.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/ic_help_and_feedback.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/ic_help_white_24dp.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/ic_link_grey600_36dp.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/ic_most_visited_placeholder.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/ic_omnibox_incognito_badge.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/ic_phone_googblue_36dp.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/ic_place_googblue_36dp.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/ic_play_arrow_white_36dp.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/ic_skip_next_white_36dp.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/ic_skip_previous_white_36dp.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/ic_volume_up_grey600_24dp.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/ic_warning_white_24dp.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/infobar_3d_blocked.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/infobar_chrome.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/infobar_screen_share.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/infobar_translate.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/infobar_translate_compact.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/modern_location_bar.9.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/omnibox_https_invalid.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/omnibox_https_valid.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/permission_background_sync.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/permission_mic.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/settings_cog.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/settings_media.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/shortcut_incognito.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/spinner.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/spinner_white.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/sync_error.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/tabswitcher_border_frame_decoration.9.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/tabswitcher_border_frame_inner_shadow.9.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-hdpi/webrtc_video.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-ldrtl-hdpi-v17/btn_tabstrip_new_tab_normal.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-ldrtl-hdpi-v17/btn_toolbar_reload.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-ldrtl-mdpi-v17/btn_toolbar_reload.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-ldrtl-sw600dp-tvdpi-v17/toolbar_background.9.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-ldrtl-xhdpi-v17/btn_suggestion_refine.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-ldrtl-xhdpi-v17/btn_tabstrip_new_incognito_tab_pressed.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-ldrtl-xhdpi-v17/btn_tabstrip_new_tab_pressed.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-ldrtl-xhdpi-v17/btn_toolbar_reload.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-ldrtl-xxhdpi-v17/btn_tabstrip_new_incognito_tab_normal.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-ldrtl-xxhdpi-v17/btn_tabstrip_new_tab_normal.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-ldrtl-xxhdpi-v17/btn_tabstrip_new_tab_pressed.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-ldrtl-xxhdpi-v17/btn_toolbar_reload.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-ldrtl-xxhdpi-v17/ic_omnibox_incognito_badge.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-ldrtl-xxhdpi-v17/ic_suggestion_magnifier.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-ldrtl-xxxhdpi-v17/btn_suggestion_refine.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-ldrtl-xxxhdpi-v17/btn_tabstrip_new_incognito_tab_normal.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-ldrtl-xxxhdpi-v17/btn_tabstrip_new_incognito_tab_pressed.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-ldrtl-xxxhdpi-v17/btn_tabstrip_new_tab_pressed.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-ldrtl-xxxhdpi-v17/btn_toolbar_reload.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/add_circle_blue.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/audio_playing_square.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/badge_update_dark.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/bg_tabstrip_background_tab.9.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/bg_tabstrip_incognito_background_tab.9.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/bg_tabstrip_incognito_tab.9.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/bg_tabstrip_tab.9.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/bookmark_edit_active.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/btn_star.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/btn_star_filled.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/btn_tabstrip_new_incognito_tab_pressed.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/btn_tabstrip_new_tab_pressed.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/btn_toolbar_reload.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/chrome_sync_logo.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/contextual_search_promo_ripple.9.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/data_reduction_illustration.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/data_reduction_main_menu_chart.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/data_reduction_main_menu_chart_base.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/diners_card.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/down_arrow.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/exclamation_triangle.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/google_logo.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/google_play.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/ic_account_child_grey600_36dp.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/ic_cast_dark_off.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/ic_cast_dark_on.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/ic_chrome.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/ic_download_pending.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/ic_edit_24dp.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/ic_email_googblue_36dp.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/ic_fast_forward_white_36dp.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/ic_fast_rewind_white_36dp.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/ic_help_white_24dp.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/ic_link_grey600_36dp.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/ic_phone_googblue_36dp.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/ic_place_googblue_36dp.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/ic_play_arrow_white_24dp.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/ic_suggestion_magnifier.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/ic_volume_up_grey600_24dp.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/ic_warning_white_24dp.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/incognito_splash.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/incognito_statusbar.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/infobar_3d_blocked.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/infobar_microphone.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/infobar_screen_share.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/infobar_translate.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/infobar_translate_compact.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/jcb_card.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/logo_card_back.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/menu_update.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/modern_location_bar.9.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/offline_pin.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/pageinfo_warning.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/permission_background_sync.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/settings_autoplay.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/settings_translate.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/shortcut_newtab.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/spinner.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/spinner_white.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/tab_strip_fade_for_model_selector.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/tabswitcher_border_frame_shadow.9.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-mdpi/verify_checkmark.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-nodpi/bookmark_widget_preview.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-nodpi/widget_preview.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-sw600dp-hdpi/google_logo.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-sw600dp-mdpi/google_logo.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-sw600dp-tvdpi/toolbar_background.9.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-sw600dp-xhdpi/google_logo.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-xhdpi/add_circle_blue.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-xhdpi/audio_playing_square.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-xhdpi/badge_update_dark.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-xhdpi/badge_update_light.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-xhdpi/bg_tabstrip_incognito_background_tab.9.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-xhdpi/bg_tabstrip_incognito_tab.9.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-xhdpi/bookmark_edit_active.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-xhdpi/btn_new_tab_white_normal.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-xhdpi/btn_star.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-xhdpi/btn_star_filled.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-xhdpi/btn_suggestion_refine.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-xhdpi/btn_tabstrip_new_incognito_tab_normal.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-xhdpi/btn_tabstrip_new_incognito_tab_pressed.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-xhdpi/btn_tabstrip_new_tab_normal.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-xhdpi/btn_toolbar_reload.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-xhdpi/cast_playing_square.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-xhdpi/chrome_sync_logo.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-xhdpi/contextual_search_promo_ripple.9.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-xhdpi/cvc_icon.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-xhdpi/data_reduction_main_menu_chart.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-xhdpi/data_reduction_main_menu_chart_base.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/chrome/android/java/res/drawable-xhdpi/diners_card.png
[modify] https://crrev.com/391985f9a156d33ec3e596a62746aabbf29054d3/ch

Comment 12 by pbos@chromium.org, Apr 26 2018

Status: Fixed (was: Assigned)
This should be resolved now, I don't have a ChromeOS device I can easily test on. Please re-open if there still are issues. Sorry about that!

Comment 13 by scroggo@chromium.org, Apr 30 2018 

FYI: You can easily build a ChromeOS shim by adding the following to your args.gn file:

target_os = "chromeos"

When you lauch "chrome" it opens a window that looks like ChromeOS.

Comment 14 by pbos@chromium.org, Apr 30 2018 

That's good to know. My primary workstation is a Windows machine (so I doubt that would work here?) but I could've set this up to build with my secondary laptop if the culprit wasn't fairly clear.. Thanks!
►

Sign in to add a comment