Issue metadata
Sign in to add a comment
|
Compile error for ver 66.0.3359.117 chromium on macos 10.13.4 content/browser/service_worker/service_worker_version.cc:57:7: error: declaration shadows a type alias in namespace 'content::(anonymous)' [-Werror,-Wshadow] using StatusCallback = ServiceWorkerVersion::StatusCallback;
Reported by
davec.b...@gmail.com,
Apr 20 2018
|
||||||||||||||||||||
Issue description
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.146 Safari/537.36
Steps to reproduce the problem:
1. Git pull chromium release 66.0.3359.117
2. compile
3.
What is the expected behavior?
66.0.3359.117 build
What went wrong?
FAILED: obj/content/browser/browser/browser_jumbo_13.o
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/content/browser/browser/browser_jumbo_13.o.d -DENABLE_SCREEN_CAPTURE=1 -DV8_DEPRECATION_WARNINGS -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DOFFICIAL_BUILD -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_XCODE_VERSION=0930 -DCR_CLANG_REVISION=\"325667-1\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DCONTENT_IMPLEMENTATION -DV8_USE_EXTERNAL_STARTUP_DATA -DWEBP_EXTERN=extern -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSK_SUPPORT_GPU=1 -DSK_BUILD_FOR_MAC -DLEVELDB_PLATFORM_CHROMIUM=1 -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0 -DGTEST_RELATIVE_PATH -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_MAC -DMESA_EGL_NO_X11_HEADERS -DXML_STATIC -DNO_MAIN_THREAD_WRAPPING -DFLAC__NO_DLL -I. -I../.. -Igen -I../../third_party/libwebp/src -I../../third_party/khronos -I../../gpu -I../../third_party/libyuv/include -I../../third_party/protobuf/src -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/encode -I../../third_party/skia/include/gpu -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -I../../third_party/libwebm/source -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/leveldatabase -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase/src/include -I../../third_party/webrtc_overrides -I../../testing/gtest/include -I../../third_party/webrtc -I../../third_party/webrtc_overrides -I../../third_party/webrtc -Igen/third_party/metrics_proto -I../../third_party/boringssl/src/include -I../../third_party/WebKit -Igen/third_party/WebKit -I../../v8/include -Igen/v8/include -I../../third_party/webrtc/common_video/include -I../../third_party/angle/src/common/third_party/base -Igen/angle -I../../third_party/brotli/include -I../../third_party/re2/src -I../../third_party/zlib -I../../third_party/mesa/src/include -I../../third_party/expat/files/lib -fno-strict-aliasing -fstack-protector -fcolor-diagnostics -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -no-canonical-prefixes -arch x86_64 -Wall -Werror -Wextra -Wimplicit-fallthrough -Wthread-safety -Wunguarded-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -Wno-null-pointer-arithmetic -O2 -fno-omit-frame-pointer -g0 -isysroot ../../../../../../../Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -mmacosx-version-min=10.9.0 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wexit-time-destructors -Wshadow -std=c++14 -stdlib=libc++ -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -c gen/content/browser/browser_jumbo_13.cc -o obj/content/browser/browser/browser_jumbo_13.o
In file included from gen/content/browser/browser_jumbo_13.cc:38:
./../../content/browser/service_worker/service_worker_version.cc:57:7: error: declaration shadows a type alias in namespace 'content::(anonymous)' [-Werror,-Wshadow]
using StatusCallback = ServiceWorkerVersion::StatusCallback;
^
./../../content/browser/service_worker/service_worker_handle.cc:22:7: note: previous declaration is here
using StatusCallback = base::OnceCallback<void(ServiceWorkerStatusCode)>;
^
1 error generated.
Did this work before? Yes 65.0.3325.146
Chrome version: 66.0.3359.117 Channel: stable
OS Version: OS X 10.13.4
Flash Version:
,
Apr 20 2018
Jumbo builds are "supported" on mac, lin and win by us who maintain it, but we only have testing and bots on master so this went unnoticed on the 66 branch and it might be too late to fix now. Yngve told me that jinho.bang fixed it on master and it would be fixed on the 66 branch by backporting https://chromium-review.googlesource.com/957568. Davec, will that solve your problem? @ellyjones, do you think it would be accepted/wort backporting it or is the cat out of the box?
,
Apr 20 2018
We *might* take that merge to M66 - it certainly seems low-risk - but at the same time M66 is already stable so perhaps not.
,
Apr 20 2018
Yes that solves my problem... I will apply that patch, thanks!
,
Apr 20 2018
After applying the patch from https://chromium-review.googlesource.com/957568, the build fails with the following: In file included from ./gen/mojo/public/interfaces/bindings/interface_control_messages.mojom.cc:15: gen/mojo/public/interfaces/bindings/interface_control_messages.mojom.h:18:10: fatal error: 'mojo/public/cpp/bindings/mojo_features.h' file not found #include "mojo/public/cpp/bindings/mojo_features.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated.
,
Apr 20 2018
davec, that is something else. My guess would be at a missing build dependency so things build in the wrong order if you are unlucky. A clean build or trying again, or figuring out what target should generate mojo_features.h and force compiling that might all work.
,
May 22 2018
Will not try to backport to 66 now so closing this as WontFix. Anyone needing the fix on a 66 based branch can backport the fix as mentioned above. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by ellyjo...@chromium.org
, Apr 20 2018Status: Assigned (was: Unconfirmed)