Disk Space Management and Cache Eviction: add UMAs |
|||
Issue descriptionAudit existing UMA metrics and add any additional metrics needed to analyze low disk scenarios and efficient cache management.
,
Apr 20 2018
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/279c0355ca7a0a2587a90ec228770e7404c6f0b9 commit 279c0355ca7a0a2587a90ec228770e7404c6f0b9 Author: Alexey Baskakov <loyso@chromium.org> Date: Tue Apr 24 13:22:34 2018 cryptohome: Adjust FreedGCacheDiskSpaceInMb metric. Currently it is called on a hourly basis and reports zero for 99% of hits, which is not very useful. Report a hit only if something was deleted. Also, adjust the minimum and maximum to contain the 99% percentile. BUG= chromium:835114 TEST=none Change-Id: I65e9e8c414a9c191b7c272e3290e1dc36b7cd775 Reviewed-on: https://chromium-review.googlesource.com/1025238 Commit-Ready: Alexey Baskakov <loyso@chromium.org> Tested-by: Alexey Baskakov <loyso@chromium.org> Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> [modify] https://crrev.com/279c0355ca7a0a2587a90ec228770e7404c6f0b9/cryptohome/cryptohome_metrics.cc [modify] https://crrev.com/279c0355ca7a0a2587a90ec228770e7404c6f0b9/cryptohome/homedirs.cc
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ecc3b70bf2b7ed45546eead45383e83d0a85aec7 commit ecc3b70bf2b7ed45546eead45383e83d0a85aec7 Author: Alexey Baskakov <loyso@chromium.org> Date: Fri Apr 27 04:44:27 2018 ChromiumOS histograms: Add Cryptohome.DeletedUserProfiles histogram. In low disk space scenarios, Cryptohome erases whole user profiles. We count the number of user profiles, deleted during cleanup. BUG= 835114 Change-Id: I8921a4d4c7c8e843c7408b8e1eb7d78b1e8d0785 Reviewed-on: https://chromium-review.googlesource.com/1029753 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#554306} [modify] https://crrev.com/ecc3b70bf2b7ed45546eead45383e83d0a85aec7/tools/metrics/histograms/histograms.xml
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/c07e07b511d8388d6780b2d428c44a104f33499c commit c07e07b511d8388d6780b2d428c44a104f33499c Author: Alexey Baskakov <loyso@chromium.org> Date: Fri Apr 27 16:30:01 2018 cryptohome: Add DeletedUserProfiles histogram. In low disk space scenarios, Cryptohome erases whole user profiles. Report number of deleted user profiles to the "Cryptohome.DeletedUserProfiles" histogram. Refactoring: Extract DeleteUserProfiles method. BUG= chromium:835114 TEST=none Change-Id: Ib9693e8ad6fde73556d8d822ceaedaa7c82401d2 Reviewed-on: https://chromium-review.googlesource.com/1029558 Commit-Ready: Alexey Baskakov <loyso@chromium.org> Tested-by: Alexey Baskakov <loyso@chromium.org> Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> [modify] https://crrev.com/c07e07b511d8388d6780b2d428c44a104f33499c/cryptohome/homedirs_unittest.cc [modify] https://crrev.com/c07e07b511d8388d6780b2d428c44a104f33499c/cryptohome/cryptohome_metrics.cc [modify] https://crrev.com/c07e07b511d8388d6780b2d428c44a104f33499c/cryptohome/cryptohome_metrics.h [modify] https://crrev.com/c07e07b511d8388d6780b2d428c44a104f33499c/cryptohome/homedirs.cc [modify] https://crrev.com/c07e07b511d8388d6780b2d428c44a104f33499c/cryptohome/homedirs.h
,
Apr 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/afa8bfeb1ad8a79157f12a1add56654e93d897c5 commit afa8bfeb1ad8a79157f12a1add56654e93d897c5 Author: Alexey Baskakov <loyso@chromium.org> Date: Mon Apr 30 02:03:52 2018 ChromiumOS histograms: Add Cryptohome.FreeDiskSpaceTotalTime histogram. In low disk space scenarios, Cryptohome performs a lot of disk space operations to erase data. This is a number of milliseconds taken to perform a cleanup. Reported only if longer than 5 ms. BUG= 835114 Change-Id: I7af2fe673dd01581fa0442a1e26bf08dc2a7f315 Reviewed-on: https://chromium-review.googlesource.com/1032210 Reviewed-by: Alexey Baskakov <loyso@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#554687} [modify] https://crrev.com/afa8bfeb1ad8a79157f12a1add56654e93d897c5/tools/metrics/histograms/histograms.xml
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e877df4cf60ce8caceae4b9bc95ab39cf2d066ee commit e877df4cf60ce8caceae4b9bc95ab39cf2d066ee Author: Alexey Baskakov <loyso@chromium.org> Date: Tue May 01 04:43:06 2018 cros: Mark Cryptohome.FreedGCacheDiskSpaceInMb histogram obsolete In low disk space scenarios, Cryptohome erases encrypted Google Drive cache. Cryptohome.FreedGCacheDiskSpaceInMb reported zero in 99% of hits, which was not informative. Deprecated 05/2018 in favor of Cryptohome.GCache.FreedDiskSpaceInMb. platform2 part: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1034426 BUG= 835114 Change-Id: Ia48ad5ad1a7845e23997c26b6b1480548c1fb58c Reviewed-on: https://chromium-review.googlesource.com/1034423 Reviewed-by: Mark Pearson <mpearson@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#554995} [modify] https://crrev.com/e877df4cf60ce8caceae4b9bc95ab39cf2d066ee/tools/metrics/histograms/histograms.xml
,
May 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/d83fb72923d956e0df0b8816f02fbda958873cde commit d83fb72923d956e0df0b8816f02fbda958873cde Author: Alexey Baskakov <loyso@chromium.org> Date: Mon May 07 03:39:22 2018 cryptohome: Add FreeDiskSpaceTotalTime histogram. In low disk space scenarios, Cryptohome performs a lot of disk operations. Report total time taken by HomeDirs::FreeDiskSpace cleanup (in milliseconds) BUG= chromium:835114 TEST=none Change-Id: Ie1411b90b5dfcce1d9e2504010be9d266b2c50c8 Reviewed-on: https://chromium-review.googlesource.com/1034421 Commit-Ready: Alexey Baskakov <loyso@chromium.org> Tested-by: Alexey Baskakov <loyso@chromium.org> Reviewed-by: Andrey Pronin <apronin@chromium.org> [modify] https://crrev.com/d83fb72923d956e0df0b8816f02fbda958873cde/cryptohome/mock_homedirs.h [modify] https://crrev.com/d83fb72923d956e0df0b8816f02fbda958873cde/cryptohome/homedirs.h [modify] https://crrev.com/d83fb72923d956e0df0b8816f02fbda958873cde/cryptohome/cryptohome_metrics.cc [modify] https://crrev.com/d83fb72923d956e0df0b8816f02fbda958873cde/cryptohome/cryptohome_metrics.h [modify] https://crrev.com/d83fb72923d956e0df0b8816f02fbda958873cde/cryptohome/service_unittest.cc [modify] https://crrev.com/d83fb72923d956e0df0b8816f02fbda958873cde/cryptohome/homedirs_unittest.cc [modify] https://crrev.com/d83fb72923d956e0df0b8816f02fbda958873cde/cryptohome/mount_task.cc [modify] https://crrev.com/d83fb72923d956e0df0b8816f02fbda958873cde/cryptohome/homedirs.cc
,
May 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/3918d58074f6e7347f4691a8e5df175cecce74e9 commit 3918d58074f6e7347f4691a8e5df175cecce74e9 Author: Alexey Baskakov <loyso@chromium.org> Date: Wed May 09 11:33:15 2018 cryptohome: Mark Cryptohome.FreedGCacheDiskSpaceInMb histogram obsolete In low disk space scenarios, Cryptohome erases encrypted Google Drive cache. Cryptohome.FreedGCacheDiskSpaceInMb reported zero in 99% of hits, which was not informative. Deprecated 05/2018 in favor of Cryptohome.GCache.FreedDiskSpaceInMb. Chromium part: https://chromium-review.googlesource.com/c/chromium/src/+/1034423 BUG= chromium:835114 TEST=none Change-Id: I11202bd565704a7f58753c680ace73c478b9f062 Reviewed-on: https://chromium-review.googlesource.com/1034426 Commit-Ready: Alexey Baskakov <loyso@chromium.org> Tested-by: Alexey Baskakov <loyso@chromium.org> Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> [modify] https://crrev.com/3918d58074f6e7347f4691a8e5df175cecce74e9/cryptohome/cryptohome_metrics.cc
,
May 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/4b35d8542bddcdf5766b9c63e1fe733053a833eb commit 4b35d8542bddcdf5766b9c63e1fe733053a833eb Author: Alexey Baskakov <loyso@chromium.org> Date: Sat May 12 06:22:20 2018 cryptohome: Add Cryptohome.DiskCleanupProgress enum histogram In low disk space scenarios, Cryptohome erases caches while target amount of free disk space is not reached. It starts from low priority categories. Cryptohome.DiskCleanupProgress histogram reports, which topmost priority was reached to fulfill a cleanup request. chromium/src part: https://chromium-review.googlesource.com/c/chromium/src/+/1051209 We need to land this before Friday to get it working in M68. BUG= chromium:835114 TEST=none Change-Id: I4cc59c44fc12f428d553a4e329f1ceb809148069 Reviewed-on: https://chromium-review.googlesource.com/1049986 Commit-Ready: Alexey Baskakov <loyso@chromium.org> Tested-by: Alexey Baskakov <loyso@chromium.org> Reviewed-by: Andrey Pronin <apronin@chromium.org> [modify] https://crrev.com/4b35d8542bddcdf5766b9c63e1fe733053a833eb/cryptohome/homedirs_unittest.cc [modify] https://crrev.com/4b35d8542bddcdf5766b9c63e1fe733053a833eb/cryptohome/cryptohome_metrics.cc [modify] https://crrev.com/4b35d8542bddcdf5766b9c63e1fe733053a833eb/cryptohome/cryptohome_metrics.h [modify] https://crrev.com/4b35d8542bddcdf5766b9c63e1fe733053a833eb/cryptohome/homedirs.cc
,
May 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06e8f30c64c5cb64a34a848f5deca28814d4d04a commit 06e8f30c64c5cb64a34a848f5deca28814d4d04a Author: Alexey Baskakov <loyso@chromium.org> Date: Sun May 13 03:44:21 2018 cros: Add Cryptohome.DiskCleanupProgress enum histogram In low disk space scenarios, Cryptohome erases caches while target amount of free disk space is not reached. It starts from low priority categories. Cryptohome.DiskCleanupProgress histogram reports, which topmost priority was reached to fulfill a cleanup request. platform2 part: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1049986 We need to land this before Friday to get it working in M68. Bug: 835114 Change-Id: Ia89335ac64d2e94ae7298b24a96de8547d8e392e Reviewed-on: https://chromium-review.googlesource.com/1051209 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#558152} [modify] https://crrev.com/06e8f30c64c5cb64a34a848f5deca28814d4d04a/tools/metrics/histograms/enums.xml [modify] https://crrev.com/06e8f30c64c5cb64a34a848f5deca28814d4d04a/tools/metrics/histograms/histograms.xml
,
May 15 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by loyso@chromium.org
, Apr 20 2018