New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 835078 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Mac
Pri: 3
Type: Task

Blocked on:
issue 837153



Sign in to add a comment

Add nose landmark on Mac Vision and Google Play Services Vision

Project Member Reported by junwei...@intel.com, Apr 20 2018

Issue description


The proposal has been merged in Shape Detection Spec with PR-38 [1].

[1] https://github.com/WICG/shape-detection-api/pull/38
 

Comment 1 by junwei...@intel.com, Apr 26 2018

Blocking: 837153

Comment 2 by junwei...@intel.com, Apr 26 2018

Blockedon: 837153
Blocking: -837153
Project Member

Comment 3 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6400df0bddc3dc6836daeb12cc3af74691ccdaa

commit f6400df0bddc3dc6836daeb12cc3af74691ccdaa
Author: junweifu <junwei.fu@intel.com>
Date: Thu May 10 09:06:24 2018

ShapeDetection: Add nose landmark of face to match Specification

Add nose landmark enum in the mojom definition and the IDL to match the Spec[1].
Get nose information with Vision Framework on Mac and GMS core on Android platform.

Link Mac 10.13 build bots [2] and Face Detection demo[3] here.

[1] https://github.com/WICG/shape-detection-api/pull/38
[2] https://ci.chromium.org/buildbot/chromium.fyi/Chromium%20Mac%2010.13/
[3] https://codepen.io/miguelao/pen/PmJWro

BUG=835078

Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Change-Id: I0818bf817bf047a19ec7b34b232c93e4d08e9fa2
Reviewed-on: https://chromium-review.googlesource.com/1020385
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Junwei Fu <junwei.fu@intel.com>
Cr-Commit-Position: refs/heads/master@{#557479}
[modify] https://crrev.com/f6400df0bddc3dc6836daeb12cc3af74691ccdaa/services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImplGmsCore.java
[modify] https://crrev.com/f6400df0bddc3dc6836daeb12cc3af74691ccdaa/services/shape_detection/android/javatests/src/org/chromium/shape_detection/FaceDetectionImplTest.java
[modify] https://crrev.com/f6400df0bddc3dc6836daeb12cc3af74691ccdaa/services/shape_detection/face_detection_impl_mac_unittest.mm
[modify] https://crrev.com/f6400df0bddc3dc6836daeb12cc3af74691ccdaa/services/shape_detection/face_detection_impl_mac_vision.mm
[modify] https://crrev.com/f6400df0bddc3dc6836daeb12cc3af74691ccdaa/services/shape_detection/public/mojom/facedetection.mojom
[modify] https://crrev.com/f6400df0bddc3dc6836daeb12cc3af74691ccdaa/third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
[modify] https://crrev.com/f6400df0bddc3dc6836daeb12cc3af74691ccdaa/third_party/WebKit/LayoutTests/shapedetection/resources/mock-facedetection.js
[modify] https://crrev.com/f6400df0bddc3dc6836daeb12cc3af74691ccdaa/third_party/blink/renderer/modules/shapedetection/face_detector.cc
[modify] https://crrev.com/f6400df0bddc3dc6836daeb12cc3af74691ccdaa/third_party/blink/renderer/modules/shapedetection/landmark.idl

Project Member

Comment 4 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2327f4cadd3ef6aa4e3b5ed29f84e81dcc368d28

commit 2327f4cadd3ef6aa4e3b5ed29f84e81dcc368d28
Author: junweifu <junwei.fu@intel.com>
Date: Fri May 25 01:14:55 2018

Add services unittests for landmarks points on Mac

The landmarks is one point with the implementation of Core Image Framework,
but an array of points along landmarks are more accurate with Vision Framework.

Bug=835078

Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win10_chromium_x64_rel_ng
Change-Id: I8b09068bc95309fc66d3a8bd6726ac951815eb4f
Reviewed-on: https://chromium-review.googlesource.com/1070766
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Junwei Fu <junwei.fu@intel.com>
Cr-Commit-Position: refs/heads/master@{#561719}
[modify] https://crrev.com/2327f4cadd3ef6aa4e3b5ed29f84e81dcc368d28/services/shape_detection/face_detection_impl_mac_unittest.mm

Sign in to add a comment