[MacViews-Browser]: 'Settings' option under Wrench menu disabled after exit from full screen. |
|||||
Issue descriptionChrome Version: 67.0.3396.10 OS: Mac OS 10.13.3 What steps will reproduce the problem? (1) Enable MacViews-Browser (2) Enter into full screen clicking the full screen option under Wrench menu. (3) Exit from full screen and click the Wrench menu and observe the Settings option. What is the expected result? > Settings option should be enabled. What happens instead? >Settings option is disabled under Wrench menu. >Setting option under Wrench menu is enabled only after close and relaunch of the browser.
,
Apr 25 2018
Pls mark the bug as fixed if CL is landed in trunk and nothing else is pending. Thank you.
,
May 22 2018
M68 branch is coming soon on this Thursday, 05/24 and M68 Beta promotion is on 06/07. This bug is marked as P1 for M68. Pls land the fix to trunk ASAP (if possible before 4:00 PM PT this Thursday in order to make it to M68 branch build cut. Thank you.
,
May 29 2018
,
May 30 2018
weili@, can you take a look at this? :)
,
May 31 2018
M68 Beta promotion is coming soon on June 7th. Pls land the change to trunk ASAP and request a merge to M68 by EOD, this Friday (06/01). So we can take the merge in for M68 beta promotion to run 50% experiment. Thank you.
,
Jun 1 2018
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d420e64d93157a657f1f73af263267f973040e0 commit 2d420e64d93157a657f1f73af263267f973040e0 Author: Wei Li <weili@chromium.org> Date: Tue Jun 05 16:48:28 2018 Handle top view status correctly for Mac full screen mode On Mac, by default the top view (tab strip and toolbar etc.) should show up unless the user explicitly toggle the option to hide the top view. So, this CL fixes whether to hide the top view according to whether it is in full screen mode as well as user's choice. This CL also adds a test to make sure the top view's status is correct across all platforms, especially on Mac. BUG= 835068 , 835067 ,831219 Change-Id: Iaec1c2eba5eebff5f012e6f02ca73a5aa0a8a08d Reviewed-on: https://chromium-review.googlesource.com/1086123 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#564541} [modify] https://crrev.com/2d420e64d93157a657f1f73af263267f973040e0/chrome/browser/ui/views/frame/browser_view.cc [modify] https://crrev.com/2d420e64d93157a657f1f73af263267f973040e0/chrome/browser/ui/views/frame/browser_view_interactive_uitest.cc
,
Jun 5 2018
This should be fixed, pls confirm. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ellyjo...@chromium.org
, Apr 20 2018Status: Assigned (was: Untriaged)