New issue
Advanced search Search tips

Issue 835061 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Add an option to cros_run_vm_test to pull files from the vm after test completion

Project Member Reported by bpastene@chromium.org, Apr 20 2018

Issue description

For chromium's use case, the test we'll be running will usually output a results file. We'd like to retrieve this file from the VM after the test completes, but the VM gets torn down before we get a chance.

Could we get an option added to cros_run_vm_test to pull files from the VM after the test completes? Or maybe just an entire directory?
 
Owner: achuith@chromium.org
Status: Assigned (was: Untriaged)
Cc: -achuith@chromium.org
Status: Started (was: Assigned)
https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1021531
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/f7775230086a421af361d23eca8554fc06233f1a

commit f7775230086a421af361d23eca8554fc06233f1a
Author: Achuith Bhandarkar <achuith@chromium.org>
Date: Thu Apr 26 06:00:16 2018

cros_run_vm_test: Support for fetching results.

--results-src and --results-dest-dir allows for fetching log files
after a test is run. It copies files and/or directories from the VM
specified by --results-src to the local path specified by
--results-dest-dir.

BUG= chromium:835061 
TEST=cros_run_vm_test --results-src /var/log
cros_run_vm_test --results-dest-dir /var/tmp
cros_run_vm_test --results-src foo --results-dest-dir /var/tmp
cros_run_vm_test --results-src /var/log --results-src /etc/hosts
--results-dest-dir /var/tmp/results

Change-Id: I334dc96200dc3fe410dd22bb0d2ae540c06a67d0
Reviewed-on: https://chromium-review.googlesource.com/1021531
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>

[modify] https://crrev.com/f7775230086a421af361d23eca8554fc06233f1a/scripts/cros_run_vm_test.py

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/344eacf147bf39d4754fadc5b39408840f28fdcb

commit 344eacf147bf39d4754fadc5b39408840f28fdcb
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Apr 26 08:06:09 2018

Roll src/third_party/chromite/ 48a13aacf..aa6cca469 (9 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/48a13aacf880..aa6cca46950b

$ git log 48a13aacf..aa6cca469 --date=short --no-merges --format='%ad %ae %s'
2018-04-19 lepton cros_vm: Use a smaller virtual network.
2018-04-24 laszio afdo: refining codes
2018-04-10 dgarrett chromeos_config: TRYBOT -> SWARMING.
2018-04-24 rockot Include libmojo_core.so in Chrome deployment
2018-04-19 pberny chromeos_config: Add sign_types to meowth release
2018-04-20 achuith cros_run_vm_test: Support for fetching results.
2018-04-17 bmgordon cbuildbot: Add --previous-build-state option
2018-04-13 bmgordon build_summary: Helper class to represent build summaries
2018-04-24 dgarrett cros tryjob: Always use PRODUCTION_TRYJOB display label.

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:808045,chromium:829170,chromium:None,chromium:822034,chromium:835061,chromium:829665,chromium:829665,chromium:832768


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I7d1aa5c4c4bd153fd47f6d7cc7532ac35cdff73b
Reviewed-on: https://chromium-review.googlesource.com/1029771
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553948}
[modify] https://crrev.com/344eacf147bf39d4754fadc5b39408840f28fdcb/DEPS

Status: Fixed (was: Started)

Sign in to add a comment