New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 835035 link

Starred by 17 users

Issue metadata

Status: Duplicate
Merged: issue 877747
Owner: ----
Closed: Sep 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug


Show other hotlists

Hotlists containing this issue:
Chromium-bugs-related-to-Crostini


Sign in to add a comment

virtio-wl driver dereferences a nullptr if chrome restarts

Project Member Reported by chirantan@chromium.org, Apr 19 2018

Issue description

It looks like the virtio-wl driver in the guest kernel can't handle chrome crashing:

    2018-04-18T20:06:42.421160-07:00 ALERT VM(7)[17140]: kernel: BUG: unable to handle kernel NULL pointer dereference at 0000000000000084
    2018-04-18T20:06:42.421165-07:00 ALERT VM(7)[17140]: kernel: IP: virtwl_ioctl_recv+0x134/0x1ef
    2018-04-18T20:06:42.421166-07:00 INFO VM(7)[17140]: kernel: PGD 0 P4D 0
    2018-04-18T20:06:42.421168-07:00 WARNING VM(7)[17140]: kernel: Oops: 0000 [#1] PREEMPT SMP PTI
    2018-04-18T20:06:42.421169-07:00 WARNING VM(7)[17140]: kernel: CPU: 1 PID: 10095 Comm: ld-linux-x86-64 Not tainted 4.14.34-04698-ga6700f41a491 #1
    2018-04-18T20:06:42.421171-07:00 WARNING VM(7)[17140]: kernel: task: ffff8802cfb31e00 task.stack: ffffc90000350000
    2018-04-18T20:06:42.421175-07:00 WARNING VM(7)[17140]: kernel: RIP: 0010:virtwl_ioctl_recv+0x134/0x1ef
    2018-04-18T20:06:42.421176-07:00 WARNING VM(7)[17140]: kernel: RSP: 0018:ffffc90000353ca0 EFLAGS: 00010297
    2018-04-18T20:06:42.421178-07:00 WARNING VM(7)[17140]: kernel: RAX: 0000000000000000 RBX: 00007fffa510f5e0 RCX: 0000000000000000
    2018-04-18T20:06:42.421179-07:00 WARNING VM(7)[17140]: kernel: RDX: 0000000000000000 RSI: ffffffff81a64940 RDI: ffffffff81b87b07
    2018-04-18T20:06:42.421180-07:00 WARNING VM(7)[17140]: kernel: RBP: 0000000000000002 R08: ffffc90000353ca8 R09: 000079a182d01dd0
    2018-04-18T20:06:42.421182-07:00 WARNING VM(7)[17140]: kernel: R10: ffffc90000353ed8 R11: 0000000000000000 R12: 0000000000000000
    2018-04-18T20:06:42.421183-07:00 WARNING VM(7)[17140]: kernel: R13: 0000000000000007 R14: 00007fffa510f5e0 R15: 0000000000000000
    2018-04-18T20:06:42.421185-07:00 WARNING VM(7)[17140]: kernel: FS:  000079a1810ba880(0000) GS:ffff8802ea080000(0000) knlGS:0000000000000000
    2018-04-18T20:06:42.421186-07:00 WARNING VM(7)[17140]: kernel: CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
    2018-04-18T20:06:42.421188-07:00 WARNING VM(7)[17140]: kernel: CR2: 0000000000000084 CR3: 0000000266434005 CR4: 00000000003606a0
    2018-04-18T20:06:42.421189-07:00 WARNING VM(7)[17140]: kernel: DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
    2018-04-18T20:06:42.421190-07:00 WARNING VM(7)[17140]: kernel: DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
    2018-04-18T20:06:42.421192-07:00 WARNING VM(7)[17140]: kernel: Call Trace:
    2018-04-18T20:06:42.421193-07:00 WARNING VM(7)[17140]: kernel:  vfs_ioctl+0x18/0x25
    2018-04-18T20:06:42.421194-07:00 WARNING VM(7)[17140]: kernel:  do_vfs_ioctl+0x4ad/0x4bc
    2018-04-18T20:06:42.421196-07:00 WARNING VM(7)[17140]: kernel:  SyS_ioctl+0x4d/0x6f
    2018-04-18T20:06:42.421197-07:00 WARNING VM(7)[17140]: kernel:  do_syscall_64+0x6a/0x7a
    2018-04-18T20:06:42.421199-07:00 WARNING VM(7)[17140]: kernel:  entry_SYSCALL_64_after_hwframe+0x3d/0xa2
    2018-04-18T20:06:42.421200-07:00 WARNING VM(7)[17140]: kernel: RIP: 0033:0x79a180a92967
    2018-04-18T20:06:42.421201-07:00 WARNING VM(7)[17140]: kernel: RSP: 002b:00007fffa510f508 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
    2018-04-18T20:06:42.421203-07:00 WARNING VM(7)[17140]: kernel: RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 000079a180a92967
    2018-04-18T20:06:42.421205-07:00 WARNING VM(7)[17140]: kernel: RDX: 00007fffa510f5e0 RSI: 0000000040747702 RDI: 0000000000000007
    2018-04-18T20:06:42.421207-07:00 WARNING VM(7)[17140]: kernel: RBP: 00007fffa5110610 R08: 0000000000000000 R09: 000079a182d01dd0
    2018-04-18T20:06:42.421208-07:00 WARNING VM(7)[17140]: kernel: R10: 00000000ffffffff R11: 0000000000000246 R12: 0000000000000000
    2018-04-18T20:06:42.421209-07:00 WARNING VM(7)[17140]: kernel: R13: 000079a182cf1960 R14: 00007fffa51114c8 R15: 0000000000000001
    2018-04-18T20:06:42.421211-07:00 WARNING VM(7)[17140]: kernel: Code: 00 e9 c8 00 00 00 45 31 e4 bd 02 00 00 00 4c 3b 64 24 08 73 72 4a 8b 94 e4 f8 00 00 00 48 c7 c6 40 49 a6 81 48 c7 c7 07 7b b8 81 <8b> 8a 84 00 00 00 89 c8 83 e1 01 83 e0 03 83 f8 03 0f 44 cd 89
    2018-04-18T20:06:42.421212-07:00 ALERT VM(7)[17140]: kernel: RIP: virtwl_ioctl_recv+0x134/0x1ef RSP: ffffc90000353ca0
    2018-04-18T20:06:42.421214-07:00 WARNING VM(7)[17140]: kernel: CR2: 0000000000000084
    2018-04-18T20:06:42.421215-07:00 WARNING VM(7)[17140]: kernel: ---[ end trace 5e6428036097e231 ]---
    
    
    2018-04-18T20:06:42.421217-07:00 ALERT VM(7)[17140]: kernel: BUG: unable to handle kernel NULL pointer dereference at 0000000000000084
    2018-04-18T20:06:42.421218-07:00 ALERT VM(7)[17140]: kernel: IP: virtwl_ioctl_recv+0x134/0x1ef
    2018-04-18T20:06:42.421220-07:00 INFO VM(7)[17140]: kernel: PGD 0 P4D 0
    2018-04-18T20:06:42.421221-07:00 WARNING VM(7)[17140]: kernel: Oops: 0000 [#2] PREEMPT SMP PTI
    2018-04-18T20:06:42.421223-07:00 WARNING VM(7)[17140]: kernel: CPU: 3 PID: 18694 Comm: ld-linux-x86-64 Tainted: G      D         4.14.34-04698-ga6700f41a491 #1
    2018-04-18T20:06:42.421224-07:00 WARNING VM(7)[17140]: kernel: task: ffff88023aa60f00 task.stack: ffffc90008394000
    2018-04-18T20:06:42.421225-07:00 WARNING VM(7)[17140]: kernel: RIP: 0010:virtwl_ioctl_recv+0x134/0x1ef
    2018-04-18T20:06:42.421227-07:00 WARNING VM(7)[17140]: kernel: RSP: 0018:ffffc90008397ca0 EFLAGS: 00010297
    2018-04-18T20:06:42.421228-07:00 WARNING VM(7)[17140]: kernel: RAX: 0000000000000000 RBX: 00007ffca6229300 RCX: 0000000000000000
    2018-04-18T20:06:42.421230-07:00 WARNING VM(7)[17140]: kernel: RDX: 0000000000000000 RSI: ffffffff81a64940 RDI: ffffffff81b87b07
    2018-04-18T20:06:42.421231-07:00 WARNING VM(7)[17140]: kernel: RBP: 0000000000000002 R08: ffffc90008397ca8 R09: 00007ebdbf4c6bd8
    2018-04-18T20:06:42.421233-07:00 WARNING VM(7)[17140]: kernel: R10: ffffc90008397ed8 R11: 0000000000000000 R12: 0000000000000000
    2018-04-18T20:06:42.421234-07:00 WARNING VM(7)[17140]: kernel: R13: 0000000000000008 R14: 00007ffca6229300 R15: 0000000000000000
    2018-04-18T20:06:42.421235-07:00 WARNING VM(7)[17140]: kernel: FS:  00007ebdbf838880(0000) GS:ffff8802ea180000(0000) knlGS:0000000000000000
    2018-04-18T20:06:42.421236-07:00 WARNING VM(7)[17140]: kernel: CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
    2018-04-18T20:06:42.421238-07:00 WARNING VM(7)[17140]: kernel: CR2: 0000000000000084 CR3: 000000023a8a2001 CR4: 00000000003606a0
    2018-04-18T20:06:42.421240-07:00 WARNING VM(7)[17140]: kernel: DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
    2018-04-18T20:06:42.421241-07:00 WARNING VM(7)[17140]: kernel: DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
    2018-04-18T20:06:42.421242-07:00 WARNING VM(7)[17140]: kernel: Call Trace:
    2018-04-18T20:06:42.421244-07:00 WARNING VM(7)[17140]: kernel:  vfs_ioctl+0x18/0x25
    2018-04-18T20:06:47.434142-07:00 WARNING VM(7)[17140]: kernel:  do_vfs_ioctl+0x4ad/0x4bc
    2018-04-18T20:06:47.434158-07:00 WARNING VM(7)[17140]: kernel:  SyS_ioctl+0x4d/0x6f
    2018-04-18T20:06:47.434163-07:00 WARNING VM(7)[17140]: kernel:  do_syscall_64+0x6a/0x7a
    2018-04-18T20:06:47.434168-07:00 WARNING VM(7)[17140]: kernel:  entry_SYSCALL_64_after_hwframe+0x3d/0xa2
    2018-04-18T20:06:47.434173-07:00 WARNING VM(7)[17140]: kernel: RIP: 0033:0x7ebdbf210967
    2018-04-18T20:06:47.434177-07:00 WARNING VM(7)[17140]: kernel: RSP: 002b:00007ffca6229228 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
    2018-04-18T20:06:47.434181-07:00 WARNING VM(7)[17140]: kernel: RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007ebdbf210967
    2018-04-18T20:06:47.434186-07:00 WARNING VM(7)[17140]: kernel: RDX: 00007ffca6229300 RSI: 0000000040747702 RDI: 0000000000000008
    2018-04-18T20:06:47.434190-07:00 WARNING VM(7)[17140]: kernel: RBP: 00007ffca622a330 R08: 0000000000000000 R09: 00007ebdbf4c6bd8
    2018-04-18T20:06:47.434194-07:00 WARNING VM(7)[17140]: kernel: R10: 00000000ffffffff R11: 0000000000000246 R12: 0000000000000000
    2018-04-18T20:06:47.434199-07:00 WARNING VM(7)[17140]: kernel: R13: 00007ebdc0d81960 R14: 00007ffca622b1e8 R15: 0000000000000001
    2018-04-18T20:06:47.434204-07:00 WARNING VM(7)[17140]: kernel: Code: 00 e9 c8 00 00 00 45 31 e4 bd 02 00 00 00 4c 3b 64 24 08 73 72 4a 8b 94 e4 f8 00 00 00 48 c7 c6 40 49 a6 81 48 c7 c7 07 7b b8 81 <8b> 8a 84 00 00 00 89 c8 83 e1 01 83 e0 03 83 f8 03 0f 44 cd 89
    2018-04-18T20:06:47.434210-07:00 ALERT VM(7)[17140]: kernel: RIP: virtwl_ioctl_recv+0x134/0x1ef RSP: ffffc90008397ca0
    2018-04-18T20:06:47.434214-07:00 WARNING VM(7)[17140]: kernel: CR2: 0000000000000084
    2018-04-18T20:06:47.434218-07:00 WARNING VM(7)[17140]: kernel: ---[ end trace 5e6428036097e232 ]---
    
    
    2018-04-18T20:06:47.434222-07:00 ERR VM(7)[17140]: kernel: BUG: sleeping function called from invalid context at ../../../../../tmp/portage/sys-kernel/chromeos-kernel-4_14-4.14.34-r237/work/chromeos-kernel-4_14-4.14.34/include/linux/percpu-rwsem.h:34
    2018-04-18T20:06:47.434226-07:00 ERR VM(7)[17140]: kernel: in_atomic(): 0, irqs_disabled(): 1, pid: 18694, name: ld-linux-x86-64
    2018-04-18T20:06:47.434232-07:00 WARNING VM(7)[17140]: kernel: CPU: 3 PID: 18694 Comm: ld-linux-x86-64 Tainted: G      D         4.14.34-04698-ga6700f41a491 #1
    2018-04-18T20:06:47.434236-07:00 WARNING VM(7)[17140]: kernel: Call Trace:
    2018-04-18T20:06:47.434241-07:00 WARNING VM(7)[17140]: kernel:  dump_stack+0x5a/0x6f
    2018-04-18T20:06:47.434246-07:00 WARNING VM(7)[17140]: kernel:  ___might_sleep+0x129/0x13a
    2018-04-18T20:06:47.434250-07:00 WARNING VM(7)[17140]: kernel:  exit_signals+0x19/0x120
    2018-04-18T20:06:47.434255-07:00 WARNING VM(7)[17140]: kernel:  do_exit+0x133/0x9c1
    2018-04-18T20:06:47.434260-07:00 WARNING VM(7)[17140]: kernel:  ? SyS_ioctl+0x4d/0x6f
    2018-04-18T20:06:47.434264-07:00 WARNING VM(7)[17140]: kernel:  rewind_stack_do_exit+0x17/0x20


This breaks GUI apps for that VM because even though chrome is restarted, the driver doesn't get back into a good state.
 
Cc: tbuck...@chromium.org
Summary: virtio-wl driver dereferences a nullptr if chrome restarts (was: virtio-wl driver dereferences a nullptr if chrome crashes)
 Issue 859348  has been merged into this issue.
Labels: Proj-Containers
Mergedinto: 877747
Status: Duplicate (was: Available)

Sign in to add a comment