Enable display zoom slider by default on Chrome OS |
||||||||||
Issue descriptionThe display zoom is currently only accessible via enabling the chrome flag first. We want to switch to enable it by default.
,
Apr 20 2018
,
Apr 20 2018
,
Apr 20 2018
,
Apr 20 2018
,
Apr 20 2018
Seems like a feature / nice to have rather than a bug fix?
,
Apr 20 2018
This is simply enabling the feature (Issue 790723). We were waiting for all the launch approvals.
,
Apr 21 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 21 2018
,
Apr 24 2018
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c483e3b4559567ccdd1d11c7de29e6ce941da3e8 commit c483e3b4559567ccdd1d11c7de29e6ce941da3e8 Author: Malay Keshav <malaykeshav@chromium.org> Date: Tue Apr 24 03:18:43 2018 Use display zoom factors instead of ui scales This patch replaces ui scales for zoom factors to allow the clients to compute the ideal content scale. This patch also adds more scale factor enums to aura shell interface. Bug: 835030 , 836054 Component: aura shell Change-Id: Id5abd8b2d572365e27f453efd53e1ad46d327424 Reviewed-on: https://chromium-review.googlesource.com/1024920 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#552986} [modify] https://crrev.com/c483e3b4559567ccdd1d11c7de29e6ce941da3e8/components/exo/wayland/clients/info.cc [modify] https://crrev.com/c483e3b4559567ccdd1d11c7de29e6ce941da3e8/components/exo/wayland/protocol/aura-shell.xml [modify] https://crrev.com/c483e3b4559567ccdd1d11c7de29e6ce941da3e8/components/exo/wayland/public/aura-shell-client-protocol.h [modify] https://crrev.com/c483e3b4559567ccdd1d11c7de29e6ce941da3e8/components/exo/wayland/public/aura-shell-server-protocol.h [modify] https://crrev.com/c483e3b4559567ccdd1d11c7de29e6ce941da3e8/components/exo/wayland/server.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7173c01de898a26527227bbe4d49aa37e1beaa6 commit e7173c01de898a26527227bbe4d49aa37e1beaa6 Author: Malay Keshav <malaykeshav@chromium.org> Date: Tue Apr 24 06:36:12 2018 Re-enable display zoom setting by default This patch enables display zoom setting by default on chromeos. TBR=oshima@chromium.org Bug: 835030 Change-Id: I48c2cfeed6b74bced55d3274414adfd2bdc283e9 Reviewed-on: https://chromium-review.googlesource.com/1025550 Reviewed-by: Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#553018} [modify] https://crrev.com/e7173c01de898a26527227bbe4d49aa37e1beaa6/ui/display/display_switches.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1497e2bccf108e7dca7719cf81b754e1144b16dc commit 1497e2bccf108e7dca7719cf81b754e1144b16dc Author: Malay Keshav <malaykeshav@chromium.org> Date: Wed Apr 25 00:00:13 2018 (merge) Enable display zoom slider by default Merge to M67 This patch moves the flag base for enable display zoom slider from a switch to a feature and enables it by default. Bug: 835030 Change-Id: I91e3c99645a6a7397ba06a10ff848e5a132fe5bf Component: display switches, chromeos switches, settings ui Reviewed-on: https://chromium-review.googlesource.com/1018145 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#552207} Reviewed-on: https://chromium-review.googlesource.com/1026937 Reviewed-by: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#273} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/1497e2bccf108e7dca7719cf81b754e1144b16dc/ash/accelerators/accelerator_commands.cc [modify] https://crrev.com/1497e2bccf108e7dca7719cf81b754e1144b16dc/chrome/browser/about_flags.cc [modify] https://crrev.com/1497e2bccf108e7dca7719cf81b754e1144b16dc/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/1497e2bccf108e7dca7719cf81b754e1144b16dc/chrome/test/data/webui/settings/device_page_tests.js [modify] https://crrev.com/1497e2bccf108e7dca7719cf81b754e1144b16dc/chromeos/chromeos_switches.cc [modify] https://crrev.com/1497e2bccf108e7dca7719cf81b754e1144b16dc/chromeos/chromeos_switches.h [modify] https://crrev.com/1497e2bccf108e7dca7719cf81b754e1144b16dc/tools/metrics/histograms/enums.xml [modify] https://crrev.com/1497e2bccf108e7dca7719cf81b754e1144b16dc/ui/display/display_switches.cc [modify] https://crrev.com/1497e2bccf108e7dca7719cf81b754e1144b16dc/ui/display/display_switches.h [modify] https://crrev.com/1497e2bccf108e7dca7719cf81b754e1144b16dc/ui/display/manager/chromeos/display_change_observer.cc [modify] https://crrev.com/1497e2bccf108e7dca7719cf81b754e1144b16dc/ui/display/manager/chromeos/display_change_observer_unittest.cc
,
Apr 25 2018
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36412d77e4e8a7d5b6d06d8f2861412c007c65ef commit 36412d77e4e8a7d5b6d06d8f2861412c007c65ef Author: Malay Keshav <malaykeshav@chromium.org> Date: Wed Apr 25 04:17:18 2018 (merge) Use display zoom factors instead of ui scales Merge to M67 This patch replaces ui scales for zoom factors to allow the clients to compute the ideal content scale. This patch also adds more scale factor enums to aura shell interface. Bug: 835030 , 836054 Component: aura shell Change-Id: Id5abd8b2d572365e27f453efd53e1ad46d327424 Reviewed-on: https://chromium-review.googlesource.com/1024920 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#552986}(cherry picked from commit c483e3b4559567ccdd1d11c7de29e6ce941da3e8) TBR=reveman@chromium.org Change-Id: Id5abd8b2d572365e27f453efd53e1ad46d327424 Reviewed-on: https://chromium-review.googlesource.com/1027271 Reviewed-by: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#281} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/36412d77e4e8a7d5b6d06d8f2861412c007c65ef/components/exo/wayland/clients/info.cc [modify] https://crrev.com/36412d77e4e8a7d5b6d06d8f2861412c007c65ef/components/exo/wayland/protocol/aura-shell.xml [modify] https://crrev.com/36412d77e4e8a7d5b6d06d8f2861412c007c65ef/components/exo/wayland/public/aura-shell-client-protocol.h [modify] https://crrev.com/36412d77e4e8a7d5b6d06d8f2861412c007c65ef/components/exo/wayland/public/aura-shell-server-protocol.h [modify] https://crrev.com/36412d77e4e8a7d5b6d06d8f2861412c007c65ef/components/exo/wayland/server.cc
,
Apr 26 2018
M67 compilation is broken with error
../../components/exo/wayland/server.cc:98:10: fatal error: 'ui/display/manager/display_util.h' file not found
#include "ui/display/manager/display_util.h"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Seems that some moved this file in this cl
https://chromium-review.googlesource.com/c/chromium/src/+/969416.
,
Apr 26 2018
Looking into it. Will revert and re-merge
,
Apr 26 2018
Thanks for looking into the fix per #17; this broke the Chrome PFQ for M67.....
,
Apr 26 2018
#16 Please verify. Fix is merged.
,
Apr 26 2018
Is there a different CL for the fix? Need to check where it landed for merge / release confirmation.
,
Apr 26 2018
Thanks, please IM after merged; I need to uprev. Thx |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by bugdroid1@chromium.org
, Apr 20 2018