New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 835029 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit 20 days ago
Closed: Nov 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 860041
issue 865797
issue 885219
issue 900736
issue 900793

Blocking:
issue 862774



Sign in to add a comment

Eng tracking for Recommend Apps in CrOS OOBE

Project Member Reported by rsgingerrs@chromium.org, Apr 19 2018

Issue description

Labels: -Pri-3 OS-Chrome Pri-1
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46eca389f03f0d2096c0fb82779e5bc979a79bd0

commit 46eca389f03f0d2096c0fb82779e5bc979a79bd0
Author: Yue Cen <rsgingerrs@chromium.org>
Date: Tue Apr 24 18:30:17 2018

Chrome OS: Implement UI for first login Recommend Apps screen.

This only contains the UI skeleton.

Bug:  835029 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I98f22b71dd3ab0a51e2f13ab96c54a011897a15d
Reviewed-on: https://chromium-review.googlesource.com/1016083
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553208}
[modify] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/chromeos/login/oobe_screen.cc
[modify] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/chromeos/login/oobe_screen.h
[add] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/chromeos/login/screens/recommend_apps_screen.cc
[add] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/chromeos/login/screens/recommend_apps_screen.h
[add] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/chromeos/login/screens/recommend_apps_screen_view.h
[modify] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/chromeos/login/screens/screen_exit_code.cc
[modify] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/chromeos/login/screens/screen_exit_code.h
[modify] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/chromeos/login/wizard_controller.h
[modify] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
[modify] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/resources/chromeos/login/custom_elements_login.html
[modify] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/resources/chromeos/login/custom_elements_login.js
[modify] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/resources/chromeos/login/custom_elements_oobe.html
[modify] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/resources/chromeos/login/custom_elements_oobe.js
[modify] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/resources/chromeos/login/login.js
[modify] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/resources/chromeos/login/login_non_lock_shared.js
[modify] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/resources/chromeos/login/login_screens.html
[modify] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/resources/chromeos/login/md_login.js
[modify] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/resources/chromeos/login/md_login_screens.html
[modify] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/resources/chromeos/login/oobe.js
[modify] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/resources/chromeos/login/oobe_screens.html
[add] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/resources/chromeos/login/recommend_apps.css
[add] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/resources/chromeos/login/recommend_apps.html
[add] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/resources/chromeos/login/recommend_apps.js
[add] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/resources/chromeos/login/screen_recommend_apps.html
[add] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/resources/chromeos/login/screen_recommend_apps.js
[modify] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
[modify] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/ui/webui/chromeos/login/oobe_ui.h
[add] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/ui/webui/chromeos/login/recommend_apps_screen_handler.cc
[add] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/chrome/browser/ui/webui/chromeos/login/recommend_apps_screen_handler.h
[modify] https://crrev.com/46eca389f03f0d2096c0fb82779e5bc979a79bd0/ui/login/display_manager.js

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 8 2018

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df28facff9e94dce85939bbe5830c306b565ef91

commit df28facff9e94dce85939bbe5830c306b565ef91
Author: Yue Cen <rsgingerrs@chromium.org>
Date: Thu Jun 14 05:14:16 2018

Use a WebView to display the recommended app list.

Bug:  835029 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id1562850b50d873d68c0bd1586f2eab1ec9a14e9
Reviewed-on: https://chromium-review.googlesource.com/1034112
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567150}
[modify] https://crrev.com/df28facff9e94dce85939bbe5830c306b565ef91/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/df28facff9e94dce85939bbe5830c306b565ef91/chrome/browser/chromeos/login/screens/recommend_apps_screen.cc
[modify] https://crrev.com/df28facff9e94dce85939bbe5830c306b565ef91/chrome/browser/chromeos/login/screens/recommend_apps_screen.h
[modify] https://crrev.com/df28facff9e94dce85939bbe5830c306b565ef91/chrome/browser/chromeos/login/screens/recommend_apps_screen_view.h
[add] https://crrev.com/df28facff9e94dce85939bbe5830c306b565ef91/chrome/browser/chromeos/login/screens/recommend_apps_screen_view_observer.h
[modify] https://crrev.com/df28facff9e94dce85939bbe5830c306b565ef91/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/df28facff9e94dce85939bbe5830c306b565ef91/chrome/browser/chromeos/login/wizard_controller.h
[add] https://crrev.com/df28facff9e94dce85939bbe5830c306b565ef91/chrome/browser/resources/chromeos/arc_support/recommend_app_list_view.html
[add] https://crrev.com/df28facff9e94dce85939bbe5830c306b565ef91/chrome/browser/resources/chromeos/arc_support/recommend_app_list_view.js
[modify] https://crrev.com/df28facff9e94dce85939bbe5830c306b565ef91/chrome/browser/resources/chromeos/login/recommend_apps.css
[modify] https://crrev.com/df28facff9e94dce85939bbe5830c306b565ef91/chrome/browser/resources/chromeos/login/recommend_apps.html
[modify] https://crrev.com/df28facff9e94dce85939bbe5830c306b565ef91/chrome/browser/resources/chromeos/login/recommend_apps.js
[modify] https://crrev.com/df28facff9e94dce85939bbe5830c306b565ef91/chrome/browser/resources/chromeos/login/screen_recommend_apps.js
[modify] https://crrev.com/df28facff9e94dce85939bbe5830c306b565ef91/chrome/browser/resources/component_extension_resources.grd
[modify] https://crrev.com/df28facff9e94dce85939bbe5830c306b565ef91/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
[modify] https://crrev.com/df28facff9e94dce85939bbe5830c306b565ef91/chrome/browser/ui/webui/chromeos/login/recommend_apps_screen_handler.cc
[modify] https://crrev.com/df28facff9e94dce85939bbe5830c306b565ef91/chrome/browser/ui/webui/chromeos/login/recommend_apps_screen_handler.h

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/daccddc224014dc05119771854383a878136d1fe

commit daccddc224014dc05119771854383a878136d1fe
Author: Yue Cen <rsgingerrs@chromium.org>
Date: Thu Jun 14 21:20:04 2018

Start Fast App Reinstall flow.

If the user clicks the Install button after ARC++ is provisioned, we should
start the flow right away. If not, we delay the flow until Play Store is ready.

ARC++ changes: ag/4174872

Bug:  835029 
Change-Id: I36037df522addd9aec3f525157e2e5478c9d4836
Reviewed-on: https://chromium-review.googlesource.com/1080012
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567420}
[modify] https://crrev.com/daccddc224014dc05119771854383a878136d1fe/chrome/browser/chromeos/arc/arc_session_manager.cc
[modify] https://crrev.com/daccddc224014dc05119771854383a878136d1fe/chrome/browser/chromeos/arc/arc_session_manager.h
[modify] https://crrev.com/daccddc224014dc05119771854383a878136d1fe/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/daccddc224014dc05119771854383a878136d1fe/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
[modify] https://crrev.com/daccddc224014dc05119771854383a878136d1fe/chrome/browser/ui/app_list/arc/arc_app_utils.cc
[modify] https://crrev.com/daccddc224014dc05119771854383a878136d1fe/chrome/browser/ui/app_list/arc/arc_app_utils.h
[add] https://crrev.com/daccddc224014dc05119771854383a878136d1fe/chrome/browser/ui/app_list/arc/arc_fast_app_reinstall_starter.cc
[add] https://crrev.com/daccddc224014dc05119771854383a878136d1fe/chrome/browser/ui/app_list/arc/arc_fast_app_reinstall_starter.h
[modify] https://crrev.com/daccddc224014dc05119771854383a878136d1fe/chrome/browser/ui/webui/chromeos/login/recommend_apps_screen_handler.cc
[modify] https://crrev.com/daccddc224014dc05119771854383a878136d1fe/components/arc/arc_prefs.cc
[modify] https://crrev.com/daccddc224014dc05119771854383a878136d1fe/components/arc/arc_prefs.h
[modify] https://crrev.com/daccddc224014dc05119771854383a878136d1fe/components/arc/common/app.mojom
[modify] https://crrev.com/daccddc224014dc05119771854383a878136d1fe/components/arc/test/fake_app_instance.cc
[modify] https://crrev.com/daccddc224014dc05119771854383a878136d1fe/components/arc/test/fake_app_instance.h

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/245e6851691bb57570d6e862eab0237be166f9d2

commit 245e6851691bb57570d6e862eab0237be166f9d2
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Fri Jun 15 04:28:17 2018

Revert "Start Fast App Reinstall flow."

This reverts commit daccddc224014dc05119771854383a878136d1fe.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 567420 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2RhY2NkZGMyMjQwMTRkYzA1MTE5NzcxODU0MzgzYTg3ODEzNmQxZmUM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/27924

Sample Failed Step: unit_tests

Original change's description:
> Start Fast App Reinstall flow.
> 
> If the user clicks the Install button after ARC++ is provisioned, we should
> start the flow right away. If not, we delay the flow until Play Store is ready.
> 
> ARC++ changes: ag/4174872
> 
> Bug:  835029 
> Change-Id: I36037df522addd9aec3f525157e2e5478c9d4836
> Reviewed-on: https://chromium-review.googlesource.com/1080012
> Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
> Reviewed-by: Greg Kerr <kerrnel@chromium.org>
> Reviewed-by: Yusuke Sato <yusukes@chromium.org>
> Reviewed-by: Yury Khmel <khmel@chromium.org>
> Reviewed-by: Alexander Alekseev <alemate@chromium.org>
> Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567420}

Change-Id: I9f2f20d8a1ea1a57c88c1d166e17a3a364e2c167
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  835029 
Reviewed-on: https://chromium-review.googlesource.com/1102197
Cr-Commit-Position: refs/heads/master@{#567545}
[modify] https://crrev.com/245e6851691bb57570d6e862eab0237be166f9d2/chrome/browser/chromeos/arc/arc_session_manager.cc
[modify] https://crrev.com/245e6851691bb57570d6e862eab0237be166f9d2/chrome/browser/chromeos/arc/arc_session_manager.h
[modify] https://crrev.com/245e6851691bb57570d6e862eab0237be166f9d2/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/245e6851691bb57570d6e862eab0237be166f9d2/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
[modify] https://crrev.com/245e6851691bb57570d6e862eab0237be166f9d2/chrome/browser/ui/app_list/arc/arc_app_utils.cc
[modify] https://crrev.com/245e6851691bb57570d6e862eab0237be166f9d2/chrome/browser/ui/app_list/arc/arc_app_utils.h
[delete] https://crrev.com/c8a271c2b9964bd832b32a9a143f7bf28b658e70/chrome/browser/ui/app_list/arc/arc_fast_app_reinstall_starter.cc
[delete] https://crrev.com/c8a271c2b9964bd832b32a9a143f7bf28b658e70/chrome/browser/ui/app_list/arc/arc_fast_app_reinstall_starter.h
[modify] https://crrev.com/245e6851691bb57570d6e862eab0237be166f9d2/chrome/browser/ui/webui/chromeos/login/recommend_apps_screen_handler.cc
[modify] https://crrev.com/245e6851691bb57570d6e862eab0237be166f9d2/components/arc/arc_prefs.cc
[modify] https://crrev.com/245e6851691bb57570d6e862eab0237be166f9d2/components/arc/arc_prefs.h
[modify] https://crrev.com/245e6851691bb57570d6e862eab0237be166f9d2/components/arc/common/app.mojom
[modify] https://crrev.com/245e6851691bb57570d6e862eab0237be166f9d2/components/arc/test/fake_app_instance.cc
[modify] https://crrev.com/245e6851691bb57570d6e862eab0237be166f9d2/components/arc/test/fake_app_instance.h

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d92f532a523b3a981f725f477789d3567bdfd20c

commit d92f532a523b3a981f725f477789d3567bdfd20c
Author: Yue Cen <rsgingerrs@chromium.org>
Date: Fri Jun 15 19:34:35 2018

Reland: Start Fast App Reinstall flow.

If the user clicks the Install button after ARC++ is provisioned, we should
start the flow right away. If not, we delay the flow until Play Store is ready.

ARC++ changes: ag/4174872

This reverts commit 245e6851691bb57570d6e862eab0237be166f9d2. This CL
fixes the memory leak in the unittest from the original CL
(https://chromium-review.googlesource.com/c/chromium/src/+/1080012).

TBR=alemate@chromium.org, khmel@chromium.org, lhchavez@chromium.org
TBR=yusukes@chromium.org, kerrnel@chromium.org, wzang@chromium.org

Bug:  835029 
Change-Id: Iedeca0ad5abd9033a0472bfeaa67ef818d9584ca
Reviewed-on: https://chromium-review.googlesource.com/1102828
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567764}
[modify] https://crrev.com/d92f532a523b3a981f725f477789d3567bdfd20c/chrome/browser/chromeos/arc/arc_session_manager.cc
[modify] https://crrev.com/d92f532a523b3a981f725f477789d3567bdfd20c/chrome/browser/chromeos/arc/arc_session_manager.h
[modify] https://crrev.com/d92f532a523b3a981f725f477789d3567bdfd20c/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/d92f532a523b3a981f725f477789d3567bdfd20c/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
[modify] https://crrev.com/d92f532a523b3a981f725f477789d3567bdfd20c/chrome/browser/ui/app_list/arc/arc_app_utils.cc
[modify] https://crrev.com/d92f532a523b3a981f725f477789d3567bdfd20c/chrome/browser/ui/app_list/arc/arc_app_utils.h
[add] https://crrev.com/d92f532a523b3a981f725f477789d3567bdfd20c/chrome/browser/ui/app_list/arc/arc_fast_app_reinstall_starter.cc
[add] https://crrev.com/d92f532a523b3a981f725f477789d3567bdfd20c/chrome/browser/ui/app_list/arc/arc_fast_app_reinstall_starter.h
[modify] https://crrev.com/d92f532a523b3a981f725f477789d3567bdfd20c/chrome/browser/ui/webui/chromeos/login/recommend_apps_screen_handler.cc
[modify] https://crrev.com/d92f532a523b3a981f725f477789d3567bdfd20c/components/arc/arc_prefs.cc
[modify] https://crrev.com/d92f532a523b3a981f725f477789d3567bdfd20c/components/arc/arc_prefs.h
[modify] https://crrev.com/d92f532a523b3a981f725f477789d3567bdfd20c/components/arc/common/app.mojom
[modify] https://crrev.com/d92f532a523b3a981f725f477789d3567bdfd20c/components/arc/test/fake_app_instance.cc
[modify] https://crrev.com/d92f532a523b3a981f725f477789d3567bdfd20c/components/arc/test/fake_app_instance.h

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/browser_internal/+/a269c7c7f51b2bb7381e14160e8dba0c4c5902d5

commit a269c7c7f51b2bb7381e14160e8dba0c4c5902d5
Author: Yue Cen <yuecen@google.com>
Date: Wed Jun 20 00:37:45 2018

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/src-internal.git/+/7c2b573628be45199398f14d247482e2333db198

commit 7c2b573628be45199398f14d247482e2333db198
Author: Yue Cen <yuecen@google.com>
Date: Wed Jun 20 00:53:50 2018

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8af579d0b85fad15e57c38cae60fb25474cb27cd

commit 8af579d0b85fad15e57c38cae60fb25474cb27cd
Author: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Jun 20 02:58:46 2018

Roll src-internal 208cf41c691b..7c2b573628be (1 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/208cf41c691b..7c2b573628be


Created with:
  gclient setdep -r src-internal@7c2b573628be

The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:835029 
TBR=mmoss@chromium.org

Change-Id: I6bba577918f109d3f88ca8dfc4315fd17ca0b740
Reviewed-on: https://chromium-review.googlesource.com/1107138
Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#568705}
[modify] https://crrev.com/8af579d0b85fad15e57c38cae60fb25474cb27cd/DEPS

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 20 2018

Is there a Launch bug for this feature?
Blockedon: 860041
Blocking: 862774
Project Member

Comment 16 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0

commit dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0
Author: Yue Cen <rsgingerrs@chromium.org>
Date: Fri Jul 13 22:26:25 2018

Improve the Recommend App screen UI according to the spec.

There is an "App downloading" screen after user chooses to install
the selected packages. The screen is added in this CL.

Bug:  835029 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I8412980e0e1bec0ff1d9257a509f3ccf6bf77c8f
Reviewed-on: https://chromium-review.googlesource.com/1103665
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575094}
[modify] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/chromeos/login/oobe_screen.cc
[modify] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/chromeos/login/oobe_screen.h
[add] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/chromeos/login/screens/app_downloading_screen.cc
[add] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/chromeos/login/screens/app_downloading_screen.h
[add] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/chromeos/login/screens/app_downloading_screen_view.h
[modify] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/chromeos/login/screens/screen_exit_code.cc
[modify] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/chromeos/login/screens/screen_exit_code.h
[modify] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/chromeos/login/wizard_controller.h
[modify] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
[add] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/resources/chromeos/arc_support/images/ic_checkmark.svg
[add] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/resources/chromeos/arc_support/recommend_app_list_view.css
[modify] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/resources/chromeos/arc_support/recommend_app_list_view.html
[modify] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/resources/chromeos/arc_support/recommend_app_list_view.js
[add] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/resources/chromeos/login/app_downloading.css
[add] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/resources/chromeos/login/app_downloading.html
[add] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/resources/chromeos/login/app_downloading.js
[modify] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/resources/chromeos/login/custom_elements_login.html
[modify] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/resources/chromeos/login/custom_elements_login.js
[modify] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/resources/chromeos/login/custom_elements_oobe.html
[modify] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/resources/chromeos/login/custom_elements_oobe.js
[modify] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/resources/chromeos/login/login.js
[modify] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/resources/chromeos/login/login_non_lock_shared.js
[modify] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/resources/chromeos/login/login_screens.html
[modify] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/resources/chromeos/login/md_login.js
[modify] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/resources/chromeos/login/md_login_screens.html
[modify] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/resources/chromeos/login/oobe.js
[modify] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/resources/chromeos/login/oobe_screens.html
[modify] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/resources/chromeos/login/recommend_apps.css
[modify] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/resources/chromeos/login/recommend_apps.html
[add] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/resources/chromeos/login/screen_app_downloading.html
[add] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/resources/chromeos/login/screen_app_downloading.js
[modify] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/resources/chromeos/login/screen_recommend_apps.js
[modify] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/resources/component_extension_resources.grd
[modify] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/ui/webui/chromeos/login/app_downloading_screen_handler.cc
[add] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/ui/webui/chromeos/login/app_downloading_screen_handler.h
[modify] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
[modify] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/ui/webui/chromeos/login/oobe_ui.h
[modify] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/chrome/browser/ui/webui/chromeos/login/recommend_apps_screen_handler.cc
[modify] https://crrev.com/dd3041ab5d6ee1e93bec15155dbbef6ef6a1f3b0/ui/login/display_manager.js

Project Member

Comment 17 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ca4c9c1a9639ef96837b0818b79e97949bfc178

commit 3ca4c9c1a9639ef96837b0818b79e97949bfc178
Author: Yue Cen <rsgingerrs@chromium.org>
Date: Fri Jul 13 23:57:36 2018

Add switch for recommend apps screen in OOBE.

This screen should show after the user accepts ARC terms of service.

Bug:  835029 
Change-Id: Ib17cc71e5c322cbe48fa824c299d5269d30226c1
Reviewed-on: https://chromium-review.googlesource.com/1111334
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575119}
[modify] https://crrev.com/3ca4c9c1a9639ef96837b0818b79e97949bfc178/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/3ca4c9c1a9639ef96837b0818b79e97949bfc178/chromeos/chromeos_switches.cc
[modify] https://crrev.com/3ca4c9c1a9639ef96837b0818b79e97949bfc178/chromeos/chromeos_switches.h

Project Member

Comment 18 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f40b7886f82ea96c75598d6f2a8c2eafbeffc9d

commit 5f40b7886f82ea96c75598d6f2a8c2eafbeffc9d
Author: Yue Cen <rsgingerrs@chromium.org>
Date: Tue Jul 17 22:37:54 2018

Pass server response to generate the app list.

Bug:  835029 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Icbe94f99997fe13758400e26ae29eeeb8bb234b6
Reviewed-on: https://chromium-review.googlesource.com/1103778
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575814}
[modify] https://crrev.com/5f40b7886f82ea96c75598d6f2a8c2eafbeffc9d/chrome/browser/chromeos/login/screens/recommend_apps_screen.cc
[modify] https://crrev.com/5f40b7886f82ea96c75598d6f2a8c2eafbeffc9d/chrome/browser/chromeos/login/screens/recommend_apps_screen.h
[modify] https://crrev.com/5f40b7886f82ea96c75598d6f2a8c2eafbeffc9d/chrome/browser/chromeos/login/screens/recommend_apps_screen_view.h
[modify] https://crrev.com/5f40b7886f82ea96c75598d6f2a8c2eafbeffc9d/chrome/browser/resources/chromeos/arc_support/recommend_app_list_view.js
[modify] https://crrev.com/5f40b7886f82ea96c75598d6f2a8c2eafbeffc9d/chrome/browser/resources/chromeos/login/recommend_apps.js
[modify] https://crrev.com/5f40b7886f82ea96c75598d6f2a8c2eafbeffc9d/chrome/browser/resources/chromeos/login/screen_recommend_apps.html
[modify] https://crrev.com/5f40b7886f82ea96c75598d6f2a8c2eafbeffc9d/chrome/browser/resources/chromeos/login/screen_recommend_apps.js
[modify] https://crrev.com/5f40b7886f82ea96c75598d6f2a8c2eafbeffc9d/chrome/browser/ui/webui/chromeos/login/recommend_apps_screen_handler.cc
[modify] https://crrev.com/5f40b7886f82ea96c75598d6f2a8c2eafbeffc9d/chrome/browser/ui/webui/chromeos/login/recommend_apps_screen_handler.h

Blockedon: 865797
Project Member

Comment 22 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b6e6a5aa56b695f7f0eda502eef2b3c9bcaf2fd

commit 0b6e6a5aa56b695f7f0eda502eef2b3c9bcaf2fd
Author: Yue Cen <rsgingerrs@chromium.org>
Date: Wed Aug 01 19:10:08 2018

Retrieve Play Store version from features JSON.

Bug:  835029 
Change-Id: Ia50091e2e1669f180f4d9eb5860a59a141bc0c4c
Reviewed-on: https://chromium-review.googlesource.com/1150636
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579885}
[modify] https://crrev.com/0b6e6a5aa56b695f7f0eda502eef2b3c9bcaf2fd/components/arc/arc_features_parser.cc
[modify] https://crrev.com/0b6e6a5aa56b695f7f0eda502eef2b3c9bcaf2fd/components/arc/arc_features_parser.h
[modify] https://crrev.com/0b6e6a5aa56b695f7f0eda502eef2b3c9bcaf2fd/components/arc/arc_features_parser_unittest.cc

Project Member

Comment 23 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cea06eb701c6d9f034819268de656076f0750379

commit cea06eb701c6d9f034819268de656076f0750379
Author: Yue Cen <rsgingerrs@chromium.org>
Date: Thu Aug 09 02:21:55 2018

Fast app reinstall: Fix a bug that the scrolling shadow effect did not
show when the page is first loaded.

Bug:  835029 
Change-Id: If48f9d793c23f28b76d010683f48dd4718940742
Reviewed-on: https://chromium-review.googlesource.com/1161549
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581766}
[modify] https://crrev.com/cea06eb701c6d9f034819268de656076f0750379/chrome/browser/resources/chromeos/arc_support/recommend_app_list_view.css
[modify] https://crrev.com/cea06eb701c6d9f034819268de656076f0750379/chrome/browser/resources/chromeos/arc_support/recommend_app_list_view.js
[modify] https://crrev.com/cea06eb701c6d9f034819268de656076f0750379/chrome/browser/resources/chromeos/login/screen_recommend_apps.js

Project Member

Comment 24 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1ca767e5c5fd7376a615bd177876126f4396cd5

commit b1ca767e5c5fd7376a615bd177876126f4396cd5
Author: Yue Cen <rsgingerrs@chromium.org>
Date: Tue Aug 14 18:09:26 2018

Fast app reinstall: Update screen description text.

Bug:  835029 
Change-Id: I16d97c659054f135456131866962d78aa68e18ac
Reviewed-on: https://chromium-review.googlesource.com/1173319
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582976}
[modify] https://crrev.com/b1ca767e5c5fd7376a615bd177876126f4396cd5/chrome/app/chromeos_strings.grdp

Project Member

Comment 25 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07fbaa5def0ce9da4dd8b3b695e92572454a92f2

commit 07fbaa5def0ce9da4dd8b3b695e92572454a92f2
Author: Yue Cen <rsgingerrs@chromium.org>
Date: Wed Aug 15 21:18:28 2018

Convert OOBE Recommend App screen to feature and enable by default.

Bug:  835029 
Change-Id: Ic37a08411a15be5b5fce1b727dbf6ed5e4a22c65
Reviewed-on: https://chromium-review.googlesource.com/1174980
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583399}
[modify] https://crrev.com/07fbaa5def0ce9da4dd8b3b695e92572454a92f2/chrome/browser/about_flags.cc
[modify] https://crrev.com/07fbaa5def0ce9da4dd8b3b695e92572454a92f2/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/07fbaa5def0ce9da4dd8b3b695e92572454a92f2/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/07fbaa5def0ce9da4dd8b3b695e92572454a92f2/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/07fbaa5def0ce9da4dd8b3b695e92572454a92f2/chrome/common/chrome_features.cc
[modify] https://crrev.com/07fbaa5def0ce9da4dd8b3b695e92572454a92f2/chrome/common/chrome_features.h
[modify] https://crrev.com/07fbaa5def0ce9da4dd8b3b695e92572454a92f2/chromeos/chromeos_switches.cc
[modify] https://crrev.com/07fbaa5def0ce9da4dd8b3b695e92572454a92f2/chromeos/chromeos_switches.h
[modify] https://crrev.com/07fbaa5def0ce9da4dd8b3b695e92572454a92f2/tools/metrics/histograms/enums.xml

Project Member

Comment 26 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c7a2479fd40ad71807b9da9095afca5f7c79662

commit 3c7a2479fd40ad71807b9da9095afca5f7c79662
Author: Yue Cen <rsgingerrs@chromium.org>
Date: Wed Aug 15 23:03:58 2018

Fast app reinstall: Disable selecting of Recommend apps screen chips.

Bug:  835029 
Change-Id: Ia7a73145c3d4840bd73db80170bc7eafef24ca8f
Reviewed-on: https://chromium-review.googlesource.com/1173067
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583432}
[modify] https://crrev.com/3c7a2479fd40ad71807b9da9095afca5f7c79662/chrome/browser/resources/chromeos/arc_support/recommend_app_list_view.css

Project Member

Comment 27 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70ef44d5edd39941cc7d75eaa6177d80f428d96f

commit 70ef44d5edd39941cc7d75eaa6177d80f428d96f
Author: Yue Cen <rsgingerrs@chromium.org>
Date: Thu Aug 16 00:42:28 2018

Fast app reinstall: Add video in the app downloading screen

Bug:  835029 
Change-Id: Ie39c2ab0956f01ce51bdf1e2fa0e8de30de51160
Reviewed-on: https://chromium-review.googlesource.com/1144272
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583470}
[modify] https://crrev.com/70ef44d5edd39941cc7d75eaa6177d80f428d96f/chrome/browser/resources/chromeos/login/app_downloading.css
[modify] https://crrev.com/70ef44d5edd39941cc7d75eaa6177d80f428d96f/chrome/browser/resources/chromeos/login/app_downloading.html

Project Member

Comment 28 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13efb512319a32e0683842513363462cee7c520c

commit 13efb512319a32e0683842513363462cee7c520c
Author: Yue Cen <rsgingerrs@chromium.org>
Date: Wed Aug 22 17:25:11 2018

Retrieve device config info.

In order to get the list of Android apps from Play, we need to retrieve
and send the device config (such as touchscreen type, screen density,
etc.). This info is required by the Play server to filter apps. This
operation is usually done by the Play Store client. But since ARC is not
provisioned at the recommend-apps screen, Chrome must send this info.

device_configuration.proto is used to encode the device config info. The
message content is identical to the one on Play side.

This CL also moves the network request into a separate class.

Bug:  835029 
Change-Id: I2796fe9411bc92aea49bfdde58f674e0e5539980
Reviewed-on: https://chromium-review.googlesource.com/1107100
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585129}
[modify] https://crrev.com/13efb512319a32e0683842513363462cee7c520c/chrome/browser/chromeos/BUILD.gn
[add] https://crrev.com/13efb512319a32e0683842513363462cee7c520c/chrome/browser/chromeos/login/screens/recommend_apps/device_configuration.proto
[add] https://crrev.com/13efb512319a32e0683842513363462cee7c520c/chrome/browser/chromeos/login/screens/recommend_apps/recommend_apps_fetcher.cc
[add] https://crrev.com/13efb512319a32e0683842513363462cee7c520c/chrome/browser/chromeos/login/screens/recommend_apps/recommend_apps_fetcher.h
[modify] https://crrev.com/13efb512319a32e0683842513363462cee7c520c/chrome/browser/chromeos/login/screens/recommend_apps_screen.cc
[modify] https://crrev.com/13efb512319a32e0683842513363462cee7c520c/chrome/browser/chromeos/login/screens/recommend_apps_screen.h
[modify] https://crrev.com/13efb512319a32e0683842513363462cee7c520c/chrome/browser/chromeos/login/screens/recommend_apps_screen_view.h
[modify] https://crrev.com/13efb512319a32e0683842513363462cee7c520c/chrome/browser/ui/webui/chromeos/login/recommend_apps_screen_handler.cc
[modify] https://crrev.com/13efb512319a32e0683842513363462cee7c520c/chrome/browser/ui/webui/chromeos/login/recommend_apps_screen_handler.h
[modify] https://crrev.com/13efb512319a32e0683842513363462cee7c520c/chrome/common/chrome_features.cc
[modify] https://crrev.com/13efb512319a32e0683842513363462cee7c520c/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/13efb512319a32e0683842513363462cee7c520c/tools/metrics/histograms/histograms.xml

Project Member

Comment 29 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5728f6867e006925d782ea215f249b6546319941

commit 5728f6867e006925d782ea215f249b6546319941
Author: Yue Cen <rsgingerrs@chromium.org>
Date: Fri Aug 24 23:31:49 2018

Fast app reinstall: Explicitly use https for the API URL.

Bug:  835029 
Change-Id: I6b483f66203120d3684c0da6ba29bf9997116cee
Reviewed-on: https://chromium-review.googlesource.com/1164251
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586050}
[modify] https://crrev.com/5728f6867e006925d782ea215f249b6546319941/chrome/browser/chromeos/login/screens/recommend_apps/recommend_apps_fetcher.cc

Project Member

Comment 30 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec3c8d2000a5b1ccc4aaf0e4ae4c64785db3b41d

commit ec3c8d2000a5b1ccc4aaf0e4ae4c64785db3b41d
Author: Yue Cen <rsgingerrs@chromium.org>
Date: Thu Aug 30 01:34:33 2018

Turn on fast app reinstall feature by default.

Bug:  835029 
Change-Id: I8d6639672ce9659dbb97722b58d1b2bcfb21c342
Reviewed-on: https://chromium-review.googlesource.com/1195715
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587384}
[modify] https://crrev.com/ec3c8d2000a5b1ccc4aaf0e4ae4c64785db3b41d/chrome/common/chrome_features.cc

Project Member

Comment 31 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d00d1e7a32edad2728b209419f6b129df97fb1f

commit 3d00d1e7a32edad2728b209419f6b129df97fb1f
Author: Yue Cen <rsgingerrs@chromium.org>
Date: Thu Aug 30 20:31:42 2018

Fast app reinstall: UI tweaks.

Specs based on b/112928364 and b/112934458.

Bug:  835029 
Change-Id: I58deccbbbd83a385407d02e208db3f112bed1fc6
Reviewed-on: https://chromium-review.googlesource.com/1188594
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587742}
[modify] https://crrev.com/3d00d1e7a32edad2728b209419f6b129df97fb1f/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/3d00d1e7a32edad2728b209419f6b129df97fb1f/chrome/browser/resources/chromeos/arc_support/recommend_app_list_view.css
[modify] https://crrev.com/3d00d1e7a32edad2728b209419f6b129df97fb1f/chrome/browser/resources/chromeos/login/app_downloading.css
[modify] https://crrev.com/3d00d1e7a32edad2728b209419f6b129df97fb1f/chrome/browser/resources/chromeos/login/app_downloading.html
[modify] https://crrev.com/3d00d1e7a32edad2728b209419f6b129df97fb1f/chrome/browser/resources/chromeos/login/app_downloading.js
[modify] https://crrev.com/3d00d1e7a32edad2728b209419f6b129df97fb1f/chrome/browser/resources/chromeos/login/recommend_apps.css
[modify] https://crrev.com/3d00d1e7a32edad2728b209419f6b129df97fb1f/chrome/browser/resources/chromeos/login/screen_app_downloading.js
[modify] https://crrev.com/3d00d1e7a32edad2728b209419f6b129df97fb1f/chrome/browser/ui/webui/chromeos/login/app_downloading_screen_handler.cc
[modify] https://crrev.com/3d00d1e7a32edad2728b209419f6b129df97fb1f/chrome/browser/ui/webui/chromeos/login/recommend_apps_screen_handler.cc

Project Member

Comment 32 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e89e923b524d79118065947f81634d2734f64701

commit e89e923b524d79118065947f81634d2734f64701
Author: Yue Cen <rsgingerrs@chromium.org>
Date: Thu Aug 30 22:37:39 2018

Fast app reinstall: Add more metrics.

The new metrics are as follows:
- The number of apps user selected.
- The ratio of selected and recommended apps.
- Whether the reocmmend apps screen is shown.
- The user action on the recommend apps screen.

Bug:  835029 
Change-Id: Ibdb3e14d1405693f9569bf4e6161027ce3fd7fbc
Reviewed-on: https://chromium-review.googlesource.com/1196037
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587816}
[modify] https://crrev.com/e89e923b524d79118065947f81634d2734f64701/chrome/browser/ui/webui/chromeos/login/recommend_apps_screen_handler.cc
[modify] https://crrev.com/e89e923b524d79118065947f81634d2734f64701/chrome/browser/ui/webui/chromeos/login/recommend_apps_screen_handler.h
[modify] https://crrev.com/e89e923b524d79118065947f81634d2734f64701/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/e89e923b524d79118065947f81634d2734f64701/tools/metrics/histograms/histograms.xml

Labels: Merge-Request-70
We would like to merge the CLs in comments #32 and #33 into M70.
Project Member

Comment 35 by sheriffbot@chromium.org, Sep 12

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 33 days from stable.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Re comment#35:

I understand that this might be an auto-generated message. But I would like to clarify to the reviewer that the CLs in comments #32 and #33 do not contain .grd file.
Cc: geohsu@chromium.org
geohsu, +josafat, anything we need to do to get this fix merged?
Cc: josa...@chromium.org
+josafat for real
Blockedon: 885219
Labels: M-70
+geo (M70 TPM)  to review merge here
Project Member

Comment 42 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f76c19a89bc23d5dc8d2ac28bd56515658b3a524

commit f76c19a89bc23d5dc8d2ac28bd56515658b3a524
Author: Yue Cen <rsgingerrs@chromium.org>
Date: Wed Sep 19 21:27:09 2018

Disable fast app reinstall feature for M70

The plan is to ship the feature in M71. This CL will be merge to M70 and
reverted in M71.

Bug:  835029 
Change-Id: I741c60ccbff2570a07fc9c3535b0acea6efa1ed8
Reviewed-on: https://chromium-review.googlesource.com/1234966
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592550}
[modify] https://crrev.com/f76c19a89bc23d5dc8d2ac28bd56515658b3a524/chrome/common/chrome_features.cc

Cc: zalcorn@chromium.org
As zalcorn@ mentioned in another email thread, we no longer need to merge #32 and #33 in M70. Instead, we would like to request a merge for the CL in comment #42.
Project Member

Comment 44 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb13f0348775e22a1aa1fc396b3c958a2315a0d2

commit cb13f0348775e22a1aa1fc396b3c958a2315a0d2
Author: Yue Cen <rsgingerrs@chromium.org>
Date: Wed Sep 19 23:08:40 2018

Revert "Disable fast app reinstall feature for M70"

This reverts commit f76c19a89bc23d5dc8d2ac28bd56515658b3a524.

Reason for revert: Re-enable in M71

Original change's description:
> Disable fast app reinstall feature for M70
> 
> The plan is to ship the feature in M71. This CL will be merge to M70 and
> reverted in M71.
> 
> Bug:  835029 
> Change-Id: I741c60ccbff2570a07fc9c3535b0acea6efa1ed8
> Reviewed-on: https://chromium-review.googlesource.com/1234966
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592550}

TBR=xiyuan@chromium.org,rsgingerrs@chromium.org
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  835029 

Change-Id: Ib83098f9d8f57d5325c10e9bc3ca7c6f46adb0dd
Reviewed-on: https://chromium-review.googlesource.com/1235126
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592593}
[modify] https://crrev.com/cb13f0348775e22a1aa1fc396b3c958a2315a0d2/chrome/common/chrome_features.cc

Project Member

Comment 45 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31edfccdfb418dfb5374b6bc1bc10dcc6ab5b64e

commit 31edfccdfb418dfb5374b6bc1bc10dcc6ab5b64e
Author: Yue Cen <rsgingerrs@chromium.org>
Date: Mon Sep 24 19:45:40 2018

Fast app reinstall: Add a switch to force show the screen

Normally the recommend-apps screen is only shown to first-time
Chromebook users. Adding this switch to skip the check so that testers
can reuse the same accounts for testing.

Bug:  835029 
Change-Id: I61b1bef40e4b64f22f3890c64e24d3887a86b977
Reviewed-on: https://chromium-review.googlesource.com/1239249
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593641}
[modify] https://crrev.com/31edfccdfb418dfb5374b6bc1bc10dcc6ab5b64e/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/31edfccdfb418dfb5374b6bc1bc10dcc6ab5b64e/chromeos/chromeos_switches.cc
[modify] https://crrev.com/31edfccdfb418dfb5374b6bc1bc10dcc6ab5b64e/chromeos/chromeos_switches.h

Labels: -Merge-Review-70 Merge-Approved-70
Labels: -Merge-Approved-70 Merge-Merged-70-3538
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/45bb9ee466f76bc4b1d2a7302107e2839ac7b840

Commit: 45bb9ee466f76bc4b1d2a7302107e2839ac7b840
Author: rsgingerrs@chromium.org
Commiter: wzang@chromium.org
Date: 2018-09-24 21:22:44 +0000 UTC

[Merge to M70] Disable fast app reinstall feature for M70

The plan is to ship the feature in M71. This CL will be merge to M70 and
reverted in M71.

TBR=rsgingerrs@chromium.org

(cherry picked from commit f76c19a89bc23d5dc8d2ac28bd56515658b3a524)

Bug:  835029 
Change-Id: I741c60ccbff2570a07fc9c3535b0acea6efa1ed8
Reviewed-on: https://chromium-review.googlesource.com/1234966
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#592550}
Reviewed-on: https://chromium-review.googlesource.com/1241277
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#603}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
Project Member

Comment 48 by bugdroid1@chromium.org, Sep 24

Labels: merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45bb9ee466f76bc4b1d2a7302107e2839ac7b840

commit 45bb9ee466f76bc4b1d2a7302107e2839ac7b840
Author: Yue Cen <rsgingerrs@chromium.org>
Date: Mon Sep 24 21:22:44 2018

[Merge to M70] Disable fast app reinstall feature for M70

The plan is to ship the feature in M71. This CL will be merge to M70 and
reverted in M71.

TBR=rsgingerrs@chromium.org

(cherry picked from commit f76c19a89bc23d5dc8d2ac28bd56515658b3a524)

Bug:  835029 
Change-Id: I741c60ccbff2570a07fc9c3535b0acea6efa1ed8
Reviewed-on: https://chromium-review.googlesource.com/1234966
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#592550}
Reviewed-on: https://chromium-review.googlesource.com/1241277
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#603}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/45bb9ee466f76bc4b1d2a7302107e2839ac7b840/chrome/common/chrome_features.cc

Project Member

Comment 49 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b2e5af171ca2ff99312961eccfe514bdebafa28

commit 2b2e5af171ca2ff99312961eccfe514bdebafa28
Author: Yue Cen <rsgingerrs@chromium.org>
Date: Mon Oct 01 22:10:22 2018

Fast app reinstall: Remove first-time Chromebook user check

I created a syncable pref in crrev.com/c/1213521 to check if a user has
gone through OOBE before. Now that the server side will conduct the
check so the syncable pref is no longer necessary.

Please see b/114134918 for more details.

Bug:  835029 
Change-Id: Iab53007458ecd4f42915571fba96c91b894625a5
Reviewed-on: https://chromium-review.googlesource.com/1252851
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595566}
[modify] https://crrev.com/2b2e5af171ca2ff99312961eccfe514bdebafa28/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/2b2e5af171ca2ff99312961eccfe514bdebafa28/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/2b2e5af171ca2ff99312961eccfe514bdebafa28/chrome/browser/ui/webui/chromeos/login/recommend_apps_screen_handler.cc
[modify] https://crrev.com/2b2e5af171ca2ff99312961eccfe514bdebafa28/chrome/common/pref_names.cc
[modify] https://crrev.com/2b2e5af171ca2ff99312961eccfe514bdebafa28/chrome/common/pref_names.h
[modify] https://crrev.com/2b2e5af171ca2ff99312961eccfe514bdebafa28/chromeos/chromeos_switches.cc
[modify] https://crrev.com/2b2e5af171ca2ff99312961eccfe514bdebafa28/chromeos/chromeos_switches.h

Project Member

Comment 50 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3dfc4f453b91a251c207465b39f1acf42ca599bb

commit 3dfc4f453b91a251c207465b39f1acf42ca599bb
Author: Yue Cen <rsgingerrs@chromium.org>
Date: Wed Oct 10 01:13:00 2018

Fast app reinstall: Handle error message from the response

Previously the API used code 500 to indicate server errors. Now it
returns an error string instead (cl/214360695).

Bug:  835029 
Change-Id: I448ff52d5388c3d12fd19b3604a0061172c8f483
Reviewed-on: https://chromium-review.googlesource.com/c/1252768
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598161}
[modify] https://crrev.com/3dfc4f453b91a251c207465b39f1acf42ca599bb/chrome/browser/chromeos/login/screens/recommend_apps/recommend_apps_fetcher.cc
[modify] https://crrev.com/3dfc4f453b91a251c207465b39f1acf42ca599bb/tools/metrics/histograms/enums.xml

Blockedon: 900736
Blockedon: 900793
Status: Fixed (was: Assigned)

Sign in to add a comment