New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 835022 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 810595
Owner: ----
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Indirect-leak in mojo::internal::InterfacePtrStateBase::InitializeEndpointClient

Project Member Reported by ClusterFuzz, Apr 19 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6658458179600384

Fuzzer: marty_html_twiddler
Job Type: linux_lsan_chrome_mp
Platform Id: linux

Crash Type: Indirect-leak
Crash Address: 
Crash State:
  mojo::internal::InterfacePtrStateBase::InitializeEndpointClient
  mojo::internal::InterfacePtrState<ukm::mojom::UkmRecorderInterface>::ConfigurePr
  instance
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_lsan_chrome_mp&range=548270:548271

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6658458179600384

Additional requirements: Requires Gestures

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Apr 19 2018

Components: Internals>Mojo
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Apr 19 2018

Labels: Test-Predator-Auto-Owner
Owner: sky@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/d91fc17c7b59e367a6f9364de3a48d62adbf0f38 (wayland: test style nits).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.

Comment 3 by sky@chromium.org, Apr 23 2018

Cc: roc...@chromium.org holte@chromium.org
Owner: ----
Status: Available (was: Assigned)
The clusterfuzz report shows the leak is allocated here:

	#0 0x55b8dcbd7b92 in operator new(unsigned long) third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:93:3
 #1 0x55b8e67752e6 in mojo::internal::InterfacePtrStateBase::InitializeEndpointClient(bool, bool, std::__1::unique_ptr<mojo::MessageReceiver, std::__1::default_delete<mojo::MessageReceiver> >) mojo/public/cpp/bindings/lib/interface_ptr_state.cc:83:13
     #2 0x55b8e682ae95 in mojo::internal::InterfacePtrState<ukm::mojom::UkmRecorderInterface>::ConfigureProxyIfNecessary() mojo/public/cpp/bindings/lib/interface_ptr_state.h:210:9
     #3 0x55b8e682a677 in instance mojo/public/cpp/bindings/lib/interface_ptr_state.h:113:5
    #4 0x55b8e682a677 in get mojo/public/cpp/bindings/interface_ptr.h:97
    #5 0x55b8e682a677 in operator-> mojo/public/cpp/bindings/interface_ptr.h:100
    #6 0x55b8e682a677 in ukm::MojoUkmRecorder::UpdateSourceURL(long, GURL const&) services/metrics/public/cpp/mojo_ukm_recorder.cc:32
    #7 0x55b8eefd53cd in blink::Document::UkmRecorder() third_party/blink/renderer/core/dom/document.cc:6003:20
    #8 0x55b8f0f3bd89 in blink::LocalFrameView::EnsureUkmTimeAggregator() third_party/blink/renderer/core/frame/local_frame_view.cc:5899:32
    #9 0x55b8f0f3aec2 in blink::LocalFrameView::UpdateStyleAndLayoutIfNeededRecursive() third_party/blink/renderer/core/frame/local_frame_view.cc:3497:3
    #10 0x55b8f0f37aac in blink::LocalFrameView::UpdateLifecyclePhasesInternal(blink::DocumentLifecycle::LifecycleState) third_party/blink/renderer/core/frame/local_frame_view.cc:3226:3

Which is in the renderer. My patch didn't touch this code. I suspect the leak is likely in the renderer/blink, and not in mojo itself. I'm removing myself as an owner.
+holte for MojoUkmRecorder
+rockot for general mojo expertise.

Comment 4 by roc...@chromium.org, Apr 23 2018

Mergedinto: 810595
Status: Duplicate (was: Available)
Project Member

Comment 5 by ClusterFuzz, May 17 2018

ClusterFuzz has detected this issue as fixed in range 559375:559378.

Detailed report: https://clusterfuzz.com/testcase?key=6658458179600384

Fuzzer: marty_html_twiddler
Job Type: linux_lsan_chrome_mp
Platform Id: linux

Crash Type: Indirect-leak
Crash Address: 
Crash State:
  mojo::internal::InterfacePtrStateBase::InitializeEndpointClient
  mojo::internal::InterfacePtrState<ukm::mojom::UkmRecorderInterface>::ConfigurePr
  instance
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_lsan_chrome_mp&range=548270:548271
Fixed: https://clusterfuzz.com/revisions?job=linux_lsan_chrome_mp&range=559375:559378

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6658458179600384

Additional requirements: Requires Gestures

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
 Issue 847708  has been merged into this issue.

Sign in to add a comment