Issue metadata
Sign in to add a comment
|
Regression: Autofill flyout interferes with field entry when NativeDropdownViews is enabled. |
||||||||||||||||||||||
Issue descriptionChrome Version: 68.0.3400.0 OS: Windows 10 What steps will reproduce the problem? (1) Visit https://bayden.com/sandbox/FileForm.asp or another page with forms that can be autofill (2) Enter some garbage in the form and submit it so that you get autofill entries (3) Start typing in the form so that you get an autofill entry OBSERVE: Cannot visibly click into the form field. Cannot select text, etc, without first clicking into the page, then clicking back into the field. This is a recent regression, suspect it landed last night.
,
Apr 19 2018
Sorry I'll try to get a video. I was planning to bisect but the script appears to be broken at the moment. The general idea is that in the attached screenshot my mouse cursor is over the text field but clicking has no visible effect -- there's no caret, no selection color when I try to highlight, Etc
,
Apr 20 2018
I believe this regression was caused by the change to chrome://flags/#enable-autofill-native-dropdown-views. The difference is that when NativeDropdownViews are enabled, it's possible to move the mouse cursor out of the area of the dropdown without clearing its selected item (e.g. hover over a dropdown item and drag your mouse to the right side, out of the hover area). In contrast, when NativeDropdownViews are disabled, as soon as you move the mouse out of the area of the dropdown, it no longer has a selected item, the field goes white, and you can freely interact with the text field.
,
Apr 20 2018
You can see the working behavior in the "Working" video and the broken behavior at 0:34s in the "Broken" video.
,
Apr 20 2018
Thanks for the video! It's definitely an issue due to the new dropdown view. Assigning to tmartino@ to debug.
,
May 23 2018
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a696acb61f4ad0931ad22de4a50a703facc8374 commit 4a696acb61f4ad0931ad22de4a50a703facc8374 Author: Fabio Tirelo <ftirelo@chromium.org> Date: Mon Jun 04 12:49:48 2018 [af] Do not clear autofill selection if no suggestion is selected This fixes crbug.com/835019 , in which the current suggestion may not be cleared when the mouse exits the popup area, by reusing the OnMouseExited handler implemented by AutofillPopupBaseView and overriden by AutofillPopupViewNativeViews as empty. The current implementation posts a task that will be a no-op if the mouse leaves the popup and there is no suggestion selected, so this is a safe change. Bug: 835019 Change-Id: Iee65e18e8d9c020e99ed2f0ed8d6643573ae6950 Reviewed-on: https://chromium-review.googlesource.com/1070788 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Rachel Blum <groby@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#564070} [modify] https://crrev.com/4a696acb61f4ad0931ad22de4a50a703facc8374/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc [modify] https://crrev.com/4a696acb61f4ad0931ad22de4a50a703facc8374/chrome/browser/ui/autofill/autofill_popup_controller_impl.h [modify] https://crrev.com/4a696acb61f4ad0931ad22de4a50a703facc8374/chrome/browser/ui/autofill/autofill_popup_layout_model_unittest.cc [modify] https://crrev.com/4a696acb61f4ad0931ad22de4a50a703facc8374/chrome/browser/ui/autofill/autofill_popup_view_delegate.h [modify] https://crrev.com/4a696acb61f4ad0931ad22de4a50a703facc8374/chrome/browser/ui/cocoa/autofill/credit_card_autofill_touch_bar_controller_unittest.mm [modify] https://crrev.com/4a696acb61f4ad0931ad22de4a50a703facc8374/chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa_unittest.mm [modify] https://crrev.com/4a696acb61f4ad0931ad22de4a50a703facc8374/chrome/browser/ui/passwords/password_generation_popup_controller_impl.cc [modify] https://crrev.com/4a696acb61f4ad0931ad22de4a50a703facc8374/chrome/browser/ui/passwords/password_generation_popup_controller_impl.h [modify] https://crrev.com/4a696acb61f4ad0931ad22de4a50a703facc8374/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc [modify] https://crrev.com/4a696acb61f4ad0931ad22de4a50a703facc8374/chrome/browser/ui/views/autofill/autofill_popup_base_view_browsertest.cc [modify] https://crrev.com/4a696acb61f4ad0931ad22de4a50a703facc8374/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.h [modify] https://crrev.com/4a696acb61f4ad0931ad22de4a50a703facc8374/chrome/browser/ui/views/autofill/autofill_popup_view_native_views_unittest.cc [modify] https://crrev.com/4a696acb61f4ad0931ad22de4a50a703facc8374/chrome/browser/ui/views/autofill/autofill_popup_view_views_browsertest.cc
,
Jun 4 2018
,
Jun 4 2018
Asking for merge request to M68, since this is a bug fix. Since this has just landed, I will let it run on canary for a few days before actually merging to the branch.
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c7c5adf9491a9afbe2aec904a0b2ce7175b64675 commit c7c5adf9491a9afbe2aec904a0b2ce7175b64675 Author: Dominic Battré <battre@chromium.org> Date: Mon Jun 04 14:49:47 2018 Revert "[af] Do not clear autofill selection if no suggestion is selected" This reverts commit 4a696acb61f4ad0931ad22de4a50a703facc8374. Reason for revert: Crashes on ChromeOS, see bug for details. Original change's description: > [af] Do not clear autofill selection if no suggestion is selected > > This fixes crbug.com/835019 , in which the current suggestion may not > be cleared when the mouse exits the popup area, by reusing the > OnMouseExited handler implemented by AutofillPopupBaseView and > overriden by AutofillPopupViewNativeViews as empty. > > The current implementation posts a task that will be a no-op if the > mouse leaves the popup and there is no suggestion selected, so this > is a safe change. > > Bug: 835019 > Change-Id: Iee65e18e8d9c020e99ed2f0ed8d6643573ae6950 > Reviewed-on: https://chromium-review.googlesource.com/1070788 > Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> > Reviewed-by: Rachel Blum <groby@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564070} TBR=pkasting@chromium.org,vasilii@chromium.org,groby@chromium.org,estade@chromium.org,sebsg@chromium.org,ftirelo@chromium.org Change-Id: Id82adc292ee2fe8486f53ee2bebea01d1b973ccb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 835019 Reviewed-on: https://chromium-review.googlesource.com/1085347 Reviewed-by: Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#564088} [modify] https://crrev.com/c7c5adf9491a9afbe2aec904a0b2ce7175b64675/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc [modify] https://crrev.com/c7c5adf9491a9afbe2aec904a0b2ce7175b64675/chrome/browser/ui/autofill/autofill_popup_controller_impl.h [modify] https://crrev.com/c7c5adf9491a9afbe2aec904a0b2ce7175b64675/chrome/browser/ui/autofill/autofill_popup_layout_model_unittest.cc [modify] https://crrev.com/c7c5adf9491a9afbe2aec904a0b2ce7175b64675/chrome/browser/ui/autofill/autofill_popup_view_delegate.h [modify] https://crrev.com/c7c5adf9491a9afbe2aec904a0b2ce7175b64675/chrome/browser/ui/cocoa/autofill/credit_card_autofill_touch_bar_controller_unittest.mm [modify] https://crrev.com/c7c5adf9491a9afbe2aec904a0b2ce7175b64675/chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa_unittest.mm [modify] https://crrev.com/c7c5adf9491a9afbe2aec904a0b2ce7175b64675/chrome/browser/ui/passwords/password_generation_popup_controller_impl.cc [modify] https://crrev.com/c7c5adf9491a9afbe2aec904a0b2ce7175b64675/chrome/browser/ui/passwords/password_generation_popup_controller_impl.h [modify] https://crrev.com/c7c5adf9491a9afbe2aec904a0b2ce7175b64675/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc [modify] https://crrev.com/c7c5adf9491a9afbe2aec904a0b2ce7175b64675/chrome/browser/ui/views/autofill/autofill_popup_base_view_browsertest.cc [modify] https://crrev.com/c7c5adf9491a9afbe2aec904a0b2ce7175b64675/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.h [modify] https://crrev.com/c7c5adf9491a9afbe2aec904a0b2ce7175b64675/chrome/browser/ui/views/autofill/autofill_popup_view_native_views_unittest.cc [modify] https://crrev.com/c7c5adf9491a9afbe2aec904a0b2ce7175b64675/chrome/browser/ui/views/autofill/autofill_popup_view_views_browsertest.cc
,
Jun 4 2018
This breaks All/AutofillInteractiveIsolationTest.DeletingFrameUnderSuggestion/0 All/AutofillInteractiveIsolationTest.SimpleCrossSiteFill/0 on Chrome OS https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8944647127327017712%2F%2B%2Fsteps%2Finteractive_ui_tests%2F0%2Flogs%2FAll__x2f_AutofillInteractiveIsolationTest.SimpleCrossSiteFill__x2f_0%2F0 [ RUN ] All/AutofillInteractiveIsolationTest.SimpleCrossSiteFill/0 [28004:28004:0604/060531.986669:WARNING:chrome_browser_main_chromeos.cc(586)] Running as stub user with profile dir: test-user [28004:28004:0604/060532.060290:INFO:remote_commands_service.cc(36)] Fetching remote commands. [28004:28004:0604/060532.060344:WARNING:remote_commands_service.cc(38)] Client is not registered. [28004:28004:0604/060532.060360:INFO:remote_commands_invalidator.cc(32)] Initialize RemoteCommandsInvalidator. [28004:28004:0604/060532.060371:INFO:remote_commands_invalidator.cc(57)] Starting RemoteCommandsInvalidator. [28004:28004:0604/060532.060382:INFO:remote_commands_invalidator.cc(123)] RemoteCommandsInvalidator ReloadPolicyData. [28004:28004:0604/060532.060391:INFO:remote_commands_invalidator.cc(167)] Unregister RemoteCommandsInvalidator. ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default [28004:28030:0604/060532.103757:WARNING:alsa_util.cc(24)] PcmOpen: default,No such file or directory ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default [28004:28030:0604/060532.103865:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory [28004:28088:0604/060532.228023:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x0000030045ac base::debug::StackTrace::StackTrace() #1 0x0000029a2745 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7fd0326fdcb0 <unknown> #3 0x000004f0370b autofill::AutofillPopupBaseView::OnMouseExited() #4 0x000003472484 ui::EventDispatcher::ProcessEvent() #5 0x0000034722cf ui::EventDispatcherDelegate::DispatchEvent() #6 0x000002e0eaf5 views::internal::RootView::OnMouseExited() #7 0x000003472484 ui::EventDispatcher::ProcessEvent() #8 0x0000034722cf ui::EventDispatcherDelegate::DispatchEvent() #9 0x000003e14166 aura::WindowEventDispatcher::DispatchMouseEnterOrExit() #10 0x000003e149de aura::WindowEventDispatcher::DispatchMouseExitToHidingWindow() #11 0x000003e0f3c4 aura::Window::SetVisible() #12 0x000002e22d8e views::NativeWidgetAura::Close() #13 0x000002e11712 views::Widget::Close() #14 0x000004f03e29 autofill::AutofillPopupViewViews::Hide() #15 0x000004e739be autofill::AutofillPopupControllerImpl::Hide() #16 0x000004c2d572 autofill::ChromeAutofillClient::HideAutofillPopup() #17 0x0000042eb166 autofill::AutofillExternalDelegate::DidAcceptSuggestion() #18 0x000004e73a94 autofill::AutofillPopupControllerImpl::AcceptSelectedLine() #19 0x0000013cb70f content::RenderWidgetHostImpl::ForwardKeyboardEventWithCommands() #20 0x0000013cb604 content::RenderWidgetHostImpl::ForwardKeyboardEvent() #21 0x00000048d372 autofill::AutofillInteractiveTestBase::SendKeyToPopupAndWait() #22 0x00000048220e autofill::AutofillInteractiveIsolationTest_SimpleCrossSiteFill_Test::RunTestOnMainThread() #23 0x0000029a24a3 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #24 0x000002644cfe ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #25 0x000002643c6a ChromeBrowserMainParts::PreMainMessageLoopRun() #26 0x000001a8189f chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #27 0x000001123351 content::BrowserMainLoop::PreMainMessageLoopRun() #28 0x00000147c0a7 content::StartupTaskRunner::RunAllTasksNow() #29 0x000001121d02 content::BrowserMainLoop::CreateStartupTasks() #30 0x000001125665 content::BrowserMainRunnerImpl::Initialize() #31 0x00000111fc1c content::BrowserMain() #32 0x00000261a5ea content::ContentMainRunnerImpl::Run() #33 0x000003fa0aaf service_manager::Main() #34 0x0000026187e4 content::ContentMain() #35 0x0000029a20bf content::BrowserTestBase::SetUp() #36 0x000002635496 InProcessBrowserTest::SetUp() #37 0x00000076574d testing::Test::Run() #38 0x000000766370 testing::TestInfo::Run() #39 0x000000766887 testing::TestCase::Run() #40 0x000000771d67 testing::internal::UnitTestImpl::RunAllTests() #41 0x0000007718dd testing::UnitTest::Run() #42 0x000002f7c5a1 base::TestSuite::Run() #43 0x000000586073 InteractiveUITestSuiteRunner::RunTestSuite() #44 0x0000029a9589 content::LaunchTests() #45 0x00000262fde3 LaunchChromeTests() #46 0x000000585ffd main #47 0x7fd0326e8f45 __libc_start_main #48 0x00000044414a _start [ RUN ] All/AutofillInteractiveIsolationTest.DeletingFrameUnderSuggestion/0 [26006:26006:0604/060533.720345:WARNING:chrome_browser_main_chromeos.cc(586)] Running as stub user with profile dir: test-user [26006:26006:0604/060533.792031:INFO:remote_commands_service.cc(36)] Fetching remote commands. [26006:26006:0604/060533.792106:WARNING:remote_commands_service.cc(38)] Client is not registered. [26006:26006:0604/060533.792122:INFO:remote_commands_invalidator.cc(32)] Initialize RemoteCommandsInvalidator. [26006:26006:0604/060533.792135:INFO:remote_commands_invalidator.cc(57)] Starting RemoteCommandsInvalidator. [26006:26006:0604/060533.792146:INFO:remote_commands_invalidator.cc(123)] RemoteCommandsInvalidator ReloadPolicyData. [26006:26006:0604/060533.792157:INFO:remote_commands_invalidator.cc(167)] Unregister RemoteCommandsInvalidator. ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default [26006:26033:0604/060533.827683:WARNING:alsa_util.cc(24)] PcmOpen: default,No such file or directory ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default [26006:26033:0604/060533.827801:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory [26006:26089:0604/060533.979310:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x0000030045ac base::debug::StackTrace::StackTrace() #1 0x0000029a2745 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7fd7783b3cb0 <unknown> #3 0x000004f0370b autofill::AutofillPopupBaseView::OnMouseExited() #4 0x000003472484 ui::EventDispatcher::ProcessEvent() #5 0x0000034722cf ui::EventDispatcherDelegate::DispatchEvent() #6 0x000002e0eaf5 views::internal::RootView::OnMouseExited() #7 0x000003472484 ui::EventDispatcher::ProcessEvent() #8 0x0000034722cf ui::EventDispatcherDelegate::DispatchEvent() #9 0x000003e14166 aura::WindowEventDispatcher::DispatchMouseEnterOrExit() #10 0x000003e149de aura::WindowEventDispatcher::DispatchMouseExitToHidingWindow() #11 0x000003e0f3c4 aura::Window::SetVisible() #12 0x000002e22d8e views::NativeWidgetAura::Close() #13 0x000002e11712 views::Widget::Close() #14 0x000004f03e29 autofill::AutofillPopupViewViews::Hide() #15 0x000004e71f68 autofill::AutofillPopupControllerImpl::HideViewAndDie() #16 0x0000042ea143 autofill::AutofillExternalDelegate::~AutofillExternalDelegate() #17 0x0000042ea23e autofill::AutofillExternalDelegate::~AutofillExternalDelegate() #18 0x00000476a425 autofill::ContentAutofillDriver::~ContentAutofillDriver() #19 0x00000476a46e autofill::ContentAutofillDriver::~ContentAutofillDriver() #20 0x000001895dd0 std::__1::__hash_table<>::__erase_unique<>() #21 0x00000669a209 autofill::AutofillDriverFactory::DeleteForKey() #22 0x0000014ace11 content::WebContentsImpl::RenderFrameDeleted() #23 0x000001239d42 content::RenderFrameHostImpl::~RenderFrameHostImpl() #24 0x00000123a80e content::RenderFrameHostImpl::~RenderFrameHostImpl() #25 0x000001257684 content::RenderFrameHostManager::~RenderFrameHostManager() #26 0x000001216d42 content::FrameTreeNode::~FrameTreeNode() #27 0x00000121713e content::FrameTreeNode::RemoveChild() #28 0x000001262286 _ZN3IPC8MessageTI24FrameHostMsg_Detach_MetaNSt3__15tupleIJEEEvE8DispatchIN7content20RenderFrameProxyHostES8_vMS8_FvvEEEbPKNS_7MessageEPT_PT0_PT1_T2_ #29 0x00000126219e content::RenderFrameProxyHost::OnMessageReceived() #30 0x0000033648bb IPC::ChannelProxy::Context::OnDispatchMessage() #31 0x000002f8c4ec base::debug::TaskAnnotator::RunTask() #32 0x000002fa0387 base::MessageLoop::RunTask() #33 0x000002fa0838 base::MessageLoop::DoWork() #34 0x000003014149 base::MessagePumpLibevent::Run() #35 0x000002fbd585 base::RunLoop::Run() #36 0x0000029a5021 content::DOMMessageQueue::WaitForMessage() #37 0x0000029a411c content::(anonymous namespace)::ExecuteScriptHelper() #38 0x0000029a3e7c content::(anonymous namespace)::ExecuteScriptWithUserGestureControl() #39 0x000000483b4c autofill::AutofillInteractiveIsolationTest_DeletingFrameUnderSuggestion_Test::RunTestOnMainThread() #40 0x0000029a24a3 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #41 0x000002644cfe ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #42 0x000002643c6a ChromeBrowserMainParts::PreMainMessageLoopRun() #43 0x000001a8189f chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #44 0x000001123351 content::BrowserMainLoop::PreMainMessageLoopRun() #45 0x00000147c0a7 content::StartupTaskRunner::RunAllTasksNow() #46 0x000001121d02 content::BrowserMainLoop::CreateStartupTasks() #47 0x000001125665 content::BrowserMainRunnerImpl::Initialize() #48 0x00000111fc1c content::BrowserMain() #49 0x00000261a5ea content::ContentMainRunnerImpl::Run() #50 0x000003fa0aaf service_manager::Main() #51 0x0000026187e4 content::ContentMain() #52 0x0000029a20bf content::BrowserTestBase::SetUp() #53 0x000002635496 InProcessBrowserTest::SetUp() #54 0x00000076574d testing::Test::Run() #55 0x000000766370 testing::TestInfo::Run() #56 0x000000766887 testing::TestCase::Run() #57 0x000000771d67 testing::internal::UnitTestImpl::RunAllTests() #58 0x0000007718dd testing::UnitTest::Run() #59 0x000002f7c5a1 base::TestSuite::Run() #60 0x000000586073 InteractiveUITestSuiteRunner::RunTestSuite() #61 0x0000029a9589 content::LaunchTests()
,
Jun 4 2018
Issue 849271 has been merged into this issue.
,
Jun 4 2018
Issue 849272 has been merged into this issue.
,
Jun 4 2018
Seems like this was reverted?
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/360d661924da31e31db12510083e83b91872dc70 commit 360d661924da31e31db12510083e83b91872dc70 Author: Fabio Tirelo <ftirelo@chromium.org> Date: Tue Jun 05 17:11:03 2018 [af] Reland "Do not clear autofill selection if no suggestion is selected" This is a reland of 4a696acb61f4ad0931ad22de4a50a703facc8374 Patch #1 contains the patch originally landed, please check the diff against it to review the fix. The original patch broke interactive UI tests on ChromeOS, because of a mouse exit event being fired when the dropdown was closed; event handling could happen after Hide() set the delegate to false. TBR=groby@chromium.org Original change's description: > This fixes crbug.com/835019 , in which the current suggestion may not > be cleared when the mouse exits the popup area, by reusing the > OnMouseExited handler implemented by AutofillPopupBaseView and > overriden by AutofillPopupViewNativeViews as empty. > > The current implementation posts a task that will be a no-op if the > mouse leaves the popup and there is no suggestion selected, so this > is a safe change. > > Bug: 835019 > Change-Id: I99339d377090721719ed6c7d026f7832a0503e4d > Reviewed-on: https://chromium-review.googlesource.com/1070788 > Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> > Reviewed-by: Rachel Blum <groby@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564070} Bug: 835019 Change-Id: I99339d377090721719ed6c7d026f7832a0503e4d Reviewed-on: https://chromium-review.googlesource.com/1087008 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#564549} [modify] https://crrev.com/360d661924da31e31db12510083e83b91872dc70/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc [modify] https://crrev.com/360d661924da31e31db12510083e83b91872dc70/chrome/browser/ui/autofill/autofill_popup_controller_impl.h [modify] https://crrev.com/360d661924da31e31db12510083e83b91872dc70/chrome/browser/ui/autofill/autofill_popup_layout_model_unittest.cc [modify] https://crrev.com/360d661924da31e31db12510083e83b91872dc70/chrome/browser/ui/autofill/autofill_popup_view_delegate.h [modify] https://crrev.com/360d661924da31e31db12510083e83b91872dc70/chrome/browser/ui/cocoa/autofill/credit_card_autofill_touch_bar_controller_unittest.mm [modify] https://crrev.com/360d661924da31e31db12510083e83b91872dc70/chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa_unittest.mm [modify] https://crrev.com/360d661924da31e31db12510083e83b91872dc70/chrome/browser/ui/passwords/password_generation_popup_controller_impl.cc [modify] https://crrev.com/360d661924da31e31db12510083e83b91872dc70/chrome/browser/ui/passwords/password_generation_popup_controller_impl.h [modify] https://crrev.com/360d661924da31e31db12510083e83b91872dc70/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc [modify] https://crrev.com/360d661924da31e31db12510083e83b91872dc70/chrome/browser/ui/views/autofill/autofill_popup_base_view_browsertest.cc [modify] https://crrev.com/360d661924da31e31db12510083e83b91872dc70/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.h [modify] https://crrev.com/360d661924da31e31db12510083e83b91872dc70/chrome/browser/ui/views/autofill/autofill_popup_view_native_views_unittest.cc [modify] https://crrev.com/360d661924da31e31db12510083e83b91872dc70/chrome/browser/ui/views/autofill/autofill_popup_view_views_browsertest.cc
,
Jun 5 2018
Will let it run in the canary for one day before asking to merge again.
,
Jun 6 2018
,
Jun 6 2018
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 6 2018
Approved
,
Jun 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18c2718859e06d2160b86fe715bc60f96f35b0da commit 18c2718859e06d2160b86fe715bc60f96f35b0da Author: Fabio Tirelo <ftirelo@chromium.org> Date: Fri Jun 08 13:52:05 2018 [af] Reland "Do not clear autofill selection if no suggestion is selected" This is a reland of 4a696acb61f4ad0931ad22de4a50a703facc8374 Patch #1 contains the patch originally landed, please check the diff against it to review the fix. The original patch broke interactive UI tests on ChromeOS, because of a mouse exit event being fired when the dropdown was closed; event handling could happen after Hide() set the delegate to false. TBR=groby@chromium.org Original change's description: > This fixes crbug.com/835019 , in which the current suggestion may not > be cleared when the mouse exits the popup area, by reusing the > OnMouseExited handler implemented by AutofillPopupBaseView and > overriden by AutofillPopupViewNativeViews as empty. > > The current implementation posts a task that will be a no-op if the > mouse leaves the popup and there is no suggestion selected, so this > is a safe change. > > Bug: 835019 > Change-Id: I99339d377090721719ed6c7d026f7832a0503e4d > Reviewed-on: https://chromium-review.googlesource.com/1070788 > Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> > Reviewed-by: Rachel Blum <groby@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564070} (cherry picked from commit 360d661924da31e31db12510083e83b91872dc70) Bug: 835019 Change-Id: I99339d377090721719ed6c7d026f7832a0503e4d Reviewed-on: https://chromium-review.googlesource.com/1087008 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#564549} Reviewed-on: https://chromium-review.googlesource.com/1092314 Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#259} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/18c2718859e06d2160b86fe715bc60f96f35b0da/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc [modify] https://crrev.com/18c2718859e06d2160b86fe715bc60f96f35b0da/chrome/browser/ui/autofill/autofill_popup_controller_impl.h [modify] https://crrev.com/18c2718859e06d2160b86fe715bc60f96f35b0da/chrome/browser/ui/autofill/autofill_popup_layout_model_unittest.cc [modify] https://crrev.com/18c2718859e06d2160b86fe715bc60f96f35b0da/chrome/browser/ui/autofill/autofill_popup_view_delegate.h [modify] https://crrev.com/18c2718859e06d2160b86fe715bc60f96f35b0da/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc [modify] https://crrev.com/18c2718859e06d2160b86fe715bc60f96f35b0da/chrome/browser/ui/autofill/password_generation_popup_controller_impl.h [modify] https://crrev.com/18c2718859e06d2160b86fe715bc60f96f35b0da/chrome/browser/ui/cocoa/autofill/credit_card_autofill_touch_bar_controller_unittest.mm [modify] https://crrev.com/18c2718859e06d2160b86fe715bc60f96f35b0da/chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa_unittest.mm [modify] https://crrev.com/18c2718859e06d2160b86fe715bc60f96f35b0da/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc [modify] https://crrev.com/18c2718859e06d2160b86fe715bc60f96f35b0da/chrome/browser/ui/views/autofill/autofill_popup_base_view_browsertest.cc [modify] https://crrev.com/18c2718859e06d2160b86fe715bc60f96f35b0da/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.h [modify] https://crrev.com/18c2718859e06d2160b86fe715bc60f96f35b0da/chrome/browser/ui/views/autofill/autofill_popup_view_native_views_unittest.cc [modify] https://crrev.com/18c2718859e06d2160b86fe715bc60f96f35b0da/chrome/browser/ui/views/autofill/autofill_popup_view_views_browsertest.cc
,
Jun 8 2018
,
Jun 13 2018
Able to reproduce this issue on reported version 68.0.3400.0, hence verifying the issue on 68.0.3440.25 using Windows 10. Now without clicking page, able to click inside field, select or edit text. Attaching screencast for reference. As fix is working as expected adding TE-Verified labels. Thanks! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by se...@chromium.org
, Apr 19 2018