New issue
Advanced search Search tips

Issue 835009 link

Starred by 2 users
Status: Fixed
Owner:
jrumm...@chromium.org
Closed: May 2018
Cc:
xhw...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocked on:
issue 658026


Sign in to add a comment

Enable CBCS support on non-component-updated CDMs

Project Member Reported by jrumm...@chromium.org, Apr 19 2018 
Note that CBCS support on desktop Chrome is tracked by issue 658026. This issue is tracking the enabling of CBCS support for the CDMs that aren't component updated, as code must be updated to specify CBCS support when a new version of the CDM is checked in that supports it.

There should also be proper test coverage, including Widevine when this happens.
Project Member

Comment 1 by bugdroid1@chromium.org, May 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4655dce377488a129b33aca40ae30244b0801cd

commit d4655dce377488a129b33aca40ae30244b0801cd
Author: John Rummell <jrummell@chromium.org>
Date: Thu May 10 19:34:47 2018

[eme] Enable Clear Key CDM to support 'cbcs' decryption

Now that AesDecryptor supports 'cbcs' decryption, update the
Clear Key CDM to do the same.

BUG=658026, 835009 
TEST=modified browser_test passes

Change-Id: Ie138d4b638d5d6493cb89368171adae5660486da
Reviewed-on: https://chromium-review.googlesource.com/1053172
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557625}
[modify] https://crrev.com/d4655dce377488a129b33aca40ae30244b0801cd/chrome/browser/media/encrypted_media_browsertest.cc
[modify] https://crrev.com/d4655dce377488a129b33aca40ae30244b0801cd/chrome/common/chrome_content_client.cc
[modify] https://crrev.com/d4655dce377488a129b33aca40ae30244b0801cd/media/cdm/library_cdm/clear_key_cdm/clear_key_cdm.cc

Comment 2 by jrumm...@chromium.org, May 29 2018

Status: Fixed (was: Assigned)
Both ClearKey and ECK support CBCS, and there are tests to verify it:
  MSE_ClearKey/EncryptedMediaTest.Playback_Encryption_CBCS/0
  MSE_ExternalClearKey/EncryptedMediaTest.Playback_Encryption_CBCS/0
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2baa7afe761df394d1ce0fab07dc36cdaa680bd6

commit 2baa7afe761df394d1ce0fab07dc36cdaa680bd6
Author: John Rummell <jrummell@chromium.org>
Date: Thu Jun 14 21:46:30 2018

[eme] Enable checking of 'cbcs' support in Widevine

Recent versions of Widevine support 'cbcs' encrypted files, so add a query
test to verify that it is supported. As well, on systems where Widevine is
not component updated, indicate that the bundled Widevine does support
'cbcs' decryption.

BUG= 835009 
TEST=new browser_tests pass

Change-Id: Icc4294cca4ac9ba97c2a22816217c57e2262d30a
Reviewed-on: https://chromium-review.googlesource.com/1101405
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567433}
[modify] https://crrev.com/2baa7afe761df394d1ce0fab07dc36cdaa680bd6/chrome/browser/media/encrypted_media_supported_types_browsertest.cc
[modify] https://crrev.com/2baa7afe761df394d1ce0fab07dc36cdaa680bd6/chrome/common/chrome_content_client.cc
►

Sign in to add a comment