New issue
Advanced search Search tips

Issue 834989 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Apr 2018
Cc:
qyears...@chromium.org
robertma@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

webkit_python_tests on CQ bots

Project Member Reported by wangxianzhu@chromium.org, Apr 19 2018 
I remember we ever ran webkit_python_tests on some CQ bots, but they seem not running it. I think we should run it on CQ bots to prevent problematic CLs from being landed.

Comment 1 by robertma@chromium.org, Apr 19 2018 

Is this conditional?

I saw a recent CL with changes in webkitpy had webkit_python_tests in CQ (https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/73643).

Just triggered CQ+1 on a new CL to confirm: https://chromium-review.googlesource.com/c/chromium/src/+/1018590

Comment 2 by wangxianzhu@chromium.org, Apr 19 2018

Status: WontFix (was: Untriaged)
I see. Thanks for the test.

 Bug 834722  seems just a special case and we might just leave it as is.

Comment 3 by qyears...@chromium.org, Apr 19 2018 

Yeah, the reason why we were suspecting that perhaps webkit_python_tests were not run in CQ bots was because of  bug 834722  -- one test was failing on local workstations but not on the bots for quite a while.

We still don't know why that test passed on the bots, I think, but I also agree its OK to close this bug.

Anyway, thanks wangxianzhu@ for filing an issue and robertma@ for checking up on this.
►

Sign in to add a comment