New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 834984 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

replace SkColorSetARGBX with SkColorSetARGB

Project Member Reported by caryclark@google.com, Apr 19 2018

Issue description

Two older calls in Skia

SkColorSetARGBMacro()
SkColorSetARGBInline()

have been deleted and redirect to SkColorSetARGB().

Change the callers so the indirections can be deleted as well.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a8b808b280578ed75db4a4117e7322396c0e5f3

commit 9a8b808b280578ed75db4a4117e7322396c0e5f3
Author: Cary Clark <caryclark@google.com>
Date: Mon Apr 23 18:29:21 2018

replace deprecated SkColorSetARGBX calls

Replace SkColorSetARGBMacro with SkColorSetARGB.

Replace SkColorSetARGBInline with SkColorSetARGB.

SkColorSetARGBMacro and SkColorSetARGBInline
are macros which will be deleted.

R=sky@chromium.org,fmalita@chromium.org

Bug:  834984 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I08eb888f0848b9ebad93d2dc782c7a7f73bf7987
Reviewed-on: https://chromium-review.googlesource.com/1020043
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Cary Clark <caryclark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552759}
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/ash/accessibility/accessibility_cursor_ring_layer.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/ash/accessibility/accessibility_focus_ring_layer.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/ash/components/shortcut_viewer/views/bubble_view.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/ash/components/shortcut_viewer/views/keyboard_shortcut_item_list_view.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/ash/components/shortcut_viewer/views/keyboard_shortcut_item_view.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/ash/components/shortcut_viewer/views/keyboard_shortcut_view.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/ash/components/shortcut_viewer/views/ksv_search_box_view.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/ash/display/touch_calibrator_view.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/ash/login/ui/login_button.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/ash/login/ui/login_password_view.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/ash/login/ui/login_pin_view.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/ash/login/ui/login_public_account_user_view.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/ash/login/ui/login_user_view.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/ash/system/power/power_button_menu_item_view.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/ash/system/power/power_button_menu_screen_view.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/ash/wm/overview/window_selector_item.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/cc/layers/solid_color_layer_impl_unittest.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/cc/paint/paint_op_buffer_unittest.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/chrome/browser/ui/app_list/search/arc/arc_playstore_search_result.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/chrome/browser/ui/app_list/search/omnibox_result.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/chrome/browser/ui/app_list/search/settings_shortcut/settings_shortcut_result.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/components/viz/service/display/renderer_pixeltest.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/content/renderer/pepper/pepper_compositor_host.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/skia/ext/image_operations_unittest.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/ui/app_list/views/app_list_item_view.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/ui/app_list/views/expand_arrow_view.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/ui/app_list/views/folder_header_view.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/ui/app_list/views/indicator_chip_view.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/ui/app_list/views/search_box_view.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/ui/app_list/views/search_result_page_view.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/ui/app_list/views/search_result_tile_item_list_view.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/ui/app_list/views/search_result_tile_item_view.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/ui/app_list/views/search_result_view.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/ui/chromeos/search_box/search_box_constants.h
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/ui/chromeos/search_box/search_box_view_base.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/ui/compositor/layer_unittest.cc
[modify] https://crrev.com/9a8b808b280578ed75db4a4117e7322396c0e5f3/ui/views/controls/tabbed_pane/tabbed_pane.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment