Standardize DEPS format |
|||||
Issue descriptionDependencies are expressed in DEPS files in a lot of different ways. For example: 'src-internal': 'https://chrome-internal.googlesource.com/chrome/src-internal.git@<some-revision>' 'src/v8': Var('chromium_git') + '/v8/v8.git' + '@' + Var('v8_revision') 'src/third_party/webrtc': Var('webrtc_git') + '/src.git' + '@' + '<some-revision>' Var("dart_root") + "/buildtools": Var("fuchsia_git") + "/buildtools" + Var("buildtools_revision") # Where buildtools_revision is "@<some-revision>" It's also possible to use braces '{}' instead of Var functions, i.e. '{chromium_git}' instead of Var('chromium_git'). This makes it hard to interact programmatically with DEPS files, since there are several potential different ways these revisions can be expressed. We should move towards standardizing the format DEPS files are written in. See [1] for the design doc. [1] https://docs.google.com/document/d/1GSTw4ysm5AYjNR6vMA7NJUxLK2VN9IpOEp_v0u-wyOE/edit?disco=AAAABwtyHPc&ts=5ad7d242#heading=h.w55v6x5dm53 ⛆ |
|
|
,
Apr 19 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/460edb8d9be820aaad7e13e4498627265f4eac6a commit 460edb8d9be820aaad7e13e4498627265f4eac6a Author: Edward Lesmes <ehmaldonado@google.com> Date: Thu Apr 19 20:46:14 2018
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/0d6f84866778579e8d0f5a852857a36cc9bc2951 commit 0d6f84866778579e8d0f5a852857a36cc9bc2951 Author: Edward Lesmes <ehmaldonado@chromium.org> Date: Tue Apr 24 15:47:07 2018 pinpoint: Make DEPS parsing forwards compatible. For details, see: https://docs.google.com/document/d/1GSTw4ysm5AYjNR6vMA7NJUxLK2VN9IpOEp_v0u-wyOE/edit?ts=5ad7d242#heading=h.w55v6x5dm53 Bug: chromium:834968 Change-Id: I748299889ed4573209058e973fa55ceced682266 Reviewed-on: https://chromium-review.googlesource.com/1020537 Reviewed-by: Simon Hatch <simonhatch@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> [modify] https://crrev.com/0d6f84866778579e8d0f5a852857a36cc9bc2951/dashboard/dashboard/pinpoint/models/change/commit.py [modify] https://crrev.com/0d6f84866778579e8d0f5a852857a36cc9bc2951/dashboard/dashboard/pinpoint/models/change/commit_test.py
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5536210c26e13d448d50769d27b0a863c42adce4 commit 5536210c26e13d448d50769d27b0a863c42adce4 Author: catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Tue Apr 24 20:31:03 2018 Roll src/third_party/catapult/ 921cf8305..0d6f84866 (2 commits) https://chromium.googlesource.com/catapult.git/+log/921cf8305ce5..0d6f84866778 $ git log 921cf8305..0d6f84866 --date=short --no-merges --format='%ad %ae %s' 2018-04-23 ehmaldonado pinpoint: Make DEPS parsing forwards compatible. 2018-04-24 simonhatch Dashboard - Remove mapreduce.yaml from __init__.py Created with: roll-dep src/third_party/catapult BUG=chromium:834968 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I11cf5e67d2fadba50168fd19576c19e302bb2d4e Reviewed-on: https://chromium-review.googlesource.com/1026161 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553246} [modify] https://crrev.com/5536210c26e13d448d50769d27b0a863c42adce4/DEPS
,
May 4 2018
|
||
►
Sign in to add a comment |
|||||
Comment 1 by ehmaldonado@chromium.org
, Apr 19 2018