Need a friendly build error if target_os = android is missing from .gclient |
||
Issue descriptionIt sounds like a few people were bit by the bug that if you try to configure "GN" to target Android, but you don't add target_os = android to your .gclient file also, it will now fail. (It used to work.) It'd be nice if we could detect that automatically and output a nice error message. Specifically I'm imagining that on running "gn gen", if target_os resolves to "android" but .gclient is missing that line, we'd stop immediately and instruct the developer to add that line and then run "gclient sync".
,
Apr 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24bdb02ce9ba349ec9d93dcf6170aab30d1a501a commit 24bdb02ce9ba349ec9d93dcf6170aab30d1a501a Author: John Budorick <jbudorick@chromium.org> Date: Mon Apr 23 14:15:28 2018 Ensure that gclient target_os includes android for android builds. Bug: 834964 Change-Id: If2c40ee7a785f85a084527f346c78d57f5f338d5 Reviewed-on: https://chromium-review.googlesource.com/1022741 Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#552687} [modify] https://crrev.com/24bdb02ce9ba349ec9d93dcf6170aab30d1a501a/DEPS [modify] https://crrev.com/24bdb02ce9ba349ec9d93dcf6170aab30d1a501a/build/config/android/config.gni
,
Apr 23 2018
Attempting to do an android build if you've synced beyond #2 *and* don't have 'android' in your gclient target_os will now result in the following error message: "target_os in your .gclient configuration must include android." Thanks for the suggestion! |
||
►
Sign in to add a comment |
||
Comment 1 by jbudorick@chromium.org
, Apr 20 2018Owner: jbudorick@chromium.org
Status: Started (was: Untriaged)