New issue
Advanced search Search tips

Issue 834963 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocking:
issue 876586



Sign in to add a comment

Chrome should statically link libayatana-appindicator

Project Member Reported by thomasanderson@chromium.org, Apr 19 2018

Issue description

libappindicator is being removed in debian in favor of libayatana-appindicator:
https://lists.debian.org/debian-devel/2018/03/thrd2.html
https://lists.debian.org/debian-devel/2018/03/msg00506.html
https://sunweavers.net/blog/node/67
https://github.com/AyatanaIndicators/libayatana-appindicator

Chrome should stop using libappindicator1/libappindicator3-1 and start using libayatana-appindicator1/libayatana-appindicator3-1.  Unfortunately, it's possible that Debian Stretch will have libappindicator only and Debian Buster will have libayatana-appindicator only (once released).  This means our only option is to add ayatana-appindicator to third_party and build it ourselves.
 
Cc: thomasanderson@chromium.org
Owner: timbrown@chromium.org
Status: Assigned (was: Available)
+timbrown.  As a bonus, we won't have to worry about the 32-bit issue Ubuntu is having with libappindicator.  And we can apply our own patches if we want.  I can help out with adding the code to third_party, it should be relatively straightforward.
That's a pity. I was hoping we would get away with not statically linking an icon library before we remove status icons from Chrome altogether (assuming we do).

There's an alternative library, statusnotifier, which is a little more powerful, e.g. it allows us to set a non-menu left click action (which would tie in better with KDE). But since libayatana-appindicator is basically a drop-in replacement, it would probably be easier to just use it.
If you want to use statusnotifier, that's OK with me, so long as you're OK with updating the API calls.

I don't see a problem with statically linking since the library on disk is tiny at only 52K.  (and it would probably be even smaller with LTO which prunes unused functions, etc).  But you're right in that it would require nontrivial effort to add it to third_party.
Owner: thomasanderson@chromium.org
Blocking: 876586

Sign in to add a comment