New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 834960 link

Starred by 1 user
Status: Fixed
Owner:
osh...@chromium.org
Closed: Apr 2018
Cc:
█ reve...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

snap button sometimes disappers on arc window

Project Member Reported by osh...@chromium.org, Apr 19 2018 
This is because we unconditionally calling Widget::OnSizeConstraintsChanged in ShellSurfaceBase::OnSurfaceCommit

Comment 1 by elijahtaylor@chromium.org, Apr 20 2018

Components: Platform>ARC
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50d3ebca2553f9ef4ce280ed824cee8b8dd88335

commit 50d3ebca2553f9ef4ce280ed824cee8b8dd88335
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Fri Apr 20 18:54:12 2018

Call OnSizeConstraintsChanged only when the min/max size changes

R=reveman@chromium.org
BUG= 834960 
TEST=manual

Change-Id: I960ff91ca7c30341b11904157edd598b1caa611d
Reviewed-on: https://chromium-review.googlesource.com/1020198
Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552413}
[modify] https://crrev.com/50d3ebca2553f9ef4ce280ed824cee8b8dd88335/components/exo/shell_surface_base.cc

Comment 3 by osh...@chromium.org, Apr 20 2018

Labels: Merge-Approved-67

Comment 4 by osh...@chromium.org, Apr 24 2018

Labels: -Merge-Approved-67 Merge-Request-67

Comment 5 by kbleicher@chromium.org, Apr 24 2018 

Has this change been tested / verified on some number of boards?
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 25 2018

Labels: -Merge-Request-67 Merge-Approved-67 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 25 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d93bc83e8e0f0a202b65504f090af0eeb939c2d8

commit d93bc83e8e0f0a202b65504f090af0eeb939c2d8
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Wed Apr 25 23:38:03 2018

Call OnSizeConstraintsChanged only when the min/max size changes

R=​reveman@chromium.org
BUG= 834960 
TEST=manual

Change-Id: I960ff91ca7c30341b11904157edd598b1caa611d
Reviewed-on: https://chromium-review.googlesource.com/1020198
Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#552413}(cherry picked from commit 50d3ebca2553f9ef4ce280ed824cee8b8dd88335)
Reviewed-on: https://chromium-review.googlesource.com/1029091
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#315}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/d93bc83e8e0f0a202b65504f090af0eeb939c2d8/components/exo/shell_surface_base.cc

Comment 8 by osh...@chromium.org, Apr 26 2018

Status: Fixed (was: Started)
Re #5 question, I did test this on nautilus and caroline.
►

Sign in to add a comment