New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 834958 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Chrome OS 68.10598.0 does a developer wipe every time on boot if a user account exists

Project Member Reported by bleung@chromium.org, Apr 19 2018

Issue description

<b>Chrome Version: <From about:version: Google Chrome x.x.x.x></b>
Chrome OS Version: 68.10598.0
Chrome OS Platform: Eve
<b>Network info: <network, encryption type, router model (if known)></b>

Please specify Cr-* of the system to which this bug/feature applies (add
the label below).

Steps To Reproduce:
(1) Recover or AU to the build above
(2) Make sure in normal mode
(3) log in as a user
(4) shut down
(5) boot back up.

Expected Result:
Boots normally, remembers user account.

Actual Result:
Dev wipe.
How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
Always

What is the impact to the user, and is there a workaround? If so, what is
it?

Please provide any additional information below. Attach a screen shot or
log if possible.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 

Comment 1 by bleung@google.com, Apr 19 2018

Aseda, do you have a link to what might have caused this?

Comment 2 by bleung@chromium.org, Apr 19 2018

Cc: djaklich@chromium.org
Cc: shchen@chromium.org sonnyrao@chromium.org igorcov@chromium.org
Talking with Shelley, she pointed to this bit of code where the decision is made.[0] There was a change that landed to that file yesterday.[1]

[0]- https://chromium.googlesource.com/chromiumos/platform2/+/cee4ef405247c36491dd6b221854a1a5114eb3bf/init/chromeos_startup#284

[1]- https://chromium-review.googlesource.com/c/chromiumos/platform2/+/999636

Comment 4 by bleung@chromium.org, Apr 19 2018

Owner: igorcov@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2ff880c35e9d6036c07804ee19cbbf67ed1335a1

commit 2ff880c35e9d6036c07804ee19cbbf67ed1335a1
Author: Igor <igorcov@chromium.org>
Date: Fri Apr 20 09:48:41 2018

Revert "init: Fix location for install_attributes,"

This reverts commit 913b862c4aae9c3260b5599283cb49bf123cbc49.

Reason for revert: This commit caused canary 68.10598.0 to fail.
If a user had set up the system already, shutting down or rebooting
will cause a dev-to-normal wipe, despite the system never leaving
normal mode.

Original change's description:
> init: Fix location for install_attributes,
>
> The folder /home is not mounted yet, when we need to check if
> install_attributes file is present. This fixes the location to check
> in /mnt/stateful_partition instead.
>
> BUG= chromium:701292 
> TEST=Manual test
>
> Change-Id: I7ec79056b3c8cfd5f3d1565c783203d7d3fd1a04
> Reviewed-on: https://chromium-review.googlesource.com/999636
> Commit-Ready: Igor <igorcov@chromium.org>
> Tested-by: Igor <igorcov@chromium.org>
> Reviewed-by: Igor <igorcov@chromium.org>
> Reviewed-by: Randall Spangler <rspangler@chromium.org>
> Reviewed-by: Sonny Rao <sonnyrao@chromium.org>

BUG= chromium:834958 
TEST=OS image on a normal mode Chromebook does not result in a
dev-to-normal wipe every time after a reboot or shutdown.

Change-Id: I9d2c8bcaafa6d50afba3a970be3164a5488f660e
Reviewed-on: https://chromium-review.googlesource.com/1019181
Commit-Ready: Benson Leung <bleung@chromium.org>
Tested-by: Benson Leung <bleung@chromium.org>
Reviewed-by: Benson Leung <bleung@google.com>

[modify] https://crrev.com/2ff880c35e9d6036c07804ee19cbbf67ed1335a1/init/chromeos_startup

Comment 6 by bleung@chromium.org, Apr 23 2018

Status: Verified (was: Assigned)

Sign in to add a comment