New issue
Advanced search Search tips

Issue 834939 link

Starred by 9 users
Status: Fixed
Owner:
rogerta@chromium.org
Closed: May 2018
Cc:
pastarmovj@chromium.org
robertshield@chromium.org
georgesak@chromium.org
csharp@chromium.org
privard@chromium.org
vakh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Group policy controls for the Chrome Cleanup Tool

Project Member Reported by robertshield@chromium.org, Apr 19 2018 
The Chrome Cleanup Tool is not currently manageable by group policy. 

We have had a number of customer requests to allow administrators to:
* disable weekly scans for unwanted software and any resulting user-initiated cleanup
* control whether users can opt in to sharing meta-data about unwanted software found on the system

While a policy to control sharing meta-data from the weekly scans already exists (https://www.chromium.org/administrators/policy-list-3#SafeBrowsingExtendedReportingEnabled), there aren't blanket policies specific to the CCT and there doesn't yet exist a policy to disable the weekly background scan.

Comment 1 by atwilson@chromium.org, Apr 20 2018

Labels: Enterprise-Triaged

Comment 2 by robertshield@chromium.org, Apr 20 2018

Cc: pastarmovj@chromium.org robertshield@chromium.org
 Issue 829732  has been merged into this issue.

Comment 3 by nparker@chromium.org, May 4 2018

Labels: SafeBrowsing-Triaged

Comment 4 by joenotcharles@chromium.org, May 4 2018

Owner: rogerta@chromium.org
Status: Started (was: Available)

Comment 5 by joenotcharles@chromium.org, May 4 2018 

Roger's working on this.
Project Member

Comment 6 by bugdroid1@chromium.org, May 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea777719473ba507301053047a75c3cbe999919a

commit ea777719473ba507301053047a75c3cbe999919a
Author: Roger Tawa <rogerta@chromium.org>
Date: Fri May 04 20:17:59 2018

Add policies to control the chrome cleanup tool.

This CL simply adds the new policies and hooks them up the appropriate
local state preferences.  A follow up CL will start using the policies to
control chrome behaviour.

Bug:  834939 
Change-Id: If8a0984a118383a375f2a72c71f0b1cf555fbb6a
Reviewed-on: https://chromium-review.googlesource.com/1032797
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Robert Shield <robertshield@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556172}
[modify] https://crrev.com/ea777719473ba507301053047a75c3cbe999919a/chrome/browser/component_updater/sw_reporter_installer_win.cc
[modify] https://crrev.com/ea777719473ba507301053047a75c3cbe999919a/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/ea777719473ba507301053047a75c3cbe999919a/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/ea777719473ba507301053047a75c3cbe999919a/components/component_updater/pref_names.cc
[modify] https://crrev.com/ea777719473ba507301053047a75c3cbe999919a/components/component_updater/pref_names.h
[modify] https://crrev.com/ea777719473ba507301053047a75c3cbe999919a/components/policy/core/common/policy_loader_win.cc
[modify] https://crrev.com/ea777719473ba507301053047a75c3cbe999919a/components/policy/resources/policy_templates.json
[modify] https://crrev.com/ea777719473ba507301053047a75c3cbe999919a/tools/metrics/histograms/enums.xml
Project Member

Comment 7 by bugdroid1@chromium.org, May 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e630d4c1e75ffaa1ad0d7d11c1a09ef23f55388c

commit e630d4c1e75ffaa1ad0d7d11c1a09ef23f55388c
Author: Roger Tawa <rogerta@chromium.org>
Date: Thu May 10 13:36:52 2018

Use policy to control the Chrome Cleanup Tool.

Bug:  834939 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iaa64d4a386da00914b0f69a33573f8e049833b82
Reviewed-on: https://chromium-review.googlesource.com/1035805
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557502}
[modify] https://crrev.com/e630d4c1e75ffaa1ad0d7d11c1a09ef23f55388c/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/e630d4c1e75ffaa1ad0d7d11c1a09ef23f55388c/chrome/browser/component_updater/sw_reporter_installer_win.cc
[modify] https://crrev.com/e630d4c1e75ffaa1ad0d7d11c1a09ef23f55388c/chrome/browser/component_updater/sw_reporter_installer_win.h
[modify] https://crrev.com/e630d4c1e75ffaa1ad0d7d11c1a09ef23f55388c/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/e630d4c1e75ffaa1ad0d7d11c1a09ef23f55388c/chrome/browser/resources/settings/basic_page/basic_page.html
[modify] https://crrev.com/e630d4c1e75ffaa1ad0d7d11c1a09ef23f55388c/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html
[modify] https://crrev.com/e630d4c1e75ffaa1ad0d7d11c1a09ef23f55388c/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.js
[modify] https://crrev.com/e630d4c1e75ffaa1ad0d7d11c1a09ef23f55388c/chrome/browser/resources/settings/reset_page/reset_page.html
[modify] https://crrev.com/e630d4c1e75ffaa1ad0d7d11c1a09ef23f55388c/chrome/browser/resources/settings/reset_page/reset_page.js
[modify] https://crrev.com/e630d4c1e75ffaa1ad0d7d11c1a09ef23f55388c/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win.cc
[modify] https://crrev.com/e630d4c1e75ffaa1ad0d7d11c1a09ef23f55388c/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win.h
[modify] https://crrev.com/e630d4c1e75ffaa1ad0d7d11c1a09ef23f55388c/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_win.h
[modify] https://crrev.com/e630d4c1e75ffaa1ad0d7d11c1a09ef23f55388c/chrome/browser/safe_browsing/chrome_cleaner/mock_chrome_cleaner_controller_win.h
[modify] https://crrev.com/e630d4c1e75ffaa1ad0d7d11c1a09ef23f55388c/chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_browsertest_win.cc
[modify] https://crrev.com/e630d4c1e75ffaa1ad0d7d11c1a09ef23f55388c/chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_win.cc
[modify] https://crrev.com/e630d4c1e75ffaa1ad0d7d11c1a09ef23f55388c/chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_win.h
[modify] https://crrev.com/e630d4c1e75ffaa1ad0d7d11c1a09ef23f55388c/chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc
Project Member

Comment 8 by bugdroid1@chromium.org, May 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e57e0101bec785ef9798a99e829290d7433e17d

commit 8e57e0101bec785ef9798a99e829290d7433e17d
Author: Roger Tawa <rogerta@chromium.org>
Date: Thu May 17 21:30:57 2018

Use policy to control Chrome Cleanup reporting.

Bug:  834939 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I603d1d8d43d5317f8a8ef24f4fdbb537e0a21541
Reviewed-on: https://chromium-review.googlesource.com/1053763
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559685}
[modify] https://crrev.com/8e57e0101bec785ef9798a99e829290d7433e17d/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.js
[modify] https://crrev.com/8e57e0101bec785ef9798a99e829290d7433e17d/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win.cc
[modify] https://crrev.com/8e57e0101bec785ef9798a99e829290d7433e17d/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win.h
[modify] https://crrev.com/8e57e0101bec785ef9798a99e829290d7433e17d/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_win.h
[modify] https://crrev.com/8e57e0101bec785ef9798a99e829290d7433e17d/chrome/browser/safe_browsing/chrome_cleaner/mock_chrome_cleaner_controller_win.h
[modify] https://crrev.com/8e57e0101bec785ef9798a99e829290d7433e17d/chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_browsertest_win.cc
[modify] https://crrev.com/8e57e0101bec785ef9798a99e829290d7433e17d/chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_win.cc
[modify] https://crrev.com/8e57e0101bec785ef9798a99e829290d7433e17d/chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_win.h
[modify] https://crrev.com/8e57e0101bec785ef9798a99e829290d7433e17d/chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc
[modify] https://crrev.com/8e57e0101bec785ef9798a99e829290d7433e17d/chrome/browser/ui/webui/settings/chrome_cleanup_handler.h
[modify] https://crrev.com/8e57e0101bec785ef9798a99e829290d7433e17d/tools/metrics/histograms/enums.xml
Project Member

Comment 9 by bugdroid1@chromium.org, May 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/673c2965225fa332750026da6686cc3a0453d157

commit 673c2965225fa332750026da6686cc3a0453d157
Author: Reid Kleckner <rnk@chromium.org>
Date: Tue May 22 20:13:49 2018

Revert "Use policy to control Chrome Cleanup reporting."

This reverts commit 8e57e0101bec785ef9798a99e829290d7433e17d.

Reason for revert: It breaks official builds:
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/84546

Original change's description:
> Use policy to control Chrome Cleanup reporting.
> 
> Bug:  834939 
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I603d1d8d43d5317f8a8ef24f4fdbb537e0a21541
> Reviewed-on: https://chromium-review.googlesource.com/1053763
> Commit-Queue: Roger Tawa <rogerta@chromium.org>
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Reviewed-by: Joe Mason <joenotcharles@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#559685}

TBR=rogerta@chromium.org,dpapad@chromium.org,joenotcharles@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  834939 
Change-Id: I1b6e1a4007935abf0f6e8f9b1adf05804c431a1f
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1069387
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560748}
[modify] https://crrev.com/673c2965225fa332750026da6686cc3a0453d157/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.js
[modify] https://crrev.com/673c2965225fa332750026da6686cc3a0453d157/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win.cc
[modify] https://crrev.com/673c2965225fa332750026da6686cc3a0453d157/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win.h
[modify] https://crrev.com/673c2965225fa332750026da6686cc3a0453d157/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_win.h
[modify] https://crrev.com/673c2965225fa332750026da6686cc3a0453d157/chrome/browser/safe_browsing/chrome_cleaner/mock_chrome_cleaner_controller_win.h
[modify] https://crrev.com/673c2965225fa332750026da6686cc3a0453d157/chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_browsertest_win.cc
[modify] https://crrev.com/673c2965225fa332750026da6686cc3a0453d157/chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_win.cc
[modify] https://crrev.com/673c2965225fa332750026da6686cc3a0453d157/chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_win.h
[modify] https://crrev.com/673c2965225fa332750026da6686cc3a0453d157/chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc
[modify] https://crrev.com/673c2965225fa332750026da6686cc3a0453d157/chrome/browser/ui/webui/settings/chrome_cleanup_handler.h
[modify] https://crrev.com/673c2965225fa332750026da6686cc3a0453d157/tools/metrics/histograms/enums.xml

Comment 10 by rogerta@chromium.org, May 23 2018

Status: Fixed (was: Started)

Comment 11 by joenotcharles@chromium.org, May 23 2018

Status: Started (was: Fixed)
Reopening since the commit that fixed this was reverted.
Project Member

Comment 12 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3daaae9df044f4cd876543fe1f01e2b76bf51ee

commit c3daaae9df044f4cd876543fe1f01e2b76bf51ee
Author: Roger Tawa <rogerta@chromium.org>
Date: Thu May 24 21:00:13 2018

Reland: Use policy to control Chrome Cleanup reporting.

This change was originally landed as:
https://chromium-review.googlesource.com/c/chromium/src/+/1053763

It was reverted because it broken official builders:
https://chromium-review.googlesource.com/c/chromium/src/+/1069387

Patchset #1 of this CL is exactly the patch that was originally landed.

Patchset #3 contains the fix: update javascript test code to accept new
arguments in the C++ to javascript bindings.

Bug:  834939 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia04822d91cdc436b482d0f0c5f3af2c71d003c1f
Reviewed-on: https://chromium-review.googlesource.com/1071712
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561626}
[modify] https://crrev.com/c3daaae9df044f4cd876543fe1f01e2b76bf51ee/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.js
[modify] https://crrev.com/c3daaae9df044f4cd876543fe1f01e2b76bf51ee/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win.cc
[modify] https://crrev.com/c3daaae9df044f4cd876543fe1f01e2b76bf51ee/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win.h
[modify] https://crrev.com/c3daaae9df044f4cd876543fe1f01e2b76bf51ee/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_win.h
[modify] https://crrev.com/c3daaae9df044f4cd876543fe1f01e2b76bf51ee/chrome/browser/safe_browsing/chrome_cleaner/mock_chrome_cleaner_controller_win.h
[modify] https://crrev.com/c3daaae9df044f4cd876543fe1f01e2b76bf51ee/chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_browsertest_win.cc
[modify] https://crrev.com/c3daaae9df044f4cd876543fe1f01e2b76bf51ee/chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_win.cc
[modify] https://crrev.com/c3daaae9df044f4cd876543fe1f01e2b76bf51ee/chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_win.h
[modify] https://crrev.com/c3daaae9df044f4cd876543fe1f01e2b76bf51ee/chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc
[modify] https://crrev.com/c3daaae9df044f4cd876543fe1f01e2b76bf51ee/chrome/browser/ui/webui/settings/chrome_cleanup_handler.h
[modify] https://crrev.com/c3daaae9df044f4cd876543fe1f01e2b76bf51ee/chrome/test/data/webui/settings/chrome_cleanup_page_test.js
[modify] https://crrev.com/c3daaae9df044f4cd876543fe1f01e2b76bf51ee/tools/metrics/histograms/enums.xml

Comment 13 by rogerta@chromium.org, May 28 2018

Status: Fixed (was: Started)
Project Member

Comment 14 by bugdroid1@chromium.org, May 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ed8bbb76b02111971ed0b777663ca30afb7926c

commit 5ed8bbb76b02111971ed0b777663ca30afb7926c
Author: Roger Tawa <rogerta@chromium.org>
Date: Wed May 30 17:22:38 2018

Disable logs checkbox in ChromeCleanerDialog when disabled by policy.

Bug:  834939 
Change-Id: I1951b6face63def33f0ec05162ff512477f7d4a0
Reviewed-on: https://chromium-review.googlesource.com/1075718
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562886}
[modify] https://crrev.com/5ed8bbb76b02111971ed0b777663ca30afb7926c/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win.cc
[modify] https://crrev.com/5ed8bbb76b02111971ed0b777663ca30afb7926c/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win.h
[modify] https://crrev.com/5ed8bbb76b02111971ed0b777663ca30afb7926c/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_win.h
[modify] https://crrev.com/5ed8bbb76b02111971ed0b777663ca30afb7926c/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_win.cc
[modify] https://crrev.com/5ed8bbb76b02111971ed0b777663ca30afb7926c/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_win.h
[modify] https://crrev.com/5ed8bbb76b02111971ed0b777663ca30afb7926c/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_win.h
[modify] https://crrev.com/5ed8bbb76b02111971ed0b777663ca30afb7926c/chrome/browser/safe_browsing/chrome_cleaner/mock_chrome_cleaner_controller_win.h
[modify] https://crrev.com/5ed8bbb76b02111971ed0b777663ca30afb7926c/chrome/browser/ui/views/chrome_cleaner_dialog_browsertest_win.cc
[modify] https://crrev.com/5ed8bbb76b02111971ed0b777663ca30afb7926c/chrome/browser/ui/views/chrome_cleaner_dialog_win.cc
[modify] https://crrev.com/5ed8bbb76b02111971ed0b777663ca30afb7926c/chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b06dc450243d14afecea2a0fc1de62b1457fc6f7

commit b06dc450243d14afecea2a0fc1de62b1457fc6f7
Author: Roger Tawa <rogerta@chromium.org>
Date: Wed Jun 13 22:30:38 2018

Cleanup policy caption and description.

Captions: Use Enable/Control instead of Enables/Controls for consistency.
Description: Use enabled/disabled instead of "set to true" and "set to false".

Bug:  834939 
Change-Id: Ie6552e87a9977046164874e981dde8e0725b1b6c
Reviewed-on: https://chromium-review.googlesource.com/1088872
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567019}
[modify] https://crrev.com/b06dc450243d14afecea2a0fc1de62b1457fc6f7/components/policy/resources/policy_templates.json

Comment 16 by vsemozhe...@gmail.com, Dec 2 

Can I disable software_reporter_tool after this issue fixed? It overloads CPU on both machines I use. Can you share the steps to disable it?
►

Sign in to add a comment