The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b724a7fcfa98dc94e9e941d21e7717242761e2b

commit 5b724a7fcfa98dc94e9e941d21e7717242761e2b
Author: David Valleau <valleau@chromium.org>
Date: Tue Apr 24 03:29:36 2018

Fixing GetPrinterInfo to include the autoconf and ppd_url fields

GetPrinterInfo was omitting the autoconf field which was causing
a "NOTREACHED" to be hit when attempting to edit an autoconf printer.
This change adds this field and also moves the GetPrinterInfo function
to be a free function in printer_translator so that it can be tested
more easily.

BUG= chromium:834911 
R=michaelpg@chromium.org, skau@chromium.org

Change-Id: I37145b71228afdeb6de9628365bf311d2e98b190
Reviewed-on: https://chromium-review.googlesource.com/1023118
Commit-Queue: David Valleau <valleau@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552989}
[modify] https://crrev.com/5b724a7fcfa98dc94e9e941d21e7717242761e2b/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/5b724a7fcfa98dc94e9e941d21e7717242761e2b/chromeos/printing/printer_translator.cc
[modify] https://crrev.com/5b724a7fcfa98dc94e9e941d21e7717242761e2b/chromeos/printing/printer_translator.h
[modify] https://crrev.com/5b724a7fcfa98dc94e9e941d21e7717242761e2b/chromeos/printing/printer_translator_unittest.cc

Landed in 68.0.3406.0

Not sure if we requested this merge back? Adding the tag in for M67 to be sure.

This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Assume this has been tested per #5 and confirmed no ill effects.  Is this a M67 regression or tied to a feature launch?

I can confirm that we can now change protocols and the port number for printers and there are no ill effects.  Verified on 68.0.3416.0.

I did notice that changing the hostname for some printers does not work  crbug.com/838677  but that bug is not new.

Still not clear if this is a bug introduced in M67 or in support of M68?

The bug was introduced in M67.

Bug was introduced here:

https://chromium-review.googlesource.com/c/chromium/src/+/971469/10/chrome/browser/resources/settings/printing_page/cups_edit_printer_dialog.html

Approving merge to M67 Chrome OS.

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70ec54edfc4595b8d00980e5d5ce7b6fda933e95

commit 70ec54edfc4595b8d00980e5d5ce7b6fda933e95
Author: David Valleau <valleau@chromium.org>
Date: Mon May 07 23:19:38 2018

Fixing GetPrinterInfo to include the autoconf and ppd_url fields

GetPrinterInfo was omitting the autoconf field which was causing
a "NOTREACHED" to be hit when attempting to edit an autoconf printer.
This change adds this field and also moves the GetPrinterInfo function
to be a free function in printer_translator so that it can be tested
more easily.

BUG= chromium:834911 
R=​michaelpg@chromium.org, skau@chromium.org

Change-Id: I37145b71228afdeb6de9628365bf311d2e98b190
Reviewed-on: https://chromium-review.googlesource.com/1023118
Commit-Queue: David Valleau <valleau@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#552989}(cherry picked from commit 5b724a7fcfa98dc94e9e941d21e7717242761e2b)
Reviewed-on: https://chromium-review.googlesource.com/1048706
Cr-Commit-Position: refs/branch-heads/3396@{#508}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/70ec54edfc4595b8d00980e5d5ce7b6fda933e95/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/70ec54edfc4595b8d00980e5d5ce7b6fda933e95/chromeos/printing/printer_translator.cc
[modify] https://crrev.com/70ec54edfc4595b8d00980e5d5ce7b6fda933e95/chromeos/printing/printer_translator.h
[modify] https://crrev.com/70ec54edfc4595b8d00980e5d5ce7b6fda933e95/chromeos/printing/printer_translator_unittest.cc