New issue
Advanced search Search tips

Issue 834908 link

Starred by 4 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
M-X

Blocking:
issue 845389



Sign in to add a comment

AppWindowAPITest suite fails in Mac Views mode

Project Member Reported by ellyjo...@chromium.org, Apr 19 2018

Issue description

Most of the failures come down to MacViews app windows *excluding* the window frame (the title bar) from "outerBounds", which is probably a bug. Chrome apps are dead on Mac so that issue is likely WontFix. One of the tests (TestMinimize) instead times out, probably for the same reason as  issue 424399 .
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f42884ddc4af0470fe3feb944d9fc2ab1849210a

commit f42884ddc4af0470fe3feb944d9fc2ab1849210a
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Thu Apr 19 20:18:45 2018

macviews: disable a handful of AppWindowAPITests

These tests don't work in Views mode.

TBR=tapted@chromium.org

Bug: 834908
Change-Id: I5c0fdb9043511264d8d6e4b096a66be80eeaf8bd
Reviewed-on: https://chromium-review.googlesource.com/1020082
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552142}
[modify] https://crrev.com/f42884ddc4af0470fe3feb944d9fc2ab1849210a/chrome/browser/apps/app_window_browsertest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d18f3ac6a468aae5b7814d28c055944ffe0b059c

commit d18f3ac6a468aae5b7814d28c055944ffe0b059c
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Tue May 08 20:22:08 2018

macviews: disable BrowserTest.TestPopupBounds

Popup bounds computations are a bit broken in MacViews.

Bug: 834908
Change-Id: Iab8f7a39a88d1d85b6a0d700c44eee9de8308e33
Reviewed-on: https://chromium-review.googlesource.com/1050191
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556945}
[modify] https://crrev.com/d18f3ac6a468aae5b7814d28c055944ffe0b059c/chrome/browser/ui/browser_browsertest.cc

Labels: Group-Tests
Blocking: 845389
Labels: Hotlist-DesktopUIChecked Hotlist-DesktopUIToolingRequired
*** UI Mass Triage ***

Sign in to add a comment