Issue 834897 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	█ pho...@chromium.org Last visit > 30 days ago
Closed:	Apr 2018
Cc:	akes...@chromium.org jclinton@chromium.org chromeos-continuous-integration-fire-hose@google.com
Components:	Infra>ChromeOS>CI
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	1
Type:	Bug

CL-Exonerator didn't forgive a change after CQ annotation

Project Member Reported by pho...@chromium.org, Apr 19 2018

Issue description

https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1017814

should have been exonerated when

https://chromiumos-build-annotator.googleplex.com/build_annotations/edit_annotations/master-paladin/2491861/

was annotated.

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/d0d63dec5ed0be13d00344035adf482ef0dc55b1

commit d0d63dec5ed0be13d00344035adf482ef0dc55b1
Author: Paul Hobbs <phobbs@google.com>
Date: Thu Apr 19 23:10:48 2018

gerrit_cq: Added a unit test case

In the linked bug, a CL wasn't exonerated that should have been.

Add its gerrit change info as a test case.

BUG= chromium:834897 
TEST=unit tests pass.

Change-Id: Ic92cd3785a41f84be954ab271ed361474f29ee81

[modify] https://crrev.com/d0d63dec5ed0be13d00344035adf482ef0dc55b1/exonerator/gerrit_precq_test.py
[add] https://crrev.com/d0d63dec5ed0be13d00344035adf482ef0dc55b1/exonerator/test_cases/ready_for_exoneration_1017814.json
[modify] https://crrev.com/d0d63dec5ed0be13d00344035adf482ef0dc55b1/exonerator/gerrit_cq_test.py

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/3d422a4178f99fda32921468effce9bf93e3b37e

commit 3d422a4178f99fda32921468effce9bf93e3b37e
Author: Paul Hobbs <phobbs@google.com>
Date: Fri Apr 20 18:57:40 2018

innocent_cls_cq: Don't ignore CLs with newer picked_up action

BUG= chromium:834897 
TEST=None, should add a case to the main_test

Change-Id: I10145545a2276a6341f3f40883b117d181af3578

[modify] https://crrev.com/3d422a4178f99fda32921468effce9bf93e3b37e/exonerator/innocent_cls_cq.py

Comment 3 by pho...@chromium.org, Apr 20 2018

Status: Fixed (was: Started)

►

Issue 834897 link

Issue metadata

CL-Exonerator didn't forgive a change after CQ annotation

Issue description

Comment 1 by bugdroid1@chromium.org, Apr 20 2018

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Apr 20 2018

Comment 2 Deleted

Comment 3 by pho...@chromium.org, Apr 20 2018

Comment 3 Deleted

Sign in to add a comment