New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 834866 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression

Blocking:
issue 842992



Sign in to add a comment

apps containing a web view become unresponsive during granularity movement with TalkBack

Project Member Reported by vtsaran@google.com, Apr 19 2018

Issue description

Steps to reproduce the problem:
1. Start TalkBack, Settings > Accessibility > TalkBack.
2. Open Chrome and type "data:text/html, <p>This is a test</p>" into the address bar (without quotes). The idea here is to generate a HTML output with just plain text on the page.
3. Touch once inside a web page to ensure the accessibility focus is inside a webview and the texct can be read.
4. Switch to "headings" granularity by swiping down once with one finger. TalkBack should say "headings and landmarks".
5. Swipe left once to ask Talkback for a previous heading on the page.

What is the expected behavior?
Talkback should say "no previous heading found".

What went wrong?
TalkBack may or may not say "no previous heading found". However, immediately after that Chrome will freeze and eventually end up with an "application not responding" message.

Crashed report ID: 

How much crashed? Whole browser

Is it a problem with a plugin? No 

Did this work before? Yes 65.0

Chrome version: 66.0  Channel: stable
OS Version: Android 8.0
Flash Version:
 
Cc: dmazz...@chromium.org vtsaran@chromium.org
Labels: -Pri-2 -Via-Wizard-Crashes ReleaseBlock-Stable M-66 M-67 Pri-1
Owner: ibobra@chromium.org
Status: Assigned (was: Unconfirmed)
Reverting suspected change here:
https://chromium-review.googlesource.com/c/chromium/src/+/1019960

Google internal bug: b/77826986

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c89b77ae1e33f331ee6766e89c5c41530675aa36

commit c89b77ae1e33f331ee6766e89c5c41530675aa36
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Thu Apr 19 21:41:44 2018

Revert "Android Accessibility: Set flag to enable jump to last element on ACTION_PREVIOUS_HTML_ELEMENT"

This reverts commit 90d351407da304eb29e4b94ab937a527fe7f2347.

Reason for revert: infinite loop ( crbug.com/834866 )

Original change's description:
> Android Accessibility: Set flag to enable jump to last element on ACTION_PREVIOUS_HTML_ELEMENT
>
> This CL is a followup on the following CL:
> https://chromium-review.googlesource.com/736043
>
> The above CL returns the deepest child of web view on ACTION_PREVIOUS_HTML_ELEMENT if
> can_wrap_to_last_element flag in OneShotAccessibilityTreeSearch is set to true.
> This CL sets that flag for Android. Assuming a web view is in between native elements, the
> following order will be followed for a11y focus:
> Native elements -> web view container -> inside web view container -> native elements.
> So web view container will always be focused only in the above order.
>
> Bug: 661793
> Change-Id: I62dbcb143ed5a152172dc7cde9355f4b7eed79e1
> Reviewed-on: https://chromium-review.googlesource.com/884302
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#536742}

TBR=dmazzoni@chromium.org,ibobra@google.com
NOTRY=true

Bug: 661793,  834866 
Change-Id: I3dc34c17908aa06c33a904415d10fc0d5a56fc2c
Reviewed-on: https://chromium-review.googlesource.com/1019960
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552169}
[modify] https://crrev.com/c89b77ae1e33f331ee6766e89c5c41530675aa36/content/browser/accessibility/web_contents_accessibility_android.cc

Labels: Merge-Request-67 Merge-Request-66
@ibobra manually verified that the revert fixes the issue.

We'd like to merge this to both M67 and M66, understanding that M66 has already been released - we'd like to try to push a new build as soon as possible. Thanks.


Project Member

Comment 5 by sheriffbot@chromium.org, Apr 19 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 19 2018

Labels: -Merge-Request-66 Merge-Review-66
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by cma...@chromium.org, Apr 19 2018

Labels: -Merge-Review-67 Merge-Approved-67
Approved for M67. Need to understand the impact on M66 before approving the merge there. You can already merge into M67 now.

Comment 8 by cma...@chromium.org, Apr 19 2018

Labels: -Hotlist-Merge-Review -Merge-Review-66 Merge-Approved-66
Though I am still trying to understand how severe this issue is, let's merge it into M66 already. If it is indeed the main driver of a respin, we will respin for it. Thank you!
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 20 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47eaf929d3aec09fe679243c31b782b462e7c7bc

commit 47eaf929d3aec09fe679243c31b782b462e7c7bc
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Fri Apr 20 16:31:57 2018

Revert "Android Accessibility: Set flag to enable jump to last element on ACTION_PREVIOUS_HTML_ELEMENT"

This reverts commit 90d351407da304eb29e4b94ab937a527fe7f2347.

Reason for revert: infinite loop ( crbug.com/834866 )

Original change's description:
> Android Accessibility: Set flag to enable jump to last element on ACTION_PREVIOUS_HTML_ELEMENT
>
> This CL is a followup on the following CL:
> https://chromium-review.googlesource.com/736043
>
> The above CL returns the deepest child of web view on ACTION_PREVIOUS_HTML_ELEMENT if
> can_wrap_to_last_element flag in OneShotAccessibilityTreeSearch is set to true.
> This CL sets that flag for Android. Assuming a web view is in between native elements, the
> following order will be followed for a11y focus:
> Native elements -> web view container -> inside web view container -> native elements.
> So web view container will always be focused only in the above order.
>
> Bug: 661793
> Change-Id: I62dbcb143ed5a152172dc7cde9355f4b7eed79e1
> Reviewed-on: https://chromium-review.googlesource.com/884302
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#536742}

TBR=dmazzoni@chromium.org,ibobra@google.com
NOTRY=true

Bug: 661793,  834866 
Change-Id: I3dc34c17908aa06c33a904415d10fc0d5a56fc2c
Reviewed-on: https://chromium-review.googlesource.com/1019960
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#552169}(cherry picked from commit c89b77ae1e33f331ee6766e89c5c41530675aa36)
Reviewed-on: https://chromium-review.googlesource.com/1022014
Cr-Commit-Position: refs/branch-heads/3359@{#744}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/47eaf929d3aec09fe679243c31b782b462e7c7bc/content/browser/accessibility/web_contents_accessibility_android.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 20 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/721f3d856e8e0a80e266264d2746bb08dbf21174

commit 721f3d856e8e0a80e266264d2746bb08dbf21174
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Fri Apr 20 16:32:03 2018

Revert "Android Accessibility: Set flag to enable jump to last element on ACTION_PREVIOUS_HTML_ELEMENT"

This reverts commit 90d351407da304eb29e4b94ab937a527fe7f2347.

Reason for revert: infinite loop ( crbug.com/834866 )

Original change's description:
> Android Accessibility: Set flag to enable jump to last element on ACTION_PREVIOUS_HTML_ELEMENT
>
> This CL is a followup on the following CL:
> https://chromium-review.googlesource.com/736043
>
> The above CL returns the deepest child of web view on ACTION_PREVIOUS_HTML_ELEMENT if
> can_wrap_to_last_element flag in OneShotAccessibilityTreeSearch is set to true.
> This CL sets that flag for Android. Assuming a web view is in between native elements, the
> following order will be followed for a11y focus:
> Native elements -> web view container -> inside web view container -> native elements.
> So web view container will always be focused only in the above order.
>
> Bug: 661793
> Change-Id: I62dbcb143ed5a152172dc7cde9355f4b7eed79e1
> Reviewed-on: https://chromium-review.googlesource.com/884302
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#536742}

TBR=dmazzoni@chromium.org,ibobra@google.com
NOTRY=true

Bug: 661793,  834866 
Change-Id: I3dc34c17908aa06c33a904415d10fc0d5a56fc2c
Reviewed-on: https://chromium-review.googlesource.com/1019960
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#552169}(cherry picked from commit c89b77ae1e33f331ee6766e89c5c41530675aa36)
Reviewed-on: https://chromium-review.googlesource.com/1022015
Cr-Commit-Position: refs/branch-heads/3396@{#163}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/721f3d856e8e0a80e266264d2746bb08dbf21174/content/browser/accessibility/web_contents_accessibility_android.cc

"Chrome on Android" -> we can repro this issue with 66.0.3359.106 build on below devices:
Nexus6/MRA59G
Pixel 2/OPM4.171019.015.A1, 
Samsung Galaxy S3 Mini/JZ054K
MEIZU Pro 7 Plus/NRD90M

Talkback version:6.1.0.186797687
Able to reproduce on Feedly app not responding due to ANR on Pixel 2XL (PPR1.180419.001 having 67.0.3396.11 and chrome with nytimes.com encountered ANR with the same repro steps.Another Observation on Pixel/OPM1.171019.028 with talk back 6.1.0 having 66.0.3359.106 , ANR on talkback not responding when reproducing the steps mentioned in Comment #0 .
Chrome Android: Works as per expected behavior with out any ANR message. 
Issue is fixed on 66.0.3359.126
Fix issue verified on latest M66:66.0.3359.126 as per#0

Thanks!
Verified/Fixed on Moto G4 Plus/NPJS25.93-14-8.1-1/ 66.0.3359.126 on webview shell broswer and Amazon 

Comment 16 by cmasso@google.com, Apr 24 2018

	ibobra@ Please close this issue
Status: Fixed (was: Assigned)
Blocking: 842992

Sign in to add a comment