New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 834839 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Build-Toolchain



Sign in to add a comment

llvm-next failed to compile chrome on arm with thinlto enabled.

Project Member Reported by yunlian@chromium.org, Apr 19 2018

Issue description

In https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8948873031156686784


ld.gold.real: /var/tmp/portage/sys-devel/llvm-7.0_pre326829_p20180318-r12/work/llvm-7.0_pre326829_p20180318/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:1233: bool llvm::DwarfUnit::applySubprogramDefinitionAttributes(const llvm::DISubprogram *, llvm::DIE &): Assertion `DeclDie && "This DIE should've already been constructed when the " "definition DIE was created in " "getOrCreateSubprogramDIE"' failed.
chromeos-chrome-68.0.3399.0_rc-r1: clang-7: error: unable to execute command: Aborted (core dumped)
chromeos-chrome-68.0.3399.0_rc-r1: clang-7: error: linker command failed due to signal (use -v to see invocation)
chromeos-chrome-68.0.3399.0_rc-r1: ninja: build stopped: subcommand failed.
chromeos-chrome-68.0.3399.0_rc-r1:  * ERROR: chromeos-base/chromeos-chrome-68.0.3399.0_rc-r1::chromiumos failed (compile phase):
chromeos-chrome-68.0.3399.0_rc-r1:  *   (no error message)
 
This is an assertion error so it could happen on current llvm if we build it with assert enabled.

Comment 2 by cmt...@chromium.org, Apr 20 2018

Perhaps we should set up a test builder to regularly run with LLVM asserts enabled -- this is not the first time we've run into an issue where LLVM asserts would have caught it, if enabled...
Labels: OS-Chrome
Adding debug use flag to clang/llvm in package.use should enable asserts. Should be easy to test with that using tryjobs. 
Project Member

Comment 4 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/96be3f695bba0d53e3128b9164f80fdf9d7d81e6

commit 96be3f695bba0d53e3128b9164f80fdf9d7d81e6
Author: Yunlian Jiang <yunlian@google.com>
Date: Fri May 04 10:11:53 2018

chromeos-chrome: remove -fdebug-info-for-profiling for ARM

We added the -fdebug-info-for-profiling flag because we want to get AFDO
profile from perf. Currently we do not use ARM machine to collect
profiles. so this flag is useless for arm. In addition, it caused an
LLVM assertion when thinlto and debug fission is use. While working on
LLVM to have a fix there, we want to remove this flag so that we can
test thinlto for ARM.

BUG= chromium:834839 
TEST=the llvm assertion is gone.

Change-Id: Ie768a79e1cffb8eeb3d85ae1bdfcedd5e6f3c27c
Reviewed-on: https://chromium-review.googlesource.com/1041652
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>

[modify] https://crrev.com/96be3f695bba0d53e3128b9164f80fdf9d7d81e6/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

Status: Verified (was: Untriaged)

Sign in to add a comment