thread_times.key_silk_cases/http://www.google.com/#q=google in thread_times.key_silk_cases failing on multiple builders |
|||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of eyaich@google.com thread_times.key_silk_cases/http://www.google.com/#q=google in thread_times.key_silk_cases failing on multiple builders Builders failed on: - Android Nexus5 Perf: https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf - Android Nexus5X Perf: https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf - Android Nexus6 Perf: https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf - Android One Perf: https://build.chromium.org/p/chromium.perf/builders/Android%20One%20Perf
,
Apr 19 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14a8d176c40000
,
Apr 19 2018
Potential this might be the same culprit as crbug.com/834829 given they are failing at the same build witht he same strack trace.
,
Apr 19 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/14a8d176c40000 Update top offset of motion events on hover in CompositorViewHolder by tiborg@chromium.org https://chromium.googlesource.com/chromium/src/+/0ef4af14dff5f447bc8746e7aa1634c3adcdd3bb Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfb8e5a85ff1b59d10b521690e5e080583bdfeeb commit dfb8e5a85ff1b59d10b521690e5e080583bdfeeb Author: Ned Nguyen <nednguyen@google.com> Date: Thu Apr 19 22:16:41 2018 Revert "Update top offset of motion events on hover in CompositorViewHolder" This reverts commit 0ef4af14dff5f447bc8746e7aa1634c3adcdd3bb. Reason for revert: break Telemetry tests BUG:834833 Original change's description: > Update top offset of motion events on hover in CompositorViewHolder > > When entering VR we hide the browser controls. However, it can take some > time for this state update to reach the FullscreenManager. As a > consequence, hover move events may have a false offset depending on > whether the initial hover enter event was processed with the updated > browser controls state or not. To fix that, also update the top offset > for hover move events. > > Bug: 822384 > Change-Id: I196a38098f736d6a9c8066b0a48cafa774ea1864 > Reviewed-on: https://chromium-review.googlesource.com/1014708 > Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551502} TBR=mdjones@chromium.org,jinsukkim@chromium.org,tiborg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 822384 Change-Id: Ibb0dd8b2fe110e9f7ecd7785604f956fede4bfd3 Reviewed-on: https://chromium-review.googlesource.com/1020240 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#552183} [modify] https://crrev.com/dfb8e5a85ff1b59d10b521690e5e080583bdfeeb/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
,
Apr 19 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by eyaich@chromium.org
, Apr 19 2018Components: Speed>Benchmarks>Waterfall
Labels: OS-Android
Owner: vmi...@chromium.org