New issue
Advanced search Search tips

Issue 834833 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----



Sign in to add a comment

thread_times.key_silk_cases/http://www.google.com/#q=google in thread_times.key_silk_cases failing on multiple builders

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Apr 19 2018

Issue description

Comment 1 by eyaich@chromium.org, Apr 19 2018

Cc: -eyaich@google.com eyaich@chromium.org
Components: Speed>Benchmarks>Waterfall
Labels: OS-Android
Owner: vmi...@chromium.org
Failing task: https://chromium-swarm.appspot.com/task?id=3cf2e10aaa2aad10&refresh=10&show_raw=1

Logs show something to do with the metric: 

metry/artifacts'
Traceback (most recent call last):
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 123, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "/b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 313, in RunStory
    self._current_page, self._current_tab, results)
  File "/b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/swarming/w/ir/tools/perf/measurements/smoothness.py", line 76, in ValidateAndMeasurePage
    metric.AddResults(model, renderer_thread, records, results)
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/web_perf/metrics/smoothness.py", line 54, in AddResults
    self.VerifyNonOverlappedRecords(interaction_records)
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/web_perf/metrics/timeline_based_metric.py", line 84, in VerifyNonOverlappedRecords
    if _TimeRangesHasOverlap(((r.start, r.end) for r in interaction_records)):
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/web_perf/metrics/timeline_based_metric.py", line 19, in _TimeRangesHasOverlap
    last_range = sorted_time_ranges[0]

Comment 3 by eyaich@chromium.org, Apr 19 2018

Potential  this might be the same culprit as  crbug.com/834829  given they are failing at the same build witht he same strack trace.
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Apr 19 2018

Cc: mdjones@chromium.org jinsuk...@chromium.org tiborg@chromium.org
Owner: tiborg@chromium.org
Status: Assigned (was: Available)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14a8d176c40000

Update top offset of motion events on hover in CompositorViewHolder by tiborg@chromium.org
https://chromium.googlesource.com/chromium/src/+/0ef4af14dff5f447bc8746e7aa1634c3adcdd3bb

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfb8e5a85ff1b59d10b521690e5e080583bdfeeb

commit dfb8e5a85ff1b59d10b521690e5e080583bdfeeb
Author: Ned Nguyen <nednguyen@google.com>
Date: Thu Apr 19 22:16:41 2018

Revert "Update top offset of motion events on hover in CompositorViewHolder"

This reverts commit 0ef4af14dff5f447bc8746e7aa1634c3adcdd3bb.

Reason for revert: break Telemetry tests
BUG:834833

Original change's description:
> Update top offset of motion events on hover in CompositorViewHolder
> 
> When entering VR we hide the browser controls. However, it can take some
> time for this state update to reach the FullscreenManager. As a
> consequence, hover move events may have a false offset depending on
> whether the initial hover enter event was processed with the updated
> browser controls state or not. To fix that, also update the top offset
> for hover move events.
> 
> Bug:  822384 
> Change-Id: I196a38098f736d6a9c8066b0a48cafa774ea1864
> Reviewed-on: https://chromium-review.googlesource.com/1014708
> Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
> Reviewed-by: Matthew Jones <mdjones@chromium.org>
> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551502}

TBR=mdjones@chromium.org,jinsukkim@chromium.org,tiborg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  822384 
Change-Id: Ibb0dd8b2fe110e9f7ecd7785604f956fede4bfd3
Reviewed-on: https://chromium-review.googlesource.com/1020240
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#552183}
[modify] https://crrev.com/dfb8e5a85ff1b59d10b521690e5e080583bdfeeb/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java

Comment 6 by tiborg@chromium.org, Apr 19 2018

Status: Fixed (was: Assigned)

Sign in to add a comment