New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 834801 link

Starred by 1 user
Status: Fixed
Owner:
eui-sang.lim@samsung.com
Closed: Jul 17
Cc:
agrieve@chromium.org
█ nyquist@chromium.org
█ wnwen@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug


Participants' hotlists:
ErrorProne-Fixes


Sign in to add a comment

Fix parcelable implementations without CREATOR in code

Project Member Reported by wnwen@chromium.org, Apr 19 2018 
1. Read http://errorprone.info/bugpattern/ParcelableCreator
2. Remove 'ParcelableCreator' suppression for errorprone.
3. Fix or suppress each instance in code.
4. Upgrade 'ParcelableCreator' to errorprone error to prevent future regressions.

Comment 1 by eui-sang.lim@samsung.com, Jul 12

Owner: eui-sang.lim@samsung.com
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c0c0084e0fe878dd1f5b784d712e57d547452c7

commit 9c0c0084e0fe878dd1f5b784d712e57d547452c7
Author: Amos Lim <eui-sang.lim@samsung.com>
Date: Mon Jul 16 16:54:34 2018

Fix parcelable implementations without CREATOR in code

Fix 'ParcelableCreator' and upgrade it to errorprone error
to prevent future regressions.

Bug:  834801 
Change-Id: Ifef1abd12505779a23294cb4ba976685120d9b90
Reviewed-on: https://chromium-review.googlesource.com/1135110
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Amos Lim <eui-sang.lim@samsung.com>
Cr-Commit-Position: refs/heads/master@{#575313}
[modify] https://crrev.com/9c0c0084e0fe878dd1f5b784d712e57d547452c7/build/android/gyp/javac.py
[modify] https://crrev.com/9c0c0084e0fe878dd1f5b784d712e57d547452c7/chrome/android/javatests/src/org/chromium/chrome/browser/document/LauncherActivityTest.java
[modify] https://crrev.com/9c0c0084e0fe878dd1f5b784d712e57d547452c7/components/sync/android/java/src/org/chromium/components/sync/PassphraseType.java

Comment 3 by eui-sang.lim@samsung.com, Jul 17

Status: Fixed (was: Started)
►

Sign in to add a comment