New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 834796 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 12
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug


Participants' hotlists:
ErrorProne-Fixes


Sign in to add a comment

Fix format string without passing in the variables in code

Project Member Reported by wnwen@chromium.org, Apr 19 2018

Issue description

1. Read http://errorprone.info/bugpattern/OrphanedFormatString
2. Remove 'OrphanedFormatString' suppression for errorprone.
3. Fix or suppress each instance in code.
4. Upgrade 'OrphanedFormatString' to errorprone error to prevent future regressions.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68c461c15c28ffe895f01e0f9a106564b10c5101

commit 68c461c15c28ffe895f01e0f9a106564b10c5101
Author: Amos Lim <eui-sang.lim@samsung.com>
Date: Thu Jul 12 14:58:52 2018

Fix format string without passing in the variables in code

Fix 'OrphanedFormatString' and upgrade it to errorprone error
to prevent future regressions.

Bug:  834796 
Change-Id: Iff82021736367190cfd45b64ee7134cb40392449
Reviewed-on: https://chromium-review.googlesource.com/1134828
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Amos Lim <eui-sang.lim@samsung.com>
Cr-Commit-Position: refs/heads/master@{#574560}
[modify] https://crrev.com/68c461c15c28ffe895f01e0f9a106564b10c5101/base/test/android/javatests/src/org/chromium/base/test/params/ParameterizedRunner.java
[modify] https://crrev.com/68c461c15c28ffe895f01e0f9a106564b10c5101/build/android/gyp/javac.py

Owner: eui-sang.lim@samsung.com
Status: Fixed (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/046a36b7ca0df405ba0feb51ef2f2f00e2916555

commit 046a36b7ca0df405ba0feb51ef2f2f00e2916555
Author: Amos Lim <eui-sang.lim@samsung.com>
Date: Tue Jul 24 00:07:36 2018

Move 'OrphanedFormatString' to to the list of errors

'OrphanedFormatString' was only removed in
ERRORPRONE_WARNINGS_TO_TURN_OFF. It should be added
to ERRORPRONE_WARNINGS_TO_ERROR.
It is a follow-up to https://crrev.com/c/1134828.

Bug:  834796 
Change-Id: I801d2514ec40c22ee48fdb44a0f6975ff892d8d8
Reviewed-on: https://chromium-review.googlesource.com/1144990
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Amos Lim <eui-sang.lim@samsung.com>
Cr-Commit-Position: refs/heads/master@{#577355}
[modify] https://crrev.com/046a36b7ca0df405ba0feb51ef2f2f00e2916555/build/android/gyp/javac.py

Sign in to add a comment