Fix format string without passing in the variables in code |
||
Issue description1. Read http://errorprone.info/bugpattern/OrphanedFormatString 2. Remove 'OrphanedFormatString' suppression for errorprone. 3. Fix or suppress each instance in code. 4. Upgrade 'OrphanedFormatString' to errorprone error to prevent future regressions.
,
Jul 12
,
Jul 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/046a36b7ca0df405ba0feb51ef2f2f00e2916555 commit 046a36b7ca0df405ba0feb51ef2f2f00e2916555 Author: Amos Lim <eui-sang.lim@samsung.com> Date: Tue Jul 24 00:07:36 2018 Move 'OrphanedFormatString' to to the list of errors 'OrphanedFormatString' was only removed in ERRORPRONE_WARNINGS_TO_TURN_OFF. It should be added to ERRORPRONE_WARNINGS_TO_ERROR. It is a follow-up to https://crrev.com/c/1134828. Bug: 834796 Change-Id: I801d2514ec40c22ee48fdb44a0f6975ff892d8d8 Reviewed-on: https://chromium-review.googlesource.com/1144990 Reviewed-by: Peter Wen <wnwen@chromium.org> Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Cr-Commit-Position: refs/heads/master@{#577355} [modify] https://crrev.com/046a36b7ca0df405ba0feb51ef2f2f00e2916555/build/android/gyp/javac.py |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jul 12