New issue
Advanced search Search tips

Issue 834780 link

Starred by 2 users
Status: Fixed
Owner:
jbroman@chromium.org
Closed: Nov 22
Cc:
dcheng@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

is8_bit should be is_8bit

Project Member Reported by tkent@chromium.org, Apr 19 2018 
https://cs.chromium.org/search/?q=is8_bit&sq=package:chromium&type=cs

Variables such as WTF::StringImpl::is8_bit_ should be is_8bit_ or is_8_bit_.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08cce5150fe77d2f8dfe9cd977e1e98600056b5f

commit 08cce5150fe77d2f8dfe9cd977e1e98600056b5f
Author: Jeremy Roman <jbroman@chromium.org>
Date: Thu Nov 22 17:50:31 2018

Rename *is8_bit* to *is_8bit*.

Bug:  834780 
Change-Id: Id4075554850a5f63cf40087072091503335da41e
Reviewed-on: https://chromium-review.googlesource.com/c/1347430
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610457}
[modify] https://crrev.com/08cce5150fe77d2f8dfe9cd977e1e98600056b5f/third_party/blink/renderer/core/css/parser/css_parser_token.cc
[modify] https://crrev.com/08cce5150fe77d2f8dfe9cd977e1e98600056b5f/third_party/blink/renderer/core/css/parser/css_parser_token.h
[modify] https://crrev.com/08cce5150fe77d2f8dfe9cd977e1e98600056b5f/third_party/blink/renderer/core/html/track/vtt/vtt_scanner.cc
[modify] https://crrev.com/08cce5150fe77d2f8dfe9cd977e1e98600056b5f/third_party/blink/renderer/core/html/track/vtt/vtt_scanner.h
[modify] https://crrev.com/08cce5150fe77d2f8dfe9cd977e1e98600056b5f/third_party/blink/renderer/core/svg/svg_path_string_source.cc
[modify] https://crrev.com/08cce5150fe77d2f8dfe9cd977e1e98600056b5f/third_party/blink/renderer/core/svg/svg_path_string_source.h
[modify] https://crrev.com/08cce5150fe77d2f8dfe9cd977e1e98600056b5f/third_party/blink/renderer/core/xml/parser/xml_document_parser.cc
[modify] https://crrev.com/08cce5150fe77d2f8dfe9cd977e1e98600056b5f/third_party/blink/renderer/platform/text/segmented_string.h
[modify] https://crrev.com/08cce5150fe77d2f8dfe9cd977e1e98600056b5f/third_party/blink/renderer/platform/text/text_break_iterator.h
[modify] https://crrev.com/08cce5150fe77d2f8dfe9cd977e1e98600056b5f/third_party/blink/renderer/platform/text/text_break_iterator_icu.cc
[modify] https://crrev.com/08cce5150fe77d2f8dfe9cd977e1e98600056b5f/third_party/blink/renderer/platform/text/text_run.cc
[modify] https://crrev.com/08cce5150fe77d2f8dfe9cd977e1e98600056b5f/third_party/blink/renderer/platform/text/text_run.h
[modify] https://crrev.com/08cce5150fe77d2f8dfe9cd977e1e98600056b5f/third_party/blink/renderer/platform/wtf/text/string_builder.cc
[modify] https://crrev.com/08cce5150fe77d2f8dfe9cd977e1e98600056b5f/third_party/blink/renderer/platform/wtf/text/string_builder.h
[modify] https://crrev.com/08cce5150fe77d2f8dfe9cd977e1e98600056b5f/third_party/blink/renderer/platform/wtf/text/string_impl.cc
[modify] https://crrev.com/08cce5150fe77d2f8dfe9cd977e1e98600056b5f/third_party/blink/renderer/platform/wtf/text/string_impl.h
[modify] https://crrev.com/08cce5150fe77d2f8dfe9cd977e1e98600056b5f/third_party/blink/tools/gdb/blink.py
[modify] https://crrev.com/08cce5150fe77d2f8dfe9cd977e1e98600056b5f/third_party/blink/tools/lldb/lldb_blink.py

Comment 2 by jbroman@chromium.org, Nov 22

Owner: jbroman@chromium.org
Status: Fixed (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8c871010d4a32de6dda3a8e1cfd5adde43c1fcb

commit e8c871010d4a32de6dda3a8e1cfd5adde43c1fcb
Author: Koji Ishii <kojii@chromium.org>
Date: Tue Nov 27 01:10:00 2018

DebugVisualizer: rename `is8_bit` to `is_8bit`

`is8_bit` was renamed to `is_8bit` in r610457 (CL:1347430).

This patch matches `webkit.natvis` to the new naming.

Tested with natvis warning enabled in VS2017 15.7.1.

Bug:  834780 
Change-Id: I7b4dc417e195c530aa36ec387ed6c5f111782d4a
Reviewed-on: https://chromium-review.googlesource.com/c/1350387
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610988}
[modify] https://crrev.com/e8c871010d4a32de6dda3a8e1cfd5adde43c1fcb/tools/win/DebugVisualizers/webkit.natvis
►

Sign in to add a comment