Most tests in autofill_interactive_uitests.cc are flaky on ChromeOS |
||||
Issue descriptionOS: ChromeOS Merging several bugs in a single one to make it easier to track. As of today, 20 out of 37 tests in autofill_interactive_uitests.cc are disabled on ChromeOS due to flakiness. After landing crrev.com/c/1005888, six more tests became flaky, for the same reason (not sure why they were not flaky before though): https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYzM5OTFmZTFhOGMzYThkODgwNWQ2NDVlMjllN2Y4YWY1OGFjMzY2YQw After investigating, the cause seems to be Ash getting shelf alignment async ( https://crbug.com/834369 ). Sometimes, that leads to the window being resized and the autofill dropdown being hidden while we are waiting for a click to unblock the test. The test then hangs and times out. We couldn't find an easy fix on our side and that flakiness is currently blocking automated tests for 768881, which is high priority for the team. On the other hand, the code flow on our side for ChromeOS is essentially the same as Linux, so we still get some coverage, even though it's not ideal. The following plan is proposed: 1. Disabled today those tests on ChromeOS 2. Track progress on https://crbug.com/834369 3a. [ideal situation] Re-enable those tests once the bug is fixed. 3b. [worst case scenario] Reevaluate the decision in a few weeks (either keep the tests disabled or contributing to fix the bug in Ash).
,
Apr 19 2018
,
Apr 19 2018
Issue 833176 has been merged into this issue.
,
Apr 19 2018
Issue 833219 has been merged into this issue.
,
Apr 19 2018
Issue 833237 has been merged into this issue.
,
Apr 19 2018
Issue 419868 has been merged into this issue.
,
Apr 19 2018
Issue 516052 has been merged into this issue.
,
Apr 19 2018
Issue 578095 has been merged into this issue.
,
Apr 19 2018
,
Apr 19 2018
,
Apr 19 2018
,
Apr 19 2018
Issue 827797 has been merged into this issue.
,
Apr 19 2018
Issue 709531 has been merged into this issue.
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bca4759098f8e34696b69291dc35652e64be17a3 commit bca4759098f8e34696b69291dc35652e64be17a3 Author: Fabio Tirelo <ftirelo@chromium.org> Date: Thu Apr 19 19:16:45 2018 [af] Disable Autofill interactive UI tests on ChromeOS Autofill interactive UI tests are flaky due to https://crbug.com/834369 . We couldn't find an easy fix on our side and that flakiness is currently blocking automated tests for 768881, which is high priority. On the other hand, the code flow on our side for ChromeOS is essentially the same as Linux, so we still get some coverage, even though it's not ideal. Bug: 834768 Change-Id: I5f44c37a2bd8902c04b96a712eb0fe8141afbf83 Reviewed-on: https://chromium-review.googlesource.com/1019840 Reviewed-by: Roger McFarlane <rogerm@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#552111} [modify] https://crrev.com/bca4759098f8e34696b69291dc35652e64be17a3/chrome/browser/autofill/autofill_interactive_uitest.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6a058bbedd2afe2a63d67159d00968eb845eecf commit e6a058bbedd2afe2a63d67159d00968eb845eecf Author: Mike Wasserman <msw@chromium.org> Date: Tue Apr 24 15:23:48 2018 Ash: Fix test flakiness from aync shelf alignment. The 1st patch set triggers the flaky failure reliably and adds a fix. The proposed fix inits display work areas with BOTTOM_LOCKED insets. (prevents test flakes on async shelf alignment init and bounds changes) The 2nd patch set removes the trigger and re-enables autofill tests. This may cause window movement on left/right alignment user login? (if windows from a prior session are restored before shelf alignment) Alternative fix ideas: 1) Always initialize the primary display's shelf to BOTTOM alignment? (matches login appearance, keep secondary display shelves hidden) 2) Have InProcessBrowserTest init the alignment synchronously? (limits the workaround's scope to tests, where symptoms are felt) 3) Make (tests) wait for shelf init before loading user windows? Bug: 834369 , 834768 Test: No AutofillInteractiveTests flakes on Chrome OS. Change-Id: Ibb8ea879a81ff198a1a29e6c8de73cb5e8acd3c4 Reviewed-on: https://chromium-review.googlesource.com/1020195 Reviewed-by: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#553126} [modify] https://crrev.com/e6a058bbedd2afe2a63d67159d00968eb845eecf/ash/display/display_manager_unittest.cc [modify] https://crrev.com/e6a058bbedd2afe2a63d67159d00968eb845eecf/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/e6a058bbedd2afe2a63d67159d00968eb845eecf/chrome/browser/autofill/autofill_interactive_uitest.cc
,
Apr 24 2018
My CL re-enabled all the Chrome OS flaky disabled tests and hopefully fixed the flakiness. Please let me know if you observe any further flakes related to the work area. Note that this bug is still cited for NoAutofillForReadOnlyFields
,
Apr 24 2018
Thanks a lot for the fix! I will double check NoAutofillForReadOnlyFields and close this bug.
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2204ed53008ff890498a8b454eb8a68f097b0582 commit 2204ed53008ff890498a8b454eb8a68f097b0582 Author: Fabio Tirelo <ftirelo@chromium.org> Date: Wed Apr 25 15:28:51 2018 [af] Renable NoAutofillForReadOnlyFields that is no longer flaky Bug: 834768 Change-Id: Ic51bcfdc7e63baca348c405f7e1f13c06d95b1f3 Reviewed-on: https://chromium-review.googlesource.com/1027899 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#553568} [modify] https://crrev.com/2204ed53008ff890498a8b454eb8a68f097b0582/chrome/browser/autofill/autofill_interactive_uitest.cc
,
Apr 25 2018
\o/
,
Nov 29
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ftirelo@chromium.org
, Apr 19 2018