New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 834766 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Outline of cast overlay is not seen properly.

Reported by aiman.an...@etouch.net, Apr 19 2018

Issue description

Chrome Version: 68.0.3400.0 (Official Build) Revision 9f775bf70a07668811dfc3b55bbd2e5f9c910fd0-refs/heads/master@{#551875} (64-Bit).

OS: MAC(Touch Bar 10.13.5).

What steps will reproduce the problem?
(1) Launch chrome, open NTP, right click and select Cast from context menu.

Actual: Cast overlay outline is not seen properly.

Expected: Cast overlay outline should be seen.

This is a regression issue, broken in 'M-68' below is the change-log url.
(Tried to bisect using old and new bisect script but getting trace-back error in both the scripts hence providing suspect through change-log)

Good Build: 67.0.3396.0
Bad Build: 68.0.3397.0

CHANGE-LOG URL:

https://chromium.googlesource.com/chromium/src/+log/67.0.3396.0..68.0.3397.0?pretty=fuller&n=10000

Suspecting: r550722?

takumif: Kindly help to re-assign if your change is not the cause for this issue.

Note: To repro issue consistently, try opening/closing cast overlay three-four times.


 
Actual Result.mov
2.9 MB View Download
Expected Result.mov
6.6 MB View Download
Components: -UI>Browser>Touchbar UI>Browser>WebUI
Owner: aiman.an...@etouch.net
This looks like an issue with the WebUI dialog implementation. I wasn't able to reproduce this with 68.0.3400.0 on my Mac Pro.
aiman.ansari@, can you see if you can reproduce this with the print dialog?
Owner: taku...@chromium.org
Hi Takumif,

I tested for Print dialog on latest Canary #68.0.3401.0, and was not able to reproduce the issue on Mac Touchbar(10.13.5).
Owner: aiman.an...@etouch.net
Thank you for checking Aiman. Unfortunately I'm still not able to reproduce the bug.
Would you mind testing whether you can reproduce it with the following flags enabled in chrome://flags?
#secondary-ui-md
#show-all-dialogs-with-views-toolkit

Owner: taku...@chromium.org
Hi Takumif,

I tested for Cast dialog overlay on latest Canary #68.0.3406.0, using #secondary-ui-md and #show-all-dialogs-with-views-toolkit and was able to reproduce the issue on Mac Touchbar(10.13.5).

Attaching screencast for reference.

Thank You!
Current_Result.mov
5.5 MB View Download

Comment 5 by mfo...@chromium.org, Apr 25 2018

Cc: msw@chromium.org bsep@chromium.org
There are a massive number of views/ patches landed in that revision range.  Maybe bsep@ or msw@ would be able to help narrow down the list of suspects.

Comment 6 by msw@chromium.org, Apr 25 2018

Nothing really stands out to me in that range, sorry. I'd look at the cls that cite cast, I guess.
There are a couple blink cls that mention border, but I imagine that dialog is using a views border.
Cc: dbbrooks@chromium.org
+David, is this something you've seen recently?
Actually, yes, I saw it. IIRC, it may have been when I was testing 6718.409.0.0. But I wasn't able to get a consistent repro so I didn't log a bug. I'm testing 67.0.3396.18 today and haven't seen it there.

Comment 9 by mfo...@chromium.org, May 29 2018

takumif@ is this another mac views blocker?  Who would be the right owner for this?
Owner: aiman.an...@etouch.net
aiman.ansari@, would you mind checking if this reproduces with "views-browser-windows" flag disabled or enabled? That will help us determine whether this is related to MacViews.
Owner: taku...@chromium.org
Hi takumif@ w.r.t #10

I retested the issue with 'views-browser-windows' flag both enabled & disabled condition and not able to reproduce the issue using the flag.
Thank you for checking Aiman, does that mean you weren't able to reproduce when the flag is enabled, but able to when disabled?
Owner: aiman.an...@etouch.net
Owner: taku...@chromium.org
Hi,

I was not able to reproduce the issue in both the condition flag enabled and disabled.

Thank You!
Status: WontFix (was: Assigned)
Thank you Aiman. Please re-open the bug if it reproduces again.

Sign in to add a comment