MacViews: fix all ViewsBrowserMode tests |
|||||||||||||||||||||
Issue descriptionThese tests fail: In browser_tests: AppControllerBrowserTest.CommandDuringShutdown AppControllerNewProfileManagementBrowserTest.AboutChromeForcesUserManager AppControllerNewProfileManagementBrowserTest.GuestProfileReopenWithNoWindows AppControllerNewProfileManagementBrowserTest.LockedProfileReopenWithNoWindows AppControllerNewProfileManagementBrowserTest.OpenGuestProfileOnlyIfGuestModeIsEnabled AppWindowAPITest.TestInitialBounds AppWindowAPITest.TestInitialConstraints AppWindowAPITest.TestMinimize ChromePasswordProtectionServiceBrowserTest.OpenChromeSettingsViaPageInfo ExtensionDisabledGlobalErrorTest.UninstallWhilePromptBeingShown ExtensionInstallDialogViewTest.InstallButtonDelay ExtensionUninstallDialogViewBrowserTest.TrackParentWindowDestructionAfterViewCreation ExtensionWindowCreateTest.AcceptState FindInPageControllerTest.FindMovesWhenObscuring GlobalErrorBubbleTest.InvokeUi_RecoveryInstallGlobalError GlobalKeyboardShortcutsTest.MenuCommandPriority InfoBarUiTest.InvokeUi_translate MediaRouterDialogControllerWebUIBrowserTest.ShowDialog MediaRouterIntegrationBrowserTest.OpenLocalMediaFileFailsAndShowsIssue MediaRouterIntegrationBrowserTest.OpenLocalMediaFileInNewTab PlatformAppBrowserTest.PrintPreviewShouldNotBeTooSmall ProfileChooserViewExtensionsTest.LockProfile ProfileChooserViewExtensionsTest.LockProfileBlockExtensions ProfileChooserViewExtensionsTest.LockProfileNoBlockOtherProfileExtensions ProfileListDesktopBrowserTest.SignOut ScrollbarTest.LongPromptScrollbar ScrollbarTest.ScrollbarRegression TranslateBrowserTest.BasicTranslation TranslateBrowserTest.TranslateRefreshMetaTagLongDelay TranslateWithSecureServerBrowserTest.TranslateInIsolatedWorld WebDialogBrowserTest.CloseParentWindow In interactive_ui_tests: CommandsApiTest.Basic [Fix in progress] CommandsApiTest.OverwriteBookmarkShortcutByUserOverridesWebKeybinding [Keybinding gets lost] We need to fix these in order to enable the fieldtrial. Resolved interactive_ui_tests: AppShimInteractiveTest.Launch BrowserCommandControllerInteractiveTest.ShortcutsShouldTakeEffectInWindowMode DevToolsManagerDelegateTest.MaximizedToMinimizedWindow [http://crbug.com/836327] DevToolsManagerDelegateTest.NormalToMaximizedWindow [http://crbug.com/836327] DevToolsManagerDelegateTest.RestoreMaximizedWindow [http://crbug.com/836327] OmniboxViewTest.BasicTextOperations OmniboxViewTest.TabAcceptKeyword OmniboxViewTest.UndoRedo WindowActivityWatcherTest.Basic
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/400802e24c3d2138cbc2badee8a778ad0ee00bd9 commit 400802e24c3d2138cbc2badee8a778ad0ee00bd9 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Thu Apr 19 19:47:50 2018 macviews: fix UserManager::IsShowing This method did the wrong thing in Mac Views mode. Fixing it fixes most of the AppControllerNewProfileManagementBrowserTest suite. Bug: 834754 Change-Id: I9e2971b4e5d3cff12a1629f70c96a5cb65e40aa1 Reviewed-on: https://chromium-review.googlesource.com/1020021 Reviewed-by: Sidney San MartÃn <sdy@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#552125} [modify] https://crrev.com/400802e24c3d2138cbc2badee8a778ad0ee00bd9/chrome/browser/ui/views/profiles/user_manager_view.cc
,
Apr 19 2018
,
Apr 20 2018
browser_tests as of this morning: AppControllerNewProfileManagementBrowserTest.LockedProfileReopenWithNoWindows ChromePasswordProtectionServiceBrowserTest.OpenChromeSettingsViaPageInfo ExtensionDisabledGlobalErrorTest.UninstallWhilePromptBeingShown ExtensionInstallDialogViewTest.InstallButtonDelay ExtensionUninstallDialogViewBrowserTest.TrackParentWindowDestructionAfterViewCreation ExtensionWindowCreateTest.AcceptState FindInPageControllerTest.FindMovesWhenObscuring GlobalErrorBubbleTest.InvokeUi_RecoveryInstallGlobalError GlobalKeyboardShortcutsTest.MenuCommandPriority InfoBarUiTest.InvokeUi_translate MediaRouterDialogControllerWebUIBrowserTest.ShowDialog MediaRouterIntegrationBrowserTest.OpenLocalMediaFileFailsAndShowsIssue PlatformAppBrowserTest.PrintPreviewShouldNotBeTooSmall ProfileChooserViewExtensionsTest.LockProfile ProfileChooserViewExtensionsTest.LockProfileBlockExtensions ProfileChooserViewExtensionsTest.LockProfileNoBlockOtherProfileExtensions ProfileListDesktopBrowserTest.SignOut ScrollbarTest.LongPromptScrollbar ScrollbarTest.ScrollbarRegression TranslateBrowserTest.BasicTranslation TranslateBrowserTest.TranslateRefreshMetaTagLongDelay TranslateWithSecureServerBrowserTest.TranslateInIsolatedWorld WebDialogBrowserTest.CloseParentWindow
,
Apr 20 2018
,
Apr 20 2018
,
Apr 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30b664a36b2876ce4684ab583ee1eaa00991118d commit 30b664a36b2876ce4684ab583ee1eaa00991118d Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Fri Apr 20 23:07:34 2018 macviews: handle user key equivalents There is special logic in ChromeCommandDispatcherDelegate's prePerformKeyEquivalent: method that handles user key equivalents for builtin browser commands. This same logic needs to happen in the Views browser, so the Views-side logic needs to consult the BrowserView's accelerator table to see if the key is bound. This involves an ungainly bridge, because it's not possible to include BrowserView and BrowserWindowController's full definitions at the same time - they have conflicting C++ and Objective-C class names in their dependencies. Bug: 834754 Change-Id: I67a62064d58cb7dba9c3bd532917ed1f90959340 Reviewed-on: https://chromium-review.googlesource.com/1022530 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#552513} [modify] https://crrev.com/30b664a36b2876ce4684ab583ee1eaa00991118d/chrome/browser/ui/BUILD.gn [add] https://crrev.com/30b664a36b2876ce4684ab583ee1eaa00991118d/chrome/browser/ui/cocoa/browser_view_bridge.h [add] https://crrev.com/30b664a36b2876ce4684ab583ee1eaa00991118d/chrome/browser/ui/cocoa/browser_view_bridge.mm [modify] https://crrev.com/30b664a36b2876ce4684ab583ee1eaa00991118d/chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.mm
,
Apr 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68b85b8ea6024a89dc7ac53dbb57d7da8c99b6a7 commit 68b85b8ea6024a89dc7ac53dbb57d7da8c99b6a7 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Sat Apr 21 00:36:54 2018 macviews: tell AppController about UserManager profiles The Mac AppController needs to know about the last active profile to keep the system menus updated and to know which profile to open when a first window is created. Usually this is tracked at profile creation, but since the UserManager is not a "browser window", the usual tracking logic doesn't apply and AppController has to be informed manually. This was done in UserManagerMac already. This change splits the logic for doing so out of UserManagerMac into the app_controller_mac namespace and invokes it from UserManagerView. This fixes a handful of browser_tests in Views mode on Mac, such as: ProfileChooserViewExtensionsTest.LockProfile* AppControllerNewProfileManagementBrowserTest.LockedProfileReopenWithNoWindows Bug: 834754 Change-Id: Ib80aa5a931c96b5d3b38d974f88402b2d4406255 Reviewed-on: https://chromium-review.googlesource.com/1022290 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#552532} [modify] https://crrev.com/68b85b8ea6024a89dc7ac53dbb57d7da8c99b6a7/chrome/browser/app_controller_mac.h [modify] https://crrev.com/68b85b8ea6024a89dc7ac53dbb57d7da8c99b6a7/chrome/browser/app_controller_mac.mm [modify] https://crrev.com/68b85b8ea6024a89dc7ac53dbb57d7da8c99b6a7/chrome/browser/ui/cocoa/profiles/user_manager_mac.mm [modify] https://crrev.com/68b85b8ea6024a89dc7ac53dbb57d7da8c99b6a7/chrome/browser/ui/views/profiles/user_manager_view.cc
,
Apr 23 2018
As of this morning, browser_tests has 10 failing: ExtensionWindowCreateTest.AcceptState FindInPageControllerTest.FindMovesWhenObscuring GlobalErrorBubbleTest.InvokeUi_RecoveryInstallGlobalError InfoBarUiTest.InvokeUi_translate MediaRouterDialogControllerWebUIBrowserTest.ShowDialog MediaRouterIntegrationBrowserTest.OpenLocalMediaFileFailsAndShowsIssue PlatformAppBrowserTest.PrintPreviewShouldNotBeTooSmall TranslateBrowserTest.BasicTranslation TranslateBrowserTest.TranslateRefreshMetaTagLongDelay TranslateWithSecureServerBrowserTest.TranslateInIsolatedWorld and interactive_ui_tests has 11 failing: AppShimInteractiveTest.Launch BrowserCommandControllerInteractiveTest.ShortcutsShouldTakeEffectInWindowMode CommandsApiTest.Basic CommandsApiTest.OverwriteBookmarkShortcutByUserOverridesWebKeybinding DevToolsManagerDelegateTest.MaximizedToMinimizedWindow DevToolsManagerDelegateTest.NormalToMaximizedWindow DevToolsManagerDelegateTest.RestoreMaximizedWindow OmniboxViewTest.BasicTextOperations OmniboxViewTest.TabAcceptKeyword OmniboxViewTest.UndoRedo WindowActivityWatcherTest.Basic
,
Apr 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f94b446e945dd3b48fc0c7714d9b5008c7e702f commit 5f94b446e945dd3b48fc0c7714d9b5008c7e702f Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Mon Apr 23 15:11:24 2018 macviews: don't try to show translate infobar for tests The translate infobar doesn't exist in MacViews; it always uses the translate bubble instead. Bug: 834754 Change-Id: I43a594603cc0ded30757738b890a3d4eac3d62e8 Reviewed-on: https://chromium-review.googlesource.com/1021677 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#552701} [modify] https://crrev.com/5f94b446e945dd3b48fc0c7714d9b5008c7e702f/chrome/browser/infobars/infobars_browsertest.cc
,
Apr 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b6ee73766a31793f9ae9d3480552b847def573b commit 0b6ee73766a31793f9ae9d3480552b847def573b Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Mon Apr 23 16:39:17 2018 Revert "macviews: handle user key equivalents" This reverts commit 30b664a36b2876ce4684ab583ee1eaa00991118d. Reason for revert: Introduced https://crbug.com/835541 Original change's description: > macviews: handle user key equivalents > > There is special logic in ChromeCommandDispatcherDelegate's > prePerformKeyEquivalent: method that handles user key equivalents for builtin > browser commands. This same logic needs to happen in the Views browser, so > the Views-side logic needs to consult the BrowserView's accelerator table > to see if the key is bound. > > This involves an ungainly bridge, because it's not possible to include > BrowserView and BrowserWindowController's full definitions at the same time - > they have conflicting C++ and Objective-C class names in their dependencies. > > Bug: 834754 > Change-Id: I67a62064d58cb7dba9c3bd532917ed1f90959340 > Reviewed-on: https://chromium-review.googlesource.com/1022530 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#552513} TBR=ellyjones@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 834754 Change-Id: Ide55313a12460a254a90324d19591e2bf9c950db Reviewed-on: https://chromium-review.googlesource.com/1023192 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#552726} [modify] https://crrev.com/0b6ee73766a31793f9ae9d3480552b847def573b/chrome/browser/ui/BUILD.gn [delete] https://crrev.com/cbf0de72d61cdd669f2021d3ebc7948372ce1ea3/chrome/browser/ui/cocoa/browser_view_bridge.h [delete] https://crrev.com/cbf0de72d61cdd669f2021d3ebc7948372ce1ea3/chrome/browser/ui/cocoa/browser_view_bridge.mm [modify] https://crrev.com/0b6ee73766a31793f9ae9d3480552b847def573b/chrome/browser/ui/cocoa/chrome_command_dispatcher_delegate.mm
,
Apr 24 2018
,
Apr 24 2018
,
Apr 24 2018
,
Apr 24 2018
,
Apr 24 2018
,
Apr 25 2018
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a2514704ddd8163a4ae6c09cd96f8d399572116 commit 8a2514704ddd8163a4ae6c09cd96f8d399572116 Author: Robert Liao <robliao@chromium.org> Date: Wed Apr 25 17:23:16 2018 Remove Cocoa Affordances from Omnibox interactive_ui_tests This change fixes changes some platform checks to TOOLKIT_VIEWS and allows the test to assume that Mac is always running with views enabled. Also the information about undo selection restoration has been moved to http://crbug.com/836490. BUG=834754,836490 Change-Id: I906e78fb4649c646f79c2d18e6d4222b7a25050d Reviewed-on: https://chromium-review.googlesource.com/1026881 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#553623} [modify] https://crrev.com/8a2514704ddd8163a4ae6c09cd96f8d399572116/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28e33c40d42bdabd4f0f525b05d9afe0cce48f38 commit 28e33c40d42bdabd4f0f525b05d9afe0cce48f38 Author: Robert Liao <robliao@chromium.org> Date: Wed Apr 25 18:28:17 2018 Disable DevToolsManagerDelegateTest Tests That Rely on Maximization for Mac MacViews does not yet implement maximized windows and a trivial implementation doesn't seem to work. BUG=834754,836327 Change-Id: I4fd6fbd4295134053cc58d028d0c2397088150a8 Reviewed-on: https://chromium-review.googlesource.com/1026350 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#553668} [modify] https://crrev.com/28e33c40d42bdabd4f0f525b05d9afe0cce48f38/chrome/browser/devtools/devtools_sanity_interactive_browsertest.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38a801fc0fcf76b2a162a0db09338f807990fbcb commit 38a801fc0fcf76b2a162a0db09338f807990fbcb Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Apr 25 20:58:47 2018 content: implement WebContentsViewMac::GetViewBounds This method is needed for positioning the find bar in Views browser mode. Bug: 834754 Change-Id: Id984e5281bf970c0c99af8696a6cebbb8ca4c2a3 Reviewed-on: https://chromium-review.googlesource.com/1028450 Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#553740} [modify] https://crrev.com/38a801fc0fcf76b2a162a0db09338f807990fbcb/content/browser/web_contents/web_contents_view_mac.mm
,
Apr 26 2018
,
Apr 26 2018
,
Apr 26 2018
,
Apr 26 2018
,
Apr 26 2018
interactive_ui_tests Currently Unresolved Failures
1 test failed:
WindowActivityWatcherTest.Basic
3 tests timed out:
BrowserCommandControllerInteractiveTest.ShortcutsShouldTakeEffectInWindowMode
CommandsApiTest.Basic
CommandsApiTest.OverwriteBookmarkShortcutByUserOverridesWebKeybinding
,
Apr 26 2018
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b73339dbd053f7abfb810af121dd98ecdae5af4 commit 2b73339dbd053f7abfb810af121dd98ecdae5af4 Author: Robert Liao <robliao@chromium.org> Date: Thu Apr 26 18:11:29 2018 Run the RunLoop While Waiting for the Window to Close in interactive_ui_test AppShimInteractiveTest.Launch NativeWidgetMac performs an asynchronous close [1] requiring the caller to ensure the current thread processes tasks. Failure to process tasks means the window never closes and the test hangs. [1] https://cs.chromium.org/chromium/src/ui/views/widget/native_widget_mac.mm?l=414&rcl=8de902e956420e0c1bf4edc0878d03796f5401c6 BUG= 834754 Change-Id: I878ad6bca8a190fdc08df063ba1633076b90a485 Reviewed-on: https://chromium-review.googlesource.com/1027082 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#554082} [modify] https://crrev.com/2b73339dbd053f7abfb810af121dd98ecdae5af4/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm
,
Apr 26 2018
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a78a27ebf69d7a4709a41dd80d1c80baca6208be commit a78a27ebf69d7a4709a41dd80d1c80baca6208be Author: Robert Liao <robliao@chromium.org> Date: Fri Apr 27 16:48:13 2018 Skip Waiting for Fullscreen for Mac in BrowserCommandControllerInteractiveTest.ShortcutsShouldTakeEffectInWindowMode ScopedFakeNSWindowFullscreen just makes the NSWindow larger without taking Chrome into fullscreen. As a result, chrome::NOTIFICATION_FULLSCREEN_CHANGED does not fire. Fullscreen appears to be performed synchronously with the keyboard event, so skipping the wait works. BUG=834754,837438 Change-Id: I337a44eefedfd382cc253aaf69590140fc557ba1 Reviewed-on: https://chromium-review.googlesource.com/1031617 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#554407} [modify] https://crrev.com/a78a27ebf69d7a4709a41dd80d1c80baca6208be/chrome/browser/ui/browser_command_controller_interactive_browsertest.cc
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e12d5de040e541e21501139e6683329a6f33937 commit 6e12d5de040e541e21501139e6683329a6f33937 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Fri Apr 27 20:23:23 2018 macviews: set up global error recovery state This setup needs to be done earlyish in the browser's lifetime so that the error badging can be shown and so that the global error bubble can appear. This fixes GlobalErrorBubbleTest.InvokeUi_RecoveryInstallGlobalError. Bug: 834754 Change-Id: I2b61beb1123436fd15c36d265d1eabbf6d9ded2f Reviewed-on: https://chromium-review.googlesource.com/1033437 Reviewed-by: Leonard Grey <lgrey@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#554489} [modify] https://crrev.com/6e12d5de040e541e21501139e6683329a6f33937/chrome/browser/ui/views/toolbar/toolbar_view.cc
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f963127f59a36ea56c3bf02bcd79e1870c2c018d commit f963127f59a36ea56c3bf02bcd79e1870c2c018d Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Fri Apr 27 21:21:35 2018 macviews: disable PrintPreviewShouldNotBeTooSmall This test doesn't pass when using Views browser windows on any platform, so skip the body on Mac when not using Cocoa windows. TBR=tapted@chromium.org Bug: 834754 Change-Id: I4c2d447ea5ef878eaf4e395195606be1951a0dae Reviewed-on: https://chromium-review.googlesource.com/1033439 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#554512} [modify] https://crrev.com/f963127f59a36ea56c3bf02bcd79e1870c2c018d/chrome/browser/apps/app_browsertest.cc
,
Apr 27 2018
,
Apr 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04da39fbaada0fcc1fa664ca90fac8f72089154c commit 04da39fbaada0fcc1fa664ca90fac8f72089154c Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Mon Apr 30 13:54:46 2018 macviews: disable infobar translate tests The infobar isn't supported at all in MacViews builds. TBR=andrewhayden@chromium.org Bug: 834754 Change-Id: I476fe3e1373d26d1c013011f1a33fbfce80a9ad1 Reviewed-on: https://chromium-review.googlesource.com/1032758 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#554737} [modify] https://crrev.com/04da39fbaada0fcc1fa664ca90fac8f72089154c/chrome/browser/translate/chrome_translate_client.cc [modify] https://crrev.com/04da39fbaada0fcc1fa664ca90fac8f72089154c/chrome/browser/translate/translate_browsertest.cc
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0fc05c7d28363f3d27da682d8feaf9240c341ca2 commit 0fc05c7d28363f3d27da682d8feaf9240c341ca2 Author: Robert Liao <robliao@chromium.org> Date: Tue May 01 16:17:18 2018 Add a New UKM Expectation Due to Activation BrowserView manual activation will trigger a new UKM entry. This is only done on Mac because the window itself isn't activated, possibly due to crbug.com/650859. BUG=834754,650859 Change-Id: I892e785009393ca6438715c2d0ea87c98ded284e Reviewed-on: https://chromium-review.googlesource.com/1036739 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#555059} [modify] https://crrev.com/0fc05c7d28363f3d27da682d8feaf9240c341ca2/chrome/browser/ui/tabs/window_activity_watcher_interactive_uitest.cc
,
May 3 2018
,
May 7 2018
,
May 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f19e58e7e6e58c17bb5e115a53ae7d02e949c79f commit f19e58e7e6e58c17bb5e115a53ae7d02e949c79f Author: Robert Liao <robliao@chromium.org> Date: Mon May 07 20:08:25 2018 Activate the Browser Window on Mac for interactive_ui_tests CommandsApiTest.Basic ExtensionKeybindingRegistryViews doesn't get registered until BrowserView receives activation at least once. On Mac, due to crbug.com/650859, widgets may not receive activation during tests. The impact here is that extension command keybindings never register and CommandsApiTest.Basic waits until timeout for the keybinding to trigger the command. The workaround activates the window for the test. BUG=834754,650859,839469 Change-Id: I0488e515cbcb5bd1941611b2c10d72cc9b69e7bd Reviewed-on: https://chromium-review.googlesource.com/1042787 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#556543} [modify] https://crrev.com/f19e58e7e6e58c17bb5e115a53ae7d02e949c79f/chrome/browser/extensions/extension_keybinding_apitest.cc
,
May 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6dedbc845f99f947ed2657c65c936794659b94a0 commit 6dedbc845f99f947ed2657c65c936794659b94a0 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed May 09 16:30:38 2018 macviews: default cocoa tests to Cocoa browser windows The bulk of these tests depend on having a Cocoa browser window and the related infrastructure. Bug: 834754 Change-Id: I304222489cf28fb8e69914f24ae646198aeca352 Reviewed-on: https://chromium-review.googlesource.com/1050194 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#557215} [modify] https://crrev.com/6dedbc845f99f947ed2657c65c936794659b94a0/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/6dedbc845f99f947ed2657c65c936794659b94a0/chrome/browser/ui/cocoa/test/cocoa_test_helper.h [modify] https://crrev.com/6dedbc845f99f947ed2657c65c936794659b94a0/chrome/test/BUILD.gn
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d308168d695f0e44a48cbd432460ca6c93913daf commit d308168d695f0e44a48cbd432460ca6c93913daf Author: Robert Liao <robliao@chromium.org> Date: Thu May 17 18:10:39 2018 Add Equivalent FindInPageControllerTest.GlobalPasteBoardClearMatches Using Interactive Text Input Views Textfields do not fire change updates when using SetText(), breaking any global pasteboard and Find Bar state updates. This workaround simulates text input, which does fire the events. BUG=843878,834754 Change-Id: I482854bb221bfbdc5bd430c6a631e5de29ecd725 Reviewed-on: https://chromium-review.googlesource.com/1063490 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#559609} [modify] https://crrev.com/d308168d695f0e44a48cbd432460ca6c93913daf/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc [modify] https://crrev.com/d308168d695f0e44a48cbd432460ca6c93913daf/chrome/browser/ui/find_bar/find_bar_platform_helper_mac_interactive_uitest.mm
,
May 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c027469a79d22342b1ef6ecc66cae1c3a319e808 commit c027469a79d22342b1ef6ecc66cae1c3a319e808 Author: Robert Liao <robliao@chromium.org> Date: Tue May 22 16:39:58 2018 Add Equivalent FindInPageControllerTest.IncognitoFindNextShared Using Interactive Text Input Views Textfields do not fire change updates when using SetText(), breaking any global pasteboard and Find Bar state updates. This workaround simulates text input, which does fire the events. BUG=843878,834754 Change-Id: Ic49927848e882a90bcb4f167136a9e8f8949c426 Reviewed-on: https://chromium-review.googlesource.com/1067785 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#560641} [modify] https://crrev.com/c027469a79d22342b1ef6ecc66cae1c3a319e808/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc [modify] https://crrev.com/c027469a79d22342b1ef6ecc66cae1c3a319e808/chrome/browser/ui/find_bar/find_bar_platform_helper_mac_interactive_uitest.mm
,
May 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfe6f41da41b4bf73cfc08eda3bfa7b71723ee0d commit dfe6f41da41b4bf73cfc08eda3bfa7b71723ee0d Author: Robert Liao <robliao@chromium.org> Date: Tue May 22 16:46:11 2018 Add Equivalent FindInPageControllerTest.PreferPreviousSearch Using Interactive Text Input Views Textfields do not fire change updates when using SetText(), breaking any global pasteboard and Find Bar state updates. This workaround simulates text input, which does fire the events. BUG=843878,834754 Change-Id: I044e5dbb4961658adf19d509cdf764cdecfbc78c Reviewed-on: https://chromium-review.googlesource.com/1068266 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#560650} [modify] https://crrev.com/dfe6f41da41b4bf73cfc08eda3bfa7b71723ee0d/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc [modify] https://crrev.com/dfe6f41da41b4bf73cfc08eda3bfa7b71723ee0d/chrome/browser/ui/find_bar/find_bar_platform_helper_mac_interactive_uitest.mm
,
Sep 17
,
Dec 3
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Apr 19 2018