Regression:Focus gets lost on the 'Add Person' overlay on pressing tab
Reported by
vineetha...@etouch.net,
Apr 19 2018
|
||||
Issue descriptionChrome Version: 68.0.3400.0 (Official Build) Revision 9f775bf70a07668811dfc3b55bbd2e5f9c910fd0-refs/heads/master@{#551875} (32/64 bit) OS: Win(7, 8, 8.1, 10), Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.13.5) What steps will reproduce the problem? (1) Launch Chrome, click on Avatar icon > Manage people > Add Person. (2) Press tab to traverse focus throughout overlay and observe. Actual Result: Focus gets lost on the 'Add Person' overlay on pressing tab. Expected Result: Focus should not get lost on the 'Add Person' overlay on pressing tab. This is regression issue broken in ‘M-68’ and providing the bisect info below, (Unable to provide bisect using per-revision script,Hence providing bisect with old script): Good build: 68.0.3398.0(Revision: 551179) Bad build: 68.0.3399.0 (Revision: 551554) Narrow Bisect info : https://chromium.googlesource.com/chromium/src/+log/6d63741eb2341faf50f9339779229e92b1e3cb8b..6da8cdce810f0b9cf331a7191f43a40aaeda1279?pretty=fuller&n=10000 Suspecting: r551209? @dpapad: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank You!
,
Apr 19 2018
Candidate fix at https://chromium-review.googlesource.com/c/chromium/src/+/1019351
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f8e8f12f20093a16135f29b25621baa778947a4 commit 8f8e8f12f20093a16135f29b25621baa778947a4 Author: Demetrios Papadopoulos <dpapad@chromium.org> Date: Thu Apr 19 23:17:58 2018 WebUI cr-profile-avatar-selector: Fix focus background color. Removing the --paper-button CSS mixin at r551209 changed the specificty of CSS rules being applied. Fixed by using the keyboard-focus class directly, instead of relying on yet another mixin --paper-button-flat-keyboard-focus. Bug: 834739 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iabd8f698a2b1ed65bb98af6a86fe2f957280ae61 Reviewed-on: https://chromium-review.googlesource.com/1019880 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#552197} [modify] https://crrev.com/8f8e8f12f20093a16135f29b25621baa778947a4/ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector.html
,
Apr 20 2018
Update : Rechecked the above issue on Win(7, 8, 8.1, 10), Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.13.5) OS with latest Canary Chrome version #68.0.3401.0 and the issue is fixed. Kindly refer the attached screen cast.
,
Apr 20 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dpa...@chromium.org
, Apr 19 2018