Select all replaces text with 'A' in Pdf forms in Mac OS |
||||||
Issue descriptionChrome Version: 68.0.3400.0 OS: Mac OS What steps will reproduce the problem? (1)Navigate to pdf form http://www.impotsdirects.public.lu/content/dam/acd/fr/formulaires/pers_physiques/2016/100-2016-f-i101.pdf and enter some text in the text field. (2)Select some part of the text -> right click -> select 'Select All' option from Context menu. What is the expected result? The whole text should be selected. What happens instead? The selected text is replaced by 'A' Attached is the screen cast for reference. Issue is not observed on Windows 10 and Ubuntu 14.04. Assigning the issue to thestig@ as this issue is related to the CL landed in issue 753216 .
,
Apr 21 2018
Not a regression. This is something that never worked in the first place.
,
Apr 23 2018
Issue 835786 has been merged into this issue.
,
Apr 24 2018
I split off the issue in comment 1 into bug 836074, since fixing that will take a bit more work.
,
Apr 24 2018
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/842b2bad2021a93292f791f84cfba1e459343e7d commit 842b2bad2021a93292f791f84cfba1e459343e7d Author: Lei Zhang <thestig@chromium.org> Date: Tue Apr 24 20:48:36 2018 PDF: Fix "Select all" context menu item in forms on Mac. There is a pre-existing bug on Mac where Control + A performs "Select all" instead of Command + A. The equivalent context menu item just sends the keystroke to perform "Select all". As such, when it tried to do the right thing and use the Command modifier, "Select all" does not actually work. To fix this quickly, just make the context menu item send Control + A. Of course this is not ideal, but making Command + A perform "Select all" is harder than it appears. BUG= 834735 ,836074 Change-Id: I2c8201772d7e901984c427d0977a1fb899f802b5 Reviewed-on: https://chromium-review.googlesource.com/1025403 Reviewed-by: dsinclair <dsinclair@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#553264} [modify] https://crrev.com/842b2bad2021a93292f791f84cfba1e459343e7d/content/renderer/pepper/pepper_plugin_instance_impl.cc
,
Apr 24 2018
,
Apr 25 2018
Able to reproduce this issue on Mac OS 10.13.1 on the reported version 68.0.3400.0 and the issue is fixed on the latest Canary 68.0.3406.0 as per the original comment. On navigating to the link given above, entered some text in the form -> Right click -> select all option in Context menu, can observe the whole text is selected. Attached is the screen cast for reference. Hence adding TE verified labels as the fix is working as intended. Thanks.. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by thestig@chromium.org
, Apr 20 2018