New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 834733 link

Starred by 2 users

Issue metadata

Status: Available
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Page got stuck and does not navigated to google.com after siging out from NTP.

Reported by db...@etouch.net, Apr 19 2018

Issue description

Chrome Version: 68.0.3400.0 Revision 9f775bf70a07668811dfc3b55bbd2e5f9c910fd0-refs/heads/master@{#551875}(32/64 bit)
OS: Windows(7,8,8.1,10), Mac(10.12.6,10.13.1,10.13.5)

What steps will reproduce the problem?
(1) Launch chrome, navigate to gmail.com sign in with valid crendentials.
(2) Now open NTP and click on profile icon button and select sign out option.
(3) Observe page.

Actual: Page got stuck and does not navigated to google.com after siging out.

Expected: Page should navigated to google.com after siging out.

This is a regression issue, broken in 'M65', provinding bisect using bisect per revision":

Good Build: 65.0.3295.0
Bad Build: 65.0.3296.0 

You are probably looking for a change made after 524528 (known good), but no later than 524529 (first known bad).

CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
 
https://chromium.googlesource.com/chromium/src/+log/24abf78274e01a17c4f0a4c8cc18e55720f3b3b9..3b60933b099bba43823b2c5cbdbe7c3f2e90ae68

Ssupect: https://chromium.googlesource.com/chromium/src/+/3b60933b099bba43823b2c5cbdbe7c3f2e90ae68

@<alexmos: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: Issue is also seen on M66 Stable build #66.0.3359.117, M66 Beta build #66.0.3359.117 and  M67 Dev build #67.0.3393.4
 
Actual_Navigation.mp4
667 KB View Download
Expected_Navigation.mp4
372 KB View Download
Cc: treib@chromium.org creis@chromium.org ew...@chromium.org msarda@chromium.org
I'll verify whether sign-in isolation caused the behavior change here, but if so, it has been enabled since M63, so this isn't a recent regression.

What I'm curious about is whether we intentionally navigated to google.com after being signed out, or whether the new behavior is actually more desirable.  It seems that we started out on the NTP (blank address bar), then signed out - wouldn't it make sense to stay on the NTP instead of navigating to google.com, which is what seems to happen?  Could this have been broken before and "fixed" by sign-in isolation?

+msarda@, ewald@ from sign-in, +treib@ from NTP - any ideas about this?

Comment 2 by ew...@chromium.org, Apr 20 2018

Components: Services>SignIn
Labels: -Pri-1 Pri-2
Owner: sabineb@chromium.org
Assigning to Sabine as the new owner for sign-in and bumping down the priority. I'd be surprised if this were caused by a change in Chrome. Either way, I agree with Alex's assessment; this doesn't feel like a bug, it seems like the "new" behavior is better.

Sabine can decide how to prioritize and triage. I would just mark it as WontFix.

Comment 3 by treib@chromium.org, Apr 20 2018

Cc: ramyan@chromium.org
+ramyan (new NTP owner) FYI

It seems plausible that this could be caused by sign-in isolation somehow, but if not, it might as well be a change to the OneGoogleBar.

Anyway, I agree that the new behavior seems like an improvement, let's keep it :)
One minor bug I noticed in the "Actual" video: After the sign-out, the actual NTP URL shows up in the tab bar rather than "New Tab".
Labels: zine-triaged
Project Member

Comment 5 by sheriffbot@chromium.org, May 25 2018

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by ramyan@chromium.org, Jun 26 2018

Cc: yyushkina@chromium.org
+Yana FYI

I agree that staying on the NTP after signing out from the NTP would be fine behaviour. However, this is not what I observed in the latest M68 Beta (see attached screencast), where 'Continue' forwards to google.com. The tab bar shows the correct site title ("Google"), instead of the URL, so I don't think there's any NTP work here.

Since this is no longer a regression, perhaps the bug can be closed?
SignoutFromNTP.mov
4.6 MB View Download
Status: Assigned (was: Available)
Project Member

Comment 8 by sheriffbot@chromium.org, Sep 3

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Target-66 -Target-67 -Target-68
Removing older targets for NTP.

Sign in to add a comment